Re: RFR 8157992: Improve jlink help message on optimization-related options

2016-09-02 Thread Jim Laskey (Oracle)
+1 > On Sep 2, 2016, at 6:10 AM, Sundararajan Athijegannathan > wrote: > > Cleas, Alan: > > Thanks for the reviews. Uploaded updated webrev for the record: > http://cr.openjdk.java.net/~sundar/8157992/webrev.02/ > > And going ahead with push.. > >

Re: Multiple versions of a non-exported dependency

2016-09-02 Thread Alan Bateman
On 02/09/2016 10:35, Richard Opalka wrote: : Will Java support classpath forever or there are plans to remove it? Asking because if classpath would be removed some time in the future such compromise (automatic modules) is just short term win affecting many key design decisions. I'm not aware

Re: Multiple versions of a non-exported dependency

2016-09-02 Thread Richard Opalka
On 09/02/2016 10:27 AM, Alan Bateman wrote: On 01/09/2016 21:04, cowwoc wrote: Another possibility (not saying it's better, just putting it out there) is to do the following: 1. Provide a tool like "javah" that would generate module-info.java for non-modularized JAR files. Look at

Re: Multiple versions of a non-exported dependency

2016-09-02 Thread Alan Bateman
On 01/09/2016 21:04, cowwoc wrote: Another possibility (not saying it's better, just putting it out there) is to do the following: 1. Provide a tool like "javah" that would generate module-info.java for non-modularized JAR files. Look at `jdeps --gen-module-info ..`. It's a starting

Re: RFR 8157992: Improve jlink help message on optimization-related options

2016-09-02 Thread Alan Bateman
On 02/09/2016 07:07, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8157992/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8157992 "details" should have one "d" :-) Looks fine otherwise.

Re: RFR: JDK-8161230 ClassLoader: add resource methods returning java.util.stream.Stream

2016-09-02 Thread Patrick Reinhart
On 2016-09-02 08:09, Andrej Golovnin wrote: src/java.base/share/classes/java/lang/ClassLoader.java The constant RESOURCE_CHARACTERISTICS in the line 215 should be defined near the #streamOf()-method. The distance between the line 1412 where the #streamOf()-method is defined and the line 215 is

RFR 8157992: Improve jlink help message on optimization-related options

2016-09-02 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8157992/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8157992 Thanks -Sundar