Re: Review Request: JDK-8166860 Add magic number to jmod file

2016-10-04 Thread Jonathan Gibbons
Langtools change looks good, -- Jon On 09/30/2016 09:29 PM, Mandy Chung wrote: Jon points out that javac should also be updated. javac currently opens the JMOD file with JarFileSystem. Jon and I discussed this and we agree to keep the current workaround for now and add the validation to

Re: Maven annotation processing fails with JDK9-ea+138

2016-10-04 Thread Jonathan Gibbons
If the annotation processor is trying to execute code in that module, you may want -J--add-modules=java.xml.bind to add the module to the javac runtime environment, as compared to the compilation environment -- Jon On 10/4/16 11:48 AM, Stephen Felts wrote: In JDK9, the java.xml.bind module

RE: Maven annotation processing fails with JDK9-ea+138

2016-10-04 Thread Stephen Felts
In JDK9, the java.xml.bind module is hidden by default. You can normally turn it on by specifying --add-modules=java.xml.bind -Original Message- From: Christian Beikov [mailto:christian.bei...@gmail.com] Sent: Tuesday, October 04, 2016 2:22 PM To: jigsaw-dev@openjdk.java.net Subject:

Maven annotation processing fails with JDK9-ea+138

2016-10-04 Thread Christian Beikov
Hello, I have been trying out to build one of my Maven projects with JDK 9-ea+138 and it failed. Specifically I got java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException during annotation processing. I am using the org.bsc.maven:maven-processor-plugin:2.2.4 and the annotation

Review Request: Apache Maven Recipe for module-info and older projects

2016-10-04 Thread Robert Scholte
Hi, I've written a page[1] about the problem related to projects which need to be compatible with pre Java9 versions, but also want to provide a module-info file in case it is used in a Java 9 project. This is mainly an issue for library builders, end-application builders can simply push