Re: Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

> On Dec 15, 2016, at 5:12 PM, Paul Sandoz wrote: > > >> On 15 Dec 2016, at 10:53, Mandy Chung wrote: >> >> This updates the GenGraphs build tool to generate a dot file for >> `java.se` and `java.se.ee` modules including API dependences only >>

Re: Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

> On 15 Dec 2016, at 10:53, Mandy Chung wrote: > > This updates the GenGraphs build tool to generate a dot file for > `java.se` and `java.se.ee` modules including API dependences only > that can be used to display Java SE module graph. > >

Re: NCDFE on jdk.internal.reflect.SerializationConstructorAccessorImpl

Hi Andrew, I'm redirecting this to jigsaw-dev as it seems to be a modularity related problem. Additional comment below ... David On 16/12/2016 7:48 AM, Andrew Guibert wrote: Hello all, I've been doing some experimentation with WebSphere Liberty on Java 9 and ran into a problem that I

hg: jigsaw/jake/jdk: jmod/jar tool: Document extra options in help

Changeset: 1bd62b2bc515 Author:chegar Date: 2016-12-15 21:28 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1bd62b2bc515 jmod/jar tool: Document extra options in help ! src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java !

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: 190ca89e298e Author:alanb Date: 2016-12-15 21:24 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/190ca89e298e Recorded hashes not preserved when patching ! src/java.base/share/classes/jdk/internal/module/ModulePatcher.java Changeset: c02bcacee98f Author:

hg: jigsaw/jake/jdk: SystemModuleFinder.Hashes class not needed - review feedback from Claes

Changeset: 9db6639ded4c Author:mchung Date: 2016-12-15 13:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9db6639ded4c SystemModuleFinder.Hashes class not needed - review feedback from Claes ! src/java.base/share/classes/jdk/internal/module/SystemModuleFinder.java

Review Request JDK-8171323: generate dot file for java.se and java.se.ee with only API dependences

This updates the GenGraphs build tool to generate a dot file for `java.se` and `java.se.ee` modules including API dependences only that can be used to display Java SE module graph. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171323/webrev.00/ Mandy

Re: 8170987: Module system implementation refresh (12/2016)

> On Dec 15, 2016, at 10:13 AM, Alan Bateman wrote: > > On 15/12/2016 14:13, Claes Redestad wrote: > >> >> The context here, I assume, is the increased startup cost to initialize >> java.util.regex in 9 (and a few regression fixes related to this that >> I've done in

Re: 8170987: Module system implementation refresh (12/2016)

On 15/12/2016 14:13, Claes Redestad wrote: The context here, I assume, is the increased startup cost to initialize java.util.regex in 9 (and a few regression fixes related to this that I've done in the area which may have involved avoiding adding a regex-free fast path for trivial but common

Re: RFR 8171316: Add IMPLEMENTOR property to the release file

> On Dec 15, 2016, at 7:32 AM, Sundararajan Athijegannathan > wrote: > > Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 > > top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ > jdk webrev:

Re: RFR 8171316: Add IMPLEMENTOR property to the release file

Looks good to me. /Erik On 2016-12-15 16:32, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ jdk webrev:

Re: --add-opens on an automatic module ?

I can confirm that we see this same exception using jdk-9+146 with _JAVA_OPTIONS="-Dsun.reflect.debugModuleAccessChecks=true" It doesn't seem related to any recent changes then. -- Kevin Kevin Rushforth wrote: Ah, thanks, I missed your email suggesting the same thing. I can test this and

Re: RFR 8171316: Add IMPLEMENTOR property to the release file

+1 > On Dec 15, 2016, at 11:32 AM, Sundararajan Athijegannathan > wrote: > > Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 > > top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ > jdk webrev:

Re: 8170987: Module system implementation refresh (12/2016)

2016/12/14 15:31:18 -0800, claes.redes...@oracle.com: > ... > > WARNING could be a local anonymous class inside > printStackTraceIfExposedReflectively. ;-) Good point -- fixed. - Mark

hg: jigsaw/jake/jdk: DEBUG_ADD_OPENS: Anonymize the WARNING exception class

Changeset: 7224d3b718ed Author:mr Date: 2016-12-15 07:15 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7224d3b718ed DEBUG_ADD_OPENS: Anonymize the WARNING exception class ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java

Re: --add-opens on an automatic module ?

Ah, thanks, I missed your email suggesting the same thing. I can test this and report back. -- Kevin Claes Redestad wrote: Yes. "is this something that is logged when you are using -Dsun.reflect.debugModuleAccessChecks=true? In that case this could be a pre-existing exception that is/was

Re: --add-opens on an automatic module ?

Yes. "is this something that is logged when you are using -Dsun.reflect.debugModuleAccessChecks=true? In that case this could be a pre-existing exception that is/was being swallowed." http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-December/010587.html /Claes On 2016-12-15 16:02, Kevin

Re: --add-opens on an automatic module ?

Is it possible that this exception, which seems harmless as far as I can tell, predates the latest jdk-9+148 jigsaw updates, and that the only reason we are seeing it now is because of the "-Dsun.reflect.debugModuleAccessChecks=true" ? -- Kevin David Hill wrote: Alan, I thought I would

Re: --add-opens on an automatic module ?

Alan, I thought I would toss you the options and the full exception just in case you see something really obvious. thanks, Dave public class GradleResolveVisitor extends ResolveVisitor { Running with jdk build 148, gradle 3.1 ddhill@ddhill-pad:~/sb/9/graphics/rt$ echo $_JAVA_OPTIONS

Re: 8170987: Module system implementation refresh (12/2016)

> On 15 Dec 2016, at 01:17, Mandy Chung wrote: > ... > > src/java.base/share/classes/jdk/internal/module/ModuleResolution.java > > 64 throw new RuntimeException("cannot add deprecated to " + > value); > > This comment applies to ModuleResoluton::with*

Re: 8170987: Module system implementation refresh (12/2016)

Langtools changes look good - I like the changes in ClassReader/Writer. Maurizio On 14/12/16 21:46, Alan Bateman wrote: Folks on jigsaw-dev will be aware that we are on yet another mission to bring the changes accumulated in the jake forest to jdk9/dev. The plan this time is to bring the

hg: jigsaw/jake/jdk: tools/jimage/VerifyJimage.java failing with incubator modules

Changeset: fbb8f2c7f236 Author:alanb Date: 2016-12-15 12:35 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fbb8f2c7f236 tools/jimage/VerifyJimage.java failing with incubator modules ! test/tools/jimage/VerifyJimage.java

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

On 13/12/2016 21:18, Peter Levart wrote: I think this is OK. Just a couple of nits in test: 1. You create a static Path bob = Paths.get("bob") field, but then you don't use it in: 56 try (FileChannel fc = FileChannel.open(Paths.get("bob"), CREATE, WRITE)) { Adding to Peter's

hg: jigsaw/jake/jdk: 45 new changesets

Changeset: 4629fe47e826 Author:sherman Date: 2016-12-06 14:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4629fe47e826 8170828: test/java/util/zip/ZipFile/TestZipFile needs @modules to work with Method.setAccessible() Reviewed-by: martin, rriggs !

hg: jigsaw/jake: 8 new changesets

Changeset: 1620754492a5 Author:stsmirno Date: 2016-12-07 09:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/1620754492a5 8170530: bash configure output contains a typo in a suggested library name Reviewed-by: ihse ! common/autoconf/generated-configure.sh !

hg: jigsaw/jake/langtools: 10 new changesets

Changeset: 0bdb7cb95c68 Author:lana Date: 2016-12-07 05:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0bdb7cb95c68 8169618: JDK9 message drop interim resource updates - OpenJDK Reviewed-by: rfield, peytoia, joehw, weijun Contributed-by: li.ji...@oracle.com !

hg: jigsaw/jake/hotspot: 5 new changesets

Changeset: bdfe30141ef6 Author:ihse Date: 2016-12-07 09:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bdfe30141ef6 8170629: Remove code duplication in test makefiles Reviewed-by: erikj, dholmes ! test/Makefile Changeset: cc0b239d99a9 Author:erikj Date:

hg: jigsaw/jake/jaxp: 6 new changesets

Changeset: 1ede1ddbd43a Author:ihse Date: 2016-12-07 09:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/1ede1ddbd43a 8170629: Remove code duplication in test makefiles Reviewed-by: erikj, dholmes ! test/Makefile Changeset: 427ce6a2c674 Author:fyuan Date:

hg: jigsaw/jake/corba: 2 new changesets

Changeset: 56d764f5b735 Author:lana Date: 2016-12-14 20:23 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/56d764f5b735 Added tag jdk-9+149 for changeset 00b19338e505 ! .hgtags Changeset: c7995982569d Author:alanb Date: 2016-12-15 11:42 + URL:

hg: jigsaw/jake/nashorn: 4 new changesets

Changeset: a42ebb5ed04b Author:ihse Date: 2016-12-07 09:48 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/a42ebb5ed04b 8170629: Remove code duplication in test makefiles Reviewed-by: erikj, dholmes ! test/Makefile Changeset: c281306d33d8 Author:lana Date:

Re: 8170987: Module system implementation refresh (12/2016)

On 15/12/2016 01:17, Mandy Chung wrote: I have pushed the change to rename jdk.crypto.pkcs11 and jdk.pack200 and dropped java.compact$N. So module-info.java changes will not be needed when you sync with jdk9/dev. Thank you. I'll do a merge today to see that everything works together. : Not

hg: jigsaw/jake/jdk: 4 new changesets

Changeset: bb62b60643d5 Author:alanb Date: 2016-12-15 08:39 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/bb62b60643d5 Tweaks to Lookup::dropLookupMode Contributed-by: john.r.r...@oracle.com ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java !

Re: 8170987: Module system implementation refresh (12/2016)

On 14/12/2016 23:31, Claes Redestad wrote: Hi, I took a quick pass over the jdk changes. It generally looks very good, but I've got some comments: MethodHandles.Lookup.dropLookupMode: The javadoc doesn't really roll of the tongue here. Maybe "Creates a new lookup from the current one where