Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-09 Thread Jochen Theodorou
On 09.01.2017 12:47, Andrew Dinn wrote: [...] If you carefully review discussion on the subject of this (slightly false) dichotomy between static and dynamic capabilities I think you will find that there has been a lot of explicit discussion. In my view, your summary of the status quo is at best

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

2017-01-09 Thread harold seigel
Hi Claes, The changes look good. Could you run the RBT hs nightly tests against the Linux-x64 platform before pushing this change? Thanks, Harold On 1/6/2017 9:35 AM, Claes Redestad wrote: Hi Harold, sure, I've updated the patch in-place with this small improvement and submitted a new

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

2017-01-09 Thread serguei.spit...@oracle.com
On 1/9/17 04:16, Claes Redestad wrote: Hi Serguei, On 2017-01-09 09:11, serguei.spit...@oracle.com wrote: Hi Claes, It looks pretty good. thanks, One question on the following fragment:

Attempting to configure jake

2017-01-09 Thread Phoenyx33 Cynaed
I have downloaded the Jigsaw(Jake) repositorys per the instructions, I have JDK8 installed and Visual Studio 12 installed. When I run configure from the top directory it dies on the Visual Studio test as below: configure: Found Visual Studio installation at /C/Program Files (x86)/Microsoft Visual

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

2017-01-09 Thread Claes Redestad
Hi Serguei, On 2017-01-09 09:11, serguei.spit...@oracle.com wrote: Hi Claes, It looks pretty good. thanks, One question on the following fragment: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/src/java.base/share/native/libjava/Module.c.udiff.html + int valid = 1; + for (idx = 0;

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-09 Thread Andrew Dinn
On 09/01/17 09:53, Alessio Stalla wrote: > Jochen, what you say resonates with me a lot too. And though I don't want > to hijack the thread to a pointless Java-is-dying flame, I have to say one > thing: > Java won because of its (imperfect, but surprisingly usable and versatile) > balance between

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-09 Thread Remi Forax
What jigsaw downgrade is the reflection API, deep reflection now requires a module (or a package) to be open, that's true. Reflection is not the only way to do monkey patching, agents can still do whatever they want and jigsaw also introduce new ways to do monkey patching with the Layer API. By

Re: Suggestion: allow accessible reflection on protected methods of exported types.

2017-01-09 Thread Alessio Stalla
Jochen, what you say resonates with me a lot too. And though I don't want to hijack the thread to a pointless Java-is-dying flame, I have to say one thing: Java won because of its (imperfect, but surprisingly usable and versatile) balance between static and dynamic. And lots of marketing, of

Re: Valid characters in a module name

2017-01-09 Thread Peter Levart
Hi Ess, On 01/09/2017 01:55 AM, Ess Kay wrote: > If this sequence of characters appear in source at position where identifier is expected: > #"\\u0022\\\"" > then they are interpreted as an identifier with following characters: > \u0022\" Then what happens when a user wants to specify the

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

2017-01-09 Thread serguei.spit...@oracle.com
Hi Claes, It looks pretty good. One question on the following fragment: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/src/java.base/share/native/libjava/Module.c.udiff.html + int valid = 1; + for (idx = 0; idx < num_packages; idx++) { + jstring pkg = (*env)->GetObjectArrayElement(env,