hg: jigsaw/jake/jdk: Minor clean up on StackWalker::getCallerClass spec

2017-01-20 Thread mandy . chung
Changeset: cbf1e85f7c11 Author:mchung Date: 2017-01-20 19:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cbf1e85f7c11 Minor clean up on StackWalker::getCallerClass spec ! src/java.base/share/classes/java/lang/StackWalker.java

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Mandy Chung
Updated webrev to put the temporary file in the same containing directory of the target file: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 I want to fix this regression in jdk-9+154. We can revisit the approach after this fix if necessary. Mandy > On Jan 20, 2017, at

What is the purpose of --inherit-runtime-environment

2017-01-20 Thread Nicolai Parlog
Hi! Pretty much what the subject line says... I don't quite get what exactly --inherit-runtime-environment does and what it is good for. Is this something that non-JDK developers are likely to use? so long ... Nicolai -- PGP Key:

Re: RFR 8172527: Rename jdk.crypto.token to jdk.crypto.cryptoki

2017-01-20 Thread Mandy Chung
> On Jan 20, 2017, at 10:22 AM, Anthony Scarpino > wrote: > > Good catch.. that'll teach me for trusting the graphical tool to rename a > directory when I used 'Rename'. > > Also I found Brad's issue as it was a new changeset that just showed up in > that file.

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Mandy Chung
> On Jan 20, 2017, at 1:22 PM, Alan Bateman wrote: > > Mandy - a while back then Erik changed the build so that JMOD files are > created in JMODS_TEMPDIR rather than JMODS_DIR. I think this was to reduce > interference with concurrent execution of the `jmod` tool.

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Alan Bateman
On 20/01/2017 20:37, Peter Levart wrote: I guess the JmodTask is creating a temp file because it wants the file to not be observed by other processes while it is being written to, right? At the end when the tempTarget is fully written, it is renamed to its intended name with:

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Mandy Chung
> On Jan 20, 2017, at 12:37 PM, Peter Levart wrote: > > I guess the JmodTask is creating a temp file because it wants the file to not > be observed by other processes while it is being written to, right? At the > end when the tempTarget is fully written, it is renamed

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Peter Levart
Hi Mandy, On 01/20/2017 05:55 PM, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.00/index.html A recent change in jmod tool [1] creates the JMOD file with no group and other readable permission as that’s the default permission when creating a

Re: RFR 8172527: Rename jdk.crypto.token to jdk.crypto.cryptoki

2017-01-20 Thread Anthony Scarpino
On 01/19/2017 11:50 AM, Mandy Chung wrote: On Jan 19, 2017, at 11:39 AM, Anthony Scarpino wrote: Hi, I need a review to rename the jdk.crypto.token to jdk.crypto.cryptoki. This is to change what 8171202 had done to the original jdk.crypto.pkcs11 module. For

Review Request: JDK-8173096 jmod files are not world-readable

2017-01-20 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.00/index.html A recent change in jmod tool [1] creates the JMOD file with no group and other readable permission as that’s the default permission when creating a temporary file with Files::createTempFile. This fixes the

Re: RFR 8172659: PluginException("TargetPlatform attribute is missing ...") - should be ModuleTarget

2017-01-20 Thread Mandy Chung
+1 Mandy > On Jan 20, 2017, at 1:06 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8172659/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8172659 > > Thanks, > -Sundar

Re: RFR 8172659: PluginException("TargetPlatform attribute is missing ...") - should be ModuleTarget

2017-01-20 Thread Jim Laskey (Oracle)
+1 > On Jan 20, 2017, at 5:06 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8172659/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8172659 > > Thanks, > -Sundar

hg: jigsaw/jake/langtools: 21 new changesets

2017-01-20 Thread alan . bateman
Changeset: 5ec5a14e1627 Author:jlahoda Date: 2017-01-09 16:44 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5ec5a14e1627 8172411: -XDnoModules must be removed Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java !

hg: jigsaw/jake/jdk: 52 new changesets

2017-01-20 Thread alan . bateman
Changeset: d93e93939378 Author:mli Date: 2017-01-09 14:14 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d93e93939378 8172347: Refactoring src/java.rmi/share/classes/sun/rmi/registry/RegistryImpl.java to improve testability of rmiregistry Reviewed-by: rriggs, msheppar

hg: jigsaw/jake/nashorn: 6 new changesets

2017-01-20 Thread alan . bateman
Changeset: 6b43eb787db4 Author:sundar Date: 2017-01-10 18:50 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/6b43eb787db4 8172493: Nashorn FX example 3-4 using load for fx: scripts fails to run with latest jdk9 ea build Reviewed-by: hannesw, jlaskey !

hg: jigsaw/jake/corba: 2 new changesets

2017-01-20 Thread alan . bateman
Changeset: d66f97a610a6 Author:lana Date: 2017-01-19 22:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/d66f97a610a6 Added tag jdk-9+153 for changeset 68a8e8658511 ! .hgtags Changeset: 15bf1182a36c Author:alanb Date: 2017-01-20 11:45 + URL:

hg: jigsaw/jake: 17 new changesets

2017-01-20 Thread alan . bateman
Changeset: 4650659a4f55 Author:erikj Date: 2017-01-10 11:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/4650659a4f55 8172241: Cleanup mistakes in jib publish support change Reviewed-by: tbell ! common/autoconf/spec.gmk.in ! common/conf/jib-profiles.js ! make/Bundles.gmk

hg: jigsaw/jake/jaxws: 5 new changesets

2017-01-20 Thread alan . bateman
Changeset: a98174edd246 Author:aefimov Date: 2017-01-10 22:15 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/a98174edd246 8159058: SAXParseException when sending soap message Reviewed-by: lancea !

hg: jigsaw/jake/jaxp: 5 new changesets

2017-01-20 Thread alan . bateman
Changeset: 8c9a2a24752b Author:joehw Date: 2017-01-11 13:06 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/8c9a2a24752b 8171243: CatalogManager.catalogResolver throws FileSystemNotFoundException with jar Reviewed-by: rriggs, dfuchs, lancea, alanb !

hg: jigsaw/jake/hotspot: 2 new changesets

2017-01-20 Thread alan . bateman
Changeset: fc7e94cb7485 Author:lana Date: 2017-01-19 22:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/fc7e94cb7485 Added tag jdk-9+153 for changeset 217ba81b9a4c ! .hgtags Changeset: 68e5712046cb Author:alanb Date: 2017-01-20 11:38 + URL:

hg: jigsaw/jake/jdk: More javadoc clean-up

2017-01-20 Thread alan . bateman
Changeset: 9cf519e0821d Author:alanb Date: 2017-01-20 11:30 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9cf519e0821d More javadoc clean-up ! src/java.base/share/classes/java/lang/module/Configuration.java !

RFR 8172659: PluginException("TargetPlatform attribute is missing ...") - should be ModuleTarget

2017-01-20 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8172659/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8172659 Thanks, -Sundar