Re: Reusing module name token `*` in -d

2017-01-27 Thread Jonathan Gibbons
Gregg, javac's new behavior for the output directory is only enabled when javac is compiling one or more modules in multi-module mode, which is signified by using the --module-source-path option. In other words, if (and only if) you are compiling many modules together using

Re: Reusing module name token `*` in -d

2017-01-27 Thread Gregg Wonderly
I think this is an important detail to consider as well. If -d’s argument will now have an implied subdirectory before the class hierarchy, simple Java applications/deployment tools will break, unless the JVM knows exactly what to do about this. However, think about the case where I am

Re: Reusing module name token `*` in -d

2017-01-27 Thread Jonathan Gibbons
Peter, I concede that a hypothetical new --module-output option might address the problem, but I'm still not convinced there is a problem that needs to be addressed. The use case appears to be a desire to compile together a set of of loosely related projects, each with their own source

Re: Reusing module name token `*` in -d

2017-01-27 Thread Nicolai Parlog
Hi Peter, thanks for your thoughts. An option --module-output would of course solve the same problem and I have on issue with it - on the contrary, it sounds great. > You now want to extend the meaning of asterisk to -d option, which > implies that the output directory containing package

hg: jigsaw/jake/hotspot: 8171115: Tests containing module names ending in digits need to change

2017-01-27 Thread harold . seigel
Changeset: e3212cca805b Author:gtriantafill Date: 2017-01-27 10:18 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e3212cca805b 8171115: Tests containing module names ending in digits need to change Reviewed-by: alanb, hseigel !

Re: Reusing module name token `*` in -d

2017-01-27 Thread Peter Levart
Hi, On 01/27/2017 03:27 PM, Nicolai Parlog wrote: Being able to compile a bunch of modules together, and put the resulting single output directory on the module path would seem to be more convenient and thus more desirable. You make it sound like it's "either or" but that would not be the

Re: Automatic module names

2017-01-27 Thread Nicolai Parlog
Hi! This obviously echoes the concerns Robert Scholte and Brian Fox recently voiced and by and large I agree. For the automatic module feature to work reliably across the ecosystem, we must face the fact that different libraries or frameworks will pick different names for automatic modules and

Re: Reusing module name token `*` in -d

2017-01-27 Thread Nicolai Parlog
> Being able to compile a bunch of modules together, and put the > resulting single output directory on the module path would seem to > be more convenient and thus more desirable. You make it sound like it's "either or" but that would not be the case. It would be "either you use the asterisk" or

Automatic module names

2017-01-27 Thread Stephen Colebourne
Back in October, I raised the issue of modules names generally and for automatic modules specifically [1]. The short thread came to no conclusion, but recent threads have again raised similar problems. The problem is that automatic modules have magical name creation from a filename, which is

Re: RFR 8172864: Remove custom plugin module path

2017-01-27 Thread Jim Laskey (Oracle)
+1 > On Jan 27, 2017, at 2:45 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8172864/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8172864 > > Thanks, > -Sundar

hg: jigsaw/jake/langtools: 26 new changesets

2017-01-27 Thread alan . bateman
Changeset: 444b89786af3 Author:darcy Date: 2017-01-17 09:40 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/444b89786af3 8172686: Use less aggressive deprecation of utility visitors Reviewed-by: jjg, smarks !

hg: jigsaw/jake/jaxp: 4 new changesets

2017-01-27 Thread alan . bateman
Changeset: 7f5f8b336432 Author:mullan Date: 2017-01-19 13:48 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/7f5f8b336432 8055206: Update SecurityManager::checkPackageAccess to restrict non-exported JDK packages by default Reviewed-by: mchung !

hg: jigsaw/jake/jdk: 70 new changesets

2017-01-27 Thread alan . bateman
Changeset: 051e7d9159a7 Author:naoto Date: 2017-01-17 11:34 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/051e7d9159a7 8171139: Simplify ResourceBundle.CacheKey and ClassLoader may not be needed Reviewed-by: dfuchs Contributed-by: peter.lev...@gmail.com !

hg: jigsaw/jake/hotspot: 6 new changesets

2017-01-27 Thread alan . bateman
Changeset: 2c3fafbc70b8 Author:rprotacio Date: 2016-07-21 15:49 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/2c3fafbc70b8 8159507: RuntimeVisibleAnnotation validation Reviewed-by: coleenp, hseigel, mschoene, acorn Contributed-by: rachel.prota...@oracle.com !

hg: jigsaw/jake/jaxws: 2 new changesets

2017-01-27 Thread alan . bateman
Changeset: 9b9918656c97 Author:lana Date: 2017-01-26 19:22 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/9b9918656c97 Added tag jdk-9+154 for changeset 34af95c7dbff ! .hgtags Changeset: 0d2ba35ade5b Author:alanb Date: 2017-01-27 08:34 + URL:

hg: jigsaw/jake/corba: 4 new changesets

2017-01-27 Thread alan . bateman
Changeset: 64e3c222a4c6 Author:vinnie Date: 2016-10-06 17:33 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/64e3c222a4c6 8158997: JNDI Protocols Switch Reviewed-by: dfuchs ! src/java.corba/share/classes/com/sun/jndi/cosnaming/CNBindingEnumeration.java !

hg: jigsaw/jake: 9 new changesets

2017-01-27 Thread alan . bateman
Changeset: 33f8f04ab876 Author:ihse Date: 2017-01-17 14:14 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/33f8f04ab876 8170863: Always pass MAKE_ARGS to MAKE in Main.gmk Reviewed-by: erikj ! make/Main.gmk Changeset: ec276ecde338 Author:chegar Date: 2017-01-18

hg: jigsaw/jake/nashorn: 2 new changesets

2017-01-27 Thread alan . bateman
Changeset: 336a75b38fd0 Author:lana Date: 2017-01-26 19:22 + URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/336a75b38fd0 Added tag jdk-9+154 for changeset a84b49cfee63 ! .hgtags Changeset: 4d7d3dc2065c Author:alanb Date: 2017-01-27 08:34 + URL:

Re: RFR 8172864: Remove custom plugin module path

2017-01-27 Thread Alan Bateman
On 27/01/2017 06:45, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8172864/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8172864 Looks okay to me but less changes than I assumed would be needed. -Alan