Re: Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-28 Thread Mandy Chung
Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173381/webrev.02 > On Jan 28, 2017, at 10:01 AM, Alan Bateman wrote: > > On 27/01/2017 06:21, Mandy Chung wrote: > >> : >> Updated webrev: >>

Re: Applications for --limit-modules?

2017-01-28 Thread Alan Bateman
On 28/01/2017 18:39, Nicolai Parlog wrote: Hi Alan, thanks for your reply. Yes testing is a good example, didn't have that idea. So testing and services, then? Yes, and for service providers then you might specify one or two to --limit-modules when converging on the set of service provide

Re: Applications for --limit-modules?

2017-01-28 Thread Nicolai Parlog
Hi Alan, thanks for your reply. Yes testing is a good example, didn't have that idea. So testing and services, then? > I guess this could be expanded a bit but it might be too much to > attempt to include text on how it interacts with other options. Yes, interaction would be too much but I

Re: Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

2017-01-28 Thread Alan Bateman
On 27/01/2017 06:21, Mandy Chung wrote: : Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173381/webrev.01/ This mostly looks good. I think it would cleaner if the plugin used rewriter.targetPlatform("", "", "") rather than adding filtering to the extender. For the

Applications for --limit-modules?

2017-01-28 Thread Nicolai Parlog
Hi! I'm experimenting with --limit-modules and am not quite sure what exactly it is good for. But before I come to that I want to make sure I got it right, because I had to figure this out by trial and error (the current output of java -? is not that helpful) I came to the conclusion that only