Review Request JDK-8182032: Make java.compiler upgradeable

2017-06-12 Thread Mandy Chung
Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182032/webrev.00/ java.compiler is a standalone technology that allows to be running on older JDK, in particular for IDE to support new language features. This patch takes out the make logic to find the modules that directly and ind

Re: Annotation-based syntax for module-info.java

2017-06-12 Thread Stephan Herrmann
We don't need more proposals how to solve the problem. We need agreement that we have a problem! Stephan On 12.06.2017 23:31, Ralph Goers wrote: I had this same thought a week or so ago and I wouldn’t be surprised to see someone create a framework that generates a module-info.java from annotat

Re: Annotation-based syntax for module-info.java

2017-06-12 Thread Ralph Goers
I had this same thought a week or so ago and I wouldn’t be surprised to see someone create a framework that generates a module-info.java from annotations. But that doesn’t solve the issues I have hit, which all stem from module-info.class conflicting with pre-java 9 tools. Frankly, I don’t know

hg: jigsaw/jake/langtools: 8181925: Confusing error when unnamed module reads multiple modules exporting the same package.

2017-06-12 Thread jan . lahoda
Changeset: 31edb164e288 Author:jlahoda Date: 2017-06-12 22:30 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/31edb164e288 8181925: Confusing error when unnamed module reads multiple modules exporting the same package. Summary: Adding special wording for package cla

hg: jigsaw/jake/jdk: Move locating/ordering sections from SL spec to SL.load methods

2017-06-12 Thread alan . bateman
Changeset: 01a5ea9fa211 Author:alanb Date: 2017-06-12 19:30 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/01a5ea9fa211 Move locating/ordering sections from SL spec to SL.load methods ! src/java.base/share/classes/java/util/ServiceLoader.java

Re: Annotation-based syntax for module-info.java

2017-06-12 Thread Remi Forax
Hi Markus, - Mail original - > De: "Markus Keller" > À: jigsaw-dev@openjdk.java.net > Cc: "Daniel Megert" > Envoyé: Lundi 12 Juin 2017 15:26:10 > Objet: Annotation-based syntax for module-info.java > [I know this is coming way too late, and my recent accident that > incapacitated me for

Re: Annotation-based syntax for module-info.java

2017-06-12 Thread mark . reinhold
2017/6/12 6:26:10 -0700, markus_kel...@ch.ibm.com: > [I know this is coming way too late, and my recent accident that > incapacitated me for several week didn't help either. Nevertheless, I > think the current module-info.java syntax was a snap decision that should > not end up in the Java 9 spe

Annotation-based syntax for module-info.java

2017-06-12 Thread Markus Keller
[I know this is coming way too late, and my recent accident that incapacitated me for several week didn't help either. Nevertheless, I think the current module-info.java syntax was a snap decision that should not end up in the Java 9 spec.] The discussions about restricted keywords http://openj

hg: jigsaw/jake/jdk: Cleanup of CL spec, move text for default implementation to @implSpec

2017-06-12 Thread alan . bateman
Changeset: 741bd322be3e Author:alanb Date: 2017-06-12 12:01 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/741bd322be3e Cleanup of CL spec, move text for default implementation to @implSpec ! src/java.base/share/classes/java/lang/ClassLoader.java

Re: Why is -XD-Xmodule hidden?

2017-06-12 Thread Alan Bateman
On 11/06/2017 16:26, Jonathan Gibbons wrote: There are some tests which still need to be changed to use --patch-module. Once all uses of -Xmodule have been removed from tests, we will remove the (hidden/undocumented) option. I thought this was done already but I see now that there are small