On 2017-12-08 04:27, Sundararajan Athijegannathan wrote:
* Fixed to avoid second resolve for "module-info.class" in JlinkTask.java
Please review updated webrev:
http://cr.openjdk.java.net/~sundar/8192986/webrev.02/
+1
/Claes
Hi,
* On stricter check for missing module-info.class in a directory: There
is a similar check for non-modular jars.
jlink --add-modules java.base --module-path t.jar --output foo
Error: Unable to derive module descriptor for t.jar
t.jar in the above command is a non-modular jar. I think it
Hi Claes,
> this seems like a very reasonable improvement. I can help sponsor it.
Thanks a lot!
> What I think is really needed in this area is some microbenchmarks that sets
> up
> multiple and more complex (but somewhat realistic) Layers of modules and test
> various
> queries, so that we ca
Hi Adam,
java.management should not require java.logging. PlatformLoggingMXBean
is registered to the platform MBeanServer only if java.logging is
present in the runtime. This is detected dynamically [1]. I would
recommend to replace the static dependencies to java.util.logging using
similar
On 12/7/17 6:56 AM, Alan Bateman wrote:
On 06/12/2017 17:17, mandy chung wrote:
or it can print "java.base includes " + mods?
I've adjusted the exception text so that it reads:
"The requires entry for java.base has ACC_TRANSITIVE set"
and updated the webrev in place. If you agree then I
Can you send some example module-info.java & .extra files and source
location that shows what functionality you depend on?
Mandy
On 12/7/17 4:20 AM, Adam Farley8 wrote:
Update: OpenJ9 appears to need this functionality.
Best Regards
Adam Farley
From: Adam Farley8/UK/IBM
To: mandy chung
C
Hi,
Comments below...
On 07/12/17, 8:54 PM, Claes Redestad wrote:
Hi Sundar,
thanks for picking this up so quick!
On 2017-12-07 16:21, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8192986/webrev.01/
Looks ok, butunless my understanding is flawed it seems
Hi Sundar,
thanks for picking this up so quick!
On 2017-12-07 16:21, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8192986/webrev.01/
Looks ok, butunless my understanding is flawed it seems the logic is now
getting more strict about a directory on the module
Updated: http://cr.openjdk.java.net/~sundar/8192986/webrev.01/
PS. Bug description line was wrong in the test .java file.
-Sundar
On 07/12/17, 8:40 PM, Sundararajan Athijegannathan wrote:
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8192986
Webrev: http://cr.openjdk.java.net/~
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8192986
Webrev: http://cr.openjdk.java.net/~sundar/8192986/webrev.00/
Thanks,
-Sundar
On 06/12/2017 17:17, mandy chung wrote:
or it can print "java.base includes " + mods?
I've adjusted the exception text so that it reads:
"The requires entry for java.base has ACC_TRANSITIVE set"
and updated the webrev in place. If you agree then I'll get this into
jdk/jdk10 to meet up wit
On 07/12/2017 10:00, Andrej Golovnin wrote:
Hi all,
when we try to find a module which is not in the current layer, then
we access the map 'nameToModule' in the parent layers two times in the
lines 849-850:
The change looks okay (I'm pretty sure it was just an oversight as this
code changed se
Hi Andrej,
this seems like a very reasonable improvement. I can help sponsor it.
What I think is really needed in this area is some microbenchmarks that
sets up
multiple and more complex (but somewhat realistic) Layers of modules and
test various
queries, so that we can profile and get a tab o
Hi all,
when we try to find a module which is not in the current layer, then
we access the map 'nameToModule' in the parent layers two times in the
lines 849-850:
846return layers()
847 .skip(1) // skip this layer
848 .map(l -> l.nameToModule)
849
Hi Mandy,
it looks good. Thanks!
@Claes when you would like to improve the performance of jlink a
little bit more, then take look at the method #entryToFileName in the
class DefaultImageBuilder lines 358-359:
String module = "/" + entry.moduleName() + "/";
String filename = entry
On 06/12/2017 22:55, Scott Stark wrote:
Is there a definitive list of modules that go into bootstrap class loader?
If not, is there a way to derive this?
Just looking at the ModuleLayer.boot().modules() output does not provide
this as I see modules like java.sql in this set that contains packag
16 matches
Mail list logo
