RE: RFR: 8242039: Improve jlink VersionPropsPlugin

2020-04-03 Thread Langer, Christoph
Hi Mark, > -Original Message- > From: mark.reinh...@oracle.com > Sent: Donnerstag, 2. April 2020 23:13 > To: Langer, Christoph > Cc: jigsaw-dev@openjdk.java.net; core-libs-...@openjdk.java.net > Subject: Re: RFR: 8242039: Improve jlink VersionPropsPlugin > > 2020/4/2 8:01:28 -0700, chri

RE: RFR: 8242039: Improve jlink VersionPropsPlugin

2020-04-03 Thread Langer, Christoph
Thanks, Claes. > -Original Message- > From: Claes Redestad > Sent: Donnerstag, 2. April 2020 23:05 > To: Langer, Christoph ; jigsaw- > d...@openjdk.java.net; core-libs-...@openjdk.java.net > Subject: Re: RFR: 8242039: Improve jlink VersionPropsPlugin > > > > On 2020-04-02 20:21, Langer

Re: missing resources when using --patch-module

2020-04-03 Thread Alan Bateman
On 03/04/2020 12:46, Tom De Wolf wrote: Hi, I understand that for individual classes and non-java resources a patch should replace them. However for directories which are actually java packages this seems to be odd. Does this not make it impossible to add a new class to an existing package or

Re: missing resources when using --patch-module

2020-04-03 Thread Tom De Wolf
Hi, I understand that for individual classes and non-java resources a patch should replace them. However for directories which are actually java packages this seems to be odd. Does this not make it impossible to add a new class to an existing package or replace only 1 class in a package but keep t

Re: missing resources when using --patch-module

2020-04-03 Thread Robert Scholte
Thanks for the explanation, it makes sense: Patch acts more like an override than an append. best, Robert On 3-4-2020 12:56:10, Alan Bateman wrote: On 03/04/2020 10:17, Robert Scholte wrote: > This issue was registered as SUREFIRE-1768[1] > It contains a very small Maven project to demonstrate t

Re: missing resources when using --patch-module

2020-04-03 Thread Alan Bateman
On 03/04/2020 10:17, Robert Scholte wrote: This issue was registered as SUREFIRE-1768[1] It contains a very small Maven project to demonstrate the issue. That project contains one method executing the following: Demo.class.getClassLoader().getResources("demo").asIterator().forEachRemaining(url

Re: missing resources when using --patch-module

2020-04-03 Thread Simone Bordet
Hi, On Fri, Apr 3, 2020 at 11:18 AM Robert Scholte wrote: > > This issue was registered as SUREFIRE-1768[1] > It contains a very small Maven project to demonstrate the issue. > > That project contains one method executing the following: > > Demo.class.getClassLoader().getResources("demo").asItera

missing resources when using --patch-module

2020-04-03 Thread Robert Scholte
This issue was registered as SUREFIRE-1768[1] It contains a very small Maven project to demonstrate the issue. That project contains one method executing the following: Demo.class.getClassLoader().getResources("demo").asIterator().forEachRemaining(url -> {   System.out.println(url.getFile()); //