Re: RFR (XS) 8241462: StripNativeDebugSymbols jlink plugin allocates huge arrays

2020-03-24 Thread Aleksey Shipilev
On 3/24/20 6:40 PM, Severin Gehwolf wrote: > On Tue, 2020-03-24 at 12:03 +0100, Aleksey Shipilev wrote: >> On 3/23/20 9:35 PM, Alan Bateman wrote: >>> On 23/03/2020 19:22, Aleksey Shipilev wrote: >>>> +import java.io.InputStream; >>>>

Re: RFR (XS) 8241462: StripNativeDebugSymbols jlink plugin allocates huge arrays

2020-03-24 Thread Aleksey Shipilev
On 3/23/20 9:35 PM, Alan Bateman wrote: > On 23/03/2020 19:22, Aleksey Shipilev wrote: >> +import java.io.InputStream; >> import java.io.IOException; >> import java.lang.ProcessBuilder.Redirect; >> @@ -314,5 +315,8 @@ >> String relat

RFR (XS) 8241462: StripNativeDebugSymbols jlink plugin allocates huge arrays

2020-03-23 Thread Aleksey Shipilev
RFE: https://bugs.openjdk.java.net/browse/JDK-8241462 In some of my testing pipelines that deal with huge .so-s due to specific build configuration, tests that use the StripNativeDebugSymbols plugin fail with OOME. It can be fixed by using the method that copies the InputStream straight to des

Re: EXCEPTION_ACCESS_VIOLATION on a jlinked 11.0.3+7 32bits

2019-07-18 Thread Aleksey Shipilev
On 7/18/19 11:19 AM, Andrea Vacondio wrote: > These are the args we use: > --add-modules > java.base,java.datatransfer,java.logging,java.naming,java.sql,java.desktop,java.xml,java.scripting,jdk.unsupported,java.prefs > --compress 2 --no-man-pages --no-header-files --strip-debug > > Tested with jd

Re: EXCEPTION_ACCESS_VIOLATION on a jlinked 11.0.3+7 32bits

2019-07-17 Thread Aleksey Shipilev
On 7/17/19 2:37 PM, Andrea Vacondio wrote: > On a Windows 10 32 bits I have a script that does a jlink on the 32bits jdk > 11.0.3+7. When running 'java' on the resulting runtime I get a > EXCEPTION_ACCESS_VIOLATION (attached to the issue in GitHub there is the > error log). This doesn't happen if I

Re: MethodHandle performance

2017-01-12 Thread Aleksey Shipilev
On 01/12/2017 03:23 PM, Stephen Colebourne wrote: > The real problem however is performance. In my tests, I am seeing a > MethodHandle approach being 2 to 3 times slower than a reflection > approach for identical functionality, which is quite a significant > degradation. (using Java 8 b122) Method

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

2016-06-08 Thread Aleksey Shipilev
On 06/08/2016 09:28 AM, Alan Bateman wrote: > On 07/06/2016 18:25, Aleksey Shipilev wrote: > >> All right, I will fix the issue that *actually* bites me in the bottom >> all the time: MH.publicLookup() init circularity. Here's a webrev >> without an inline blob: >

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

2016-06-07 Thread Aleksey Shipilev
defineClass from a direct > memory mapped buffer) vs assembling and assigning a byte array. Measure > first? > > >> On Jun 7, 2016, at 12:44 PM, Aleksey Shipilev >> wrote: >> >> On 06/07/2016 06:09 PM, Jim Laskey (Oracle) wrote: >>> Generally I disagree

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

2016-06-07 Thread Aleksey Shipilev
stay: Alan said that part of mechanics is up to a reimplementation? Thanks, -Aleksey >> On Jun 7, 2016, at 11:56 AM, Aleksey Shipilev >> wrote: >> >> On 06/07/2016 04:51 PM, Alan Bateman wrote: >>> On 07/06/2016 14:38, Aleksey Shipilev wrote: >>>> Please

Re: RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

2016-06-07 Thread Aleksey Shipilev
On 06/07/2016 04:51 PM, Alan Bateman wrote: > On 07/06/2016 14:38, Aleksey Shipilev wrote: >> Please review a fix for a MH.publicLookup() circularity, which is >> triggered if you run existing String concat tests with -limitmods >> java.base: >>https://bugs.openjdk.

RFR (S) 8158851: MH.publicLookup() init circularity, triggered by custom SecurityManager with String concat and -limitmods java.base

2016-06-07 Thread Aleksey Shipilev
Hi, Please review a fix for a MH.publicLookup() circularity, which is triggered if you run existing String concat tests with -limitmods java.base: https://bugs.openjdk.java.net/browse/JDK-8158851 Webrev: http://cr.openjdk.java.net/~shade/8158851/webrev.01/ Testing: java/lang/ jtreg tests. A

Re: Weird use case: compiling against dummy sun.misc.* class

2016-05-20 Thread Aleksey Shipilev
On 05/20/2016 07:13 PM, Alan Bateman wrote: > On 20/05/2016 16:55, Aleksey Shipilev wrote: > jcstress is boot loader so I assume multi-release JARs are out of the > question? Yes, a simple workaround would be better than doing MR JARs at this point. We have >50 Mb JARs as it is, MR J

Weird use case: compiling against dummy sun.misc.* class

2016-05-20 Thread Aleksey Shipilev
Hi, I have a weird use case in jcstress around @Contended. In order to support both JDK 8 and JDK 9 we build against *our own* sun.misc.Contended and jdk.internal.annotations.Contended. This works arguably well for both compiling and running with both JDK 8 and JDK 9: the real annotation gets pic

Re: Having problem building jdk9-dev

2016-05-11 Thread Aleksey Shipilev
On 05/11/2016 02:28 PM, Alan Bateman wrote: > On 11/05/2016 12:14, Aleksey Shipilev wrote: >> Got the same today, and figured it only fails with JDK 9 as the boot >> JDK. Builds fine with JDK 8 as boot JDK. Filed: >>https://bugs.openjdk.java.net/browse/JDK-8156740 >>

Re: Having problem building jdk9-dev

2016-05-11 Thread Aleksey Shipilev
Got the same today, and figured it only fails with JDK 9 as the boot JDK. Builds fine with JDK 8 as boot JDK. Filed: https://bugs.openjdk.java.net/browse/JDK-8156740 Thanks, -Aleksey On 05/09/2016 05:07 PM, Jim Laskey (Oracle) wrote: > Mac OS X - reproducible with a clean repo. > > >> On May

Re: Accessing Attach API?

2016-04-13 Thread Aleksey Shipilev
On 04/13/2016 12:08 PM, Aleksey Shipilev wrote: > OpenJDK JOL is using Attach API to get the access to Instrumentation > instance without forcing user to -javaagent: the JAR. I think ByteBuddy > is using similar mechanism. > > How is one supposed to use Attach API these p

Accessing Attach API?

2016-04-13 Thread Aleksey Shipilev
Hi, OpenJDK JOL is using Attach API to get the access to Instrumentation instance without forcing user to -javaagent: the JAR. I think ByteBuddy is using similar mechanism. How is one supposed to use Attach API these post-Jigsaw days? Before JDK 9, we could poll VirtualMachine from tools.jar, an