Re: Should ClassLoader::getResouces return the same resource twice?

As an aside, creating a FileSystem is not an onerous task. https://stackoverflow.com/questions/22966176/creating-a-custom-filesystem-implementation-in-java Cheers, — Jim  > On Jan 2, 2021, at 8:59 AM, Thiago Henrique Hupner wrote: > > I guess a little context can make more things clear:

Re: RFR 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js

+1  > On May 28, 2020, at 3:16 AM, sundararajan.athijegannat...@oracle.com wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8246034 > > Webrev: http://cr.openjdk.java.net/~sundar/8246034/webrev.00/ > > Thanks > > -Sundar >

Re: RFR 8222100: tools/jimage/JImageTest.java time out

+1 On the road. > On Jan 13, 2020, at 10:25 AM, sundararajan.athijegannat...@oracle.com wrote: > > Bumping the default timeout (other tests in the same dir have similar > timeout settings). > > Bug: https://bugs.openjdk.java.net/browse/JDK-8222100 > > Webrev:

Re: Nashorn on the module-path

Christian, I can’t see the rest of the thread so I don’t have a context. Sent from my iPhone On May 26, 2019, at 6:17 AM, Christian Stein wrote: >> Have you brought this up on nashorn-dev... > > No, but cc-ed that list now. > >> ...as this might require digging into the dynalink linker >>

Re: RFR(S): 8219142: Make libjimage strncpy uses GCC 8.x friendly

st be removed instead? Or is > JIMAGE_ResourcePath considered exported? Can (non-JDK) native code expect to > find and use it? > > Cheers, > Mikael > >> On Feb 15, 2019, at 1:58 PM, James Laskey wrote: >> >> I wonder if you should flag overflow so no attempt is

Re: RFR(S): 8219142: Make libjimage strncpy uses GCC 8.x friendly

I wonder if you should flag overflow so no attempt is made to search with a bogus path. It’s not necessary but prevent future misunderstandings. Sent from my iPhone > On Feb 15, 2019, at 5:24 PM, Mikael Vidstedt > wrote: > > > Please review this change which addresses some warnings

Re: RFR 8212137: Remove JrtFileSystem finalize method

+1 Sent from my iPhone > On Dec 7, 2018, at 4:47 AM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8212137 > Webrev: https://cr.openjdk.java.net/~sundar/8212137/webrev.00/ > > Thanks, > -Sundar

Re: RFR: 8202810: Remove class-for-name test

+1 Sent from my iPhone > On May 8, 2018, at 5:45 PM, Claes Redestad wrote: > > Hi, > > please review the removal of this test that explicitly attempts to run the > now removed jlink --class-for-name plugin: > > diff -r 7f05a1e6a02a

Re: RFR: JDK-8158407 - jimage: verify should do more extensive test

I had frame verification code. Since removed (required class loading). Will fix. Sent from my iPhone > On Jul 20, 2016, at 3:15 PM, Alan Bateman wrote: > > > >> On 20/07/2016 18:19, Jim Laskey (Oracle) wrote: >>

Re: RFR: JDK-8161067 - jlink: Enable plugins to use the module pool for class lookup

Sent from my iPhone > On Jul 11, 2016, at 11:09 AM, Paul Sandoz wrote: > > >> On 11 Jul 2016, at 14:17, Jim Laskey (Oracle) >> wrote: >> >> I’m not sure if we can determine supplied classes vs others unless we >> provide a flag or the set

Re: Having problem building jdk9-dev

Wonder if we should have a configuration warning when an inappropriate version is used. Sent from my iPhone > On May 11, 2016, at 8:35 AM, Aleksey Shipilev > wrote: > >> On 05/11/2016 02:28 PM, Alan Bateman wrote: >>> On 11/05/2016 12:14, Aleksey Shipilev wrote:

Fwd: RFR: JDK-8151806 - JImage decompress code needs to be revised to be more effective

Sent from my iPhone Begin forwarded message: > From: "Jim Laskey (Oracle)" > Date: April 1, 2016 at 4:15:50 PM ADT > To: jdk9-dev > Subject: RFR: JDK-8151806 - JImage decompress code needs to be revised to be > more effective > >

hg: jigsaw/jake/jdk: M3 jdk8-dev review changes.

Changeset: 3067409f5ab9 Author:jlaskey Date: 2016-03-14 16:53 -0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3067409f5ab9 M3 jdk8-dev review changes. ! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java !

hg: jigsaw/jake/hotspot: 8146560: Rename modules/bootmodules.jimage to modules

Changeset: 782d00823652 Author:jlaskey Date: 2016-01-29 10:35 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/782d00823652 8146560: Rename modules/bootmodules.jimage to modules Reviewed-by: alanb ! src/share/vm/classfile/classFileParser.cpp !

hg: jigsaw/jake/langtools: 8146560: Rename modules/bootmodules.jimage to modules

Changeset: d760db7daa2a Author:jlaskey Date: 2016-01-29 10:35 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d760db7daa2a 8146560: Rename modules/bootmodules.jimage to modules Reviewed-by: alanb !

hg: jigsaw/jake/jdk: 8146560: Rename modules/bootmodules.jimage to modules

Changeset: 884ea77a8508 Author:jlaskey Date: 2016-01-29 10:35 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/884ea77a8508 8146560: Rename modules/bootmodules.jimage to modules Reviewed-by: alanb ! src/java.base/share/classes/java/lang/module/ModuleFinder.java !

hg: jigsaw/jake/jdk: Remove use of RandomAccessFile from jimage.

Changeset: f50598618cbd Author:jlaskey Date: 2016-01-07 13:09 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f50598618cbd Remove use of RandomAccessFile from jimage. ! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java !

hg: jigsaw/jake/jdk: Reenable java/nio/Buffer/LimitDirectMemory.sh test

Changeset: e8ac40b87434 Author:jlaskey Date: 2016-01-06 12:47 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e8ac40b87434 Reenable java/nio/Buffer/LimitDirectMemory.sh test ! test/ProblemList.jake.txt

hg: jigsaw/jake/jdk: 8146243: jimage usage of direct buffers eats into MaxDirectMemorySize

Changeset: 111b11842e71 Author:jlaskey Date: 2016-01-06 12:33 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/111b11842e71 8146243: jimage usage of direct buffers eats into MaxDirectMemorySize ! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java !

hg: jigsaw/jake/jdk: Fix build break

Changeset: f3ff987e1b91 Author:jlaskey Date: 2016-01-06 15:20 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f3ff987e1b91 Fix build break ! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java

hg: jigsaw/jake/jdk: Backed out changeset 0d09d76b56d5 missing file moves

Changeset: 756fc7006809 Author:jlaskey Date: 2015-09-18 10:33 -0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/756fc7006809 Backed out changeset 0d09d76b56d5 missing file moves + src/java.base/share/classes/jdk/internal/jimage/Archive.java +

hg: jigsaw/jake/jdk: find bugs review

Changeset: 74be7c7a8257 Author:jfdenise Date: 2015-09-18 13:11 -0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/74be7c7a8257 find bugs review ! src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressIndexes.java !

hg: jigsaw/jake/jdk: Remove last uses of jdata

Changeset: 2f4b40659bd1 Author:jfdenise Date: 2015-09-18 12:17 -0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2f4b40659bd1 Remove last uses of jdata - src/java.base/share/classes/jdk/internal/jimage/ExternalFilesWriter.java !

Re: CFV: New jigsaw Committer: Jean-Francois Denise

Vote: yes Sent from my iPhone > On Sep 13, 2015, at 11:33 AM, Alan Bateman wrote: > > > I hereby nominate Jean-Francois Denise to jigsaw Committer. > > Jean-Francois is a jdk9 Committer and has been contributing to the ongoing > development of the jimage container

hg: jigsaw/m2/hotspot: JDK-8062812 BasicImageReader.getResource fails with NPE when no modules in appmodules.jimage

Changeset: b044703883d2 Author:jlaskey Date: 2014-11-17 18:47 -0400 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/b044703883d2 JDK-8062812 BasicImageReader.getResource fails with NPE when no modules in appmodules.jimage ! src/share/vm/classfile/classLoader.cpp !

hg: jigsaw/m2/jdk: JDK-8062812 BasicImageReader.getResource fails with NPE when no modules in appmodules.jimage

Changeset: da0b366ca4fb Author:jlaskey Date: 2014-11-17 18:48 -0400 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/da0b366ca4fb JDK-8062812 BasicImageReader.getResource fails with NPE when no modules in appmodules.jimage !

hg: jigsaw/m2/hotspot: Clean up to follow hotspot coding quidelines

Changeset: 47de10c47b48 Author:jlaskey Date: 2014-11-13 10:24 -0400 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/47de10c47b48 Clean up to follow hotspot coding quidelines ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/imageFile.cpp !

hg: jigsaw/m2/jdk: JDK-8061825 - jimage expand jimage create doesn't create usable jimage

Changeset: 5a241599213d Author:jlaskey Date: 2014-11-13 12:15 -0400 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/5a241599213d JDK-8061825 - jimage expand jimage create doesn't create usable jimage ! src/demo/share/applets/GraphicsTest/AppletFrame.java !

hg: jigsaw/m2/jdk: When cloning ByteBuffers in jimage, endian was not copied.

Changeset: dea510f71a0a Author:jlaskey Date: 2014-11-13 12:35 -0400 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/dea510f71a0a When cloning ByteBuffers in jimage, endian was not copied. ! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java