Re: Impossibility for invoking Module::addReads(Module)

2016-06-02 Thread Andrew Dinn
On 02/06/16 14:32, Alan Bateman wrote: > On 02/06/2016 13:53, Andrew Dinn wrote: >> #2 is no good for Java agents which want to (re)transform an already >> loaded class. That's not just an issue for dynamically loaded agents. >> Even when the agent is loaded on the command line it may need to modif

Re: Impossibility for invoking Module::addReads(Module)

2016-06-02 Thread Alan Bateman
On 02/06/2016 13:53, Andrew Dinn wrote: : Your #2 is good to explore. As I've mentioned in several other threads, this is a possible way forward for some of the scenarios that have come up in other threads. it may be that we have to improve support for injecting new classes into existing modul

Re: Impossibility for invoking Module::addReads(Module)

2016-06-02 Thread Andrew Dinn
On 02/06/16 13:29, Alan Bateman wrote: As Alan said you can use the addReads API on class Instrumentation to deal with the issue of installinread dependencies. > Your #2 is good to explore. As I've mentioned in several other threads, > this is a possible way forward for some of the scenarios that

Re: Impossibility for invoking Module::addReads(Module)

2016-06-02 Thread Alan Bateman
On 02/06/2016 13:05, Rafael Winterhalter wrote: When instrumenting code, typically one adds calls of foreign methods to the instrumented class. For example, a Java agent might want to inject additional logging by adding log calls to code of the instrumented class. Wth Jigsaw, these log classes m

Impossibility for invoking Module::addReads(Module)

2016-06-02 Thread Rafael Winterhalter
When instrumenting code, typically one adds calls of foreign methods to the instrumented class. For example, a Java agent might want to inject additional logging by adding log calls to code of the instrumented class. Wth Jigsaw, these log classes must also be read by the instrumented code's module.