Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Alan Bateman
On 16/06/2017 10:08, Sven Reimers wrote: Hi Peter, nice idea. The only drawback is this requires JDK 9 for a build. What I wanted to check is if I can compile the same unchanged source tree with JDK 8 and 9... Since there is not yet a hard requirement for JDK 9 compilation, i.e. this is just

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Peter Levart
Hi Sven, On 06/16/2017 11:08 AM, Sven Reimers wrote: Hi Peter, nice idea. The only drawback is this requires JDK 9 for a build. What I wanted to check is if I can compile the same unchanged source tree with JDK 8 and 9... Another trick that comes to my mind is to dynamically generate a

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Sven Reimers
Hi Peter, nice idea. The only drawback is this requires JDK 9 for a build. What I wanted to check is if I can compile the same unchanged source tree with JDK 8 and 9... Since there is not yet a hard requirement for JDK 9 compilation, i.e. this is just an experiment to figure out things that may

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Peter Levart
Hi Sven, Just an idea... What NetBeans could probably do is to create a special sub-interface of java.lang.instrument.Instrumentation in its bootstrap jar file (the jar passed to class-path) and make that jar file MR jar with two versions of say org.netbeans.core.Instrumentation interfaces

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Alan Bateman
On 16/06/2017 08:40, Jaroslav Tulach wrote: : So can you say what NetBeans is doing? Is this mocking, maybe forwarding/intercepting? See https://netbeans.org/bugzilla/show_bug.cgi?id=237919 If I read this correctly then NBInstrumentation is only interested in the addTransformer methods. If

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Jaroslav Tulach
On pátek 16. června 2017 8:17:51 CEST Sven Reimers wrote: > Hi Alan, > > the code in question I am looking at is in > > o.n.bootstrap/src/org/netbeans/NbInstrumentation.java > > So this looks more like some basic stuff baked deep into NetBeans core... > > cc'Ing Jaroslav Tulach who wrote this

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Sven Reimers
Hi Alan, the code in question I am looking at is in o.n.bootstrap/src/org/netbeans/NbInstrumentation.java So this looks more like some basic stuff baked deep into NetBeans core... cc'Ing Jaroslav Tulach who wrote this - he should have some more details.. else I will try to figure this out.

Re: Incompatible change to java.lang.instrument.Instrumentation

2017-06-16 Thread Alan Bateman
On 16/06/2017 06:54, Sven Reimers wrote: Hi all, as part of the process of the code donation from Oracle to Apache for NetBeans I tried a compilation of the source code using idk 9-ea+173. The compilation fails due to an added method boolean isModifiableModule(Module) in

Incompatible change to java.lang.instrument.Instrumentation

2017-06-15 Thread Sven Reimers
Hi all, as part of the process of the code donation from Oracle to Apache for NetBeans I tried a compilation of the source code using idk 9-ea+173. The compilation fails due to an added method boolean isModifiableModule(Module) in java.lang.instrument.Instrumentation. Should the newly added