Re: Need help implementing Java modules

2017-05-10 Thread Gregg Wonderly
> On May 10, 2017, at 1:58 PM, Alex Buckley wrote: > > On 5/9/2017 5:20 PM, Ralph Goers wrote: >> Log4j already has a robust plugin approach for users to implement >> their own Appenders, Filters, Layouts, and other Log4j components. We >> are not going to modify that as it would severely impact

Re: Need help implementing Java modules

2017-05-10 Thread Alex Buckley
On 5/9/2017 5:20 PM, Ralph Goers wrote: Log4j already has a robust plugin approach for users to implement their own Appenders, Filters, Layouts, and other Log4j components. We are not going to modify that as it would severely impact our users who have already implemented custom components and wha

Re: Need help implementing Java modules

2017-05-10 Thread Alex Buckley
On 5/9/2017 11:50 PM, Remi Forax wrote: On May 10, 2017 2:20:31 AM GMT+02:00, Ralph Goers wrote: With all this in mind, if users create modules will they be required to declare the packages where they have created plugins as “open” to log4j for this to work? It depends if when you call the st

Re: Need help implementing Java modules

2017-05-10 Thread Ralph Goers
> On May 9, 2017, at 11:50 PM, Remi Forax wrote: > > > > On May 10, 2017 2:20:31 AM GMT+02:00, Ralph Goers > wrote: >> >> >> With all this in mind, if users create modules will they be required to >> declare the packages where they have created plugins as “open” to

Re: Need help implementing Java modules

2017-05-09 Thread Remi Forax
On May 10, 2017 2:20:31 AM GMT+02:00, Ralph Goers wrote: > >> On May 9, 2017, at 3:39 PM, Alex Buckley >wrote: >> >> On 5/9/2017 3:04 PM, Ralph Goers wrote: >>> Pardon me for being dense, but my reading said that Java modules >>> disallowed runtime cycles as well as compile time. Once LoggerFi

Re: Need help implementing Java modules

2017-05-09 Thread Ralph Goers
> On May 9, 2017, at 3:39 PM, Alex Buckley wrote: > > On 5/9/2017 3:04 PM, Ralph Goers wrote: >> Pardon me for being dense, but my reading said that Java modules >> disallowed runtime cycles as well as compile time. Once LoggerFinder >> binds with the module that provides that service does that

Re: Need help implementing Java modules

2017-05-09 Thread Alex Buckley
On 5/9/2017 3:04 PM, Ralph Goers wrote: Pardon me for being dense, but my reading said that Java modules disallowed runtime cycles as well as compile time. Once LoggerFinder binds with the module that provides that service does that not create a runtime dependency? I don’t recall seeing anything

Re: Need help implementing Java modules

2017-05-09 Thread Ralph Goers
> On May 9, 2017, at 12:50 PM, Jochen Theodorou wrote: > > On 09.05.2017 20:51, Ralph Goers wrote: > >> We also noticed that System.LoggerFinder [1] now provides a new way >> to integrate an external logging framework with Java. If Log4j >> creates the service provider for that how will that no

Re: Need help implementing Java modules

2017-05-09 Thread Alex Buckley
On 5/9/2017 11:51 AM, Ralph Goers wrote: I am attempting to modularize Log4j and am running into some trouble understanding how this can work. Log4j supports many Appenders, such as the FlumeAppender, KafkaAppender, CassandraAppender, and JPAAppender. I don't know how Log4j is currently discov

Re: Need help implementing Java modules

2017-05-09 Thread Jochen Theodorou
On 09.05.2017 20:51, Ralph Goers wrote: I am attempting to modularize Log4j and am running into some trouble understanding how this can work. Log4j supports many Appenders, such as the FlumeAppender, KafkaAppender, CassandraAppender, and JPAAppender. Each of these use their respective libraries

Need help implementing Java modules

2017-05-09 Thread Ralph Goers
I am attempting to modularize Log4j and am running into some trouble understanding how this can work. Log4j supports many Appenders, such as the FlumeAppender, KafkaAppender, CassandraAppender, and JPAAppender. Each of these use their respective libraries to cause the log events to be delivered