Re: Jigsaw EA feedback for elasticsearch

2015-09-12 Thread Robert Muir
On Sat, Sep 12, 2015 at 8:18 AM, Peter Levart wrote: > > But even then you might have ended up with a Method in a non-public class, > so you were forced to use .setAccessible(true) to invoke it. > That's right, that was the main issue here, we had not yet "forbid" setAccessible / removed suppress

Re: Jigsaw EA feedback for elasticsearch

2015-09-12 Thread Peter Levart
penjdk.java.net Subject: Re: Jigsaw EA feedback for elasticsearch Hi Robert, On 09/11/2015 10:58 PM, Robert Muir wrote: On Fri, Sep 11, 2015 at 6:09 AM, Alan Bateman wrote: I'm not sure that I understand the issue here but just to say that the com.sun.management API is a documented

RE: Jigsaw EA feedback for elasticsearch

2015-09-12 Thread Uwe Schindler
t > Sent: Saturday, September 12, 2015 12:27 PM > To: Robert Muir; Alan Bateman > Cc: jigsaw-dev@openjdk.java.net > Subject: Re: Jigsaw EA feedback for elasticsearch > > Hi Robert, > > On 09/11/2015 10:58 PM, Robert Muir wrote: > > On Fri, Sep 11, 2015 at 6:09 AM, Ala

Re: Jigsaw EA feedback for elasticsearch

2015-09-12 Thread Peter Levart
Hi Robert, On 09/11/2015 10:58 PM, Robert Muir wrote: On Fri, Sep 11, 2015 at 6:09 AM, Alan Bateman wrote: I'm not sure that I understand the issue here but just to say that the com.sun.management API is a documented/supported API and it exported by module jdk.management: $ java -listmods:jdk

Re: Jigsaw EA feedback for elasticsearch

2015-09-11 Thread Robert Muir
I can workaround this issue by changing the code to not call setAccessible (and doing class.forName). I don't know why the existing code does it that way... just another code change, but I think we are fine! On Fri, Sep 11, 2015 at 4:58 PM, Robert Muir wrote: > On Fri, Sep 11, 2015 at 6:09 AM, A

Re: Jigsaw EA feedback for elasticsearch

2015-09-11 Thread Robert Muir
On Fri, Sep 11, 2015 at 6:09 AM, Alan Bateman wrote: > > I'm not sure that I understand the issue here but just to say that the > com.sun.management API is a documented/supported API and it exported by > module jdk.management: > > $ java -listmods:jdk.management > > jdk.management@9.0 > requires

Re: Jigsaw EA feedback for elasticsearch

2015-09-11 Thread Robert Muir
On Fri, Sep 11, 2015 at 6:09 AM, Alan Bateman wrote: > Just so I understand, the Thai break iterator issue was with the jigsaw EA > builds and not the regular JDK 9 builds, right? And it only happened once, > you can't reproduce. This is a bit worrisome. All I can say is that there > are a lot of

Re: Jigsaw EA feedback for elasticsearch

2015-09-11 Thread Alan Bateman
Thanks for the great write-up! A few comments below. On 11/09/2015 06:07, Robert Muir wrote: 2. we have a "jar hell detector" that threw an UnsupportedOperationException, because classloader is no longer a URLClassLoader, so we can't get the list of urls. This caused all tests to fail. I changed