Hi Alan,
> >> Looks okay to me too, except @SuppressWarnings("unused") looks
> strange,
> >> is that an Eclipse compiler warning name?
> > Yes, it comes from Eclipse, probably only used by its compiler. The private
> field EXIT_SYSERR doesn't seem to be used. Alternatively, I could comment it
>
On 19/04/2020 20:08, Langer, Christoph wrote:
Hi Alan,
Looks okay to me too, except @SuppressWarnings("unused") looks strange,
is that an Eclipse compiler warning name?
Yes, it comes from Eclipse, probably only used by its compiler. The private
field EXIT_SYSERR doesn't seem to be used.
Hi Alan,
> Looks okay to me too, except @SuppressWarnings("unused") looks strange,
> is that an Eclipse compiler warning name?
Yes, it comes from Eclipse, probably only used by its compiler. The private
field EXIT_SYSERR doesn't seem to be used. Alternatively, I could comment it
out? Or remove
nntag, 19. April 2020 18:32
> To: Langer, Christoph ; jigsaw-
> d...@openjdk.java.net
> Cc: core-libs-...@openjdk.java.net
> Subject: Re: RFR (T): 8243117: Cleanups in Java code of module jdk.jlink
>
> Looks good to me, Christoph,
>
> JmodTask.java: Not sure what the co
On 19/04/2020 17:31, Claes Redestad wrote:
Looks good to me, Christoph,
JmodTask.java: Not sure what the consensus is about wildcard imports,
but I'm fine with it here.
Looks okay to me too, except @SuppressWarnings("unused") looks strange,
is that an Eclipse compiler warning name?
-Alan
Looks good to me, Christoph,
JmodTask.java: Not sure what the consensus is about wildcard imports,
but I'm fine with it here.
/Claes
On 2020-04-19 17:32, Langer, Christoph wrote:
Hi,
please help review this cleanup patch for the Java code in module jdk.jlink.
It's mostly automatic IDE