Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi Claes, The changes look good. Could you run the RBT hs nightly tests against the Linux-x64 platform before pushing this change? Thanks, Harold On 1/6/2017 9:35 AM, Claes Redestad wrote: Hi Harold, sure, I've updated the patch in-place with this small improvement and submitted a new

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

On 1/9/17 04:16, Claes Redestad wrote: Hi Serguei, On 2017-01-09 09:11, serguei.spit...@oracle.com wrote: Hi Claes, It looks pretty good. thanks, One question on the following fragment:

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi Serguei, On 2017-01-09 09:11, serguei.spit...@oracle.com wrote: Hi Claes, It looks pretty good. thanks, One question on the following fragment: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/src/java.base/share/native/libjava/Module.c.udiff.html + int valid = 1; + for (idx = 0;

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi Claes, It looks pretty good. One question on the following fragment: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/src/java.base/share/native/libjava/Module.c.udiff.html + int valid = 1; + for (idx = 0; idx < num_packages; idx++) { + jstring pkg = (*env)->GetObjectArrayElement(env,

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi Harold, sure, I've updated the patch in-place with this small improvement and submitted a new set of tests. /Claes On 2017-01-06 14:23, harold seigel wrote: Hi Claes, One small nit. In these lines in modules.cpp, the length of package_name at line 305 could be saved in a local and then

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

On 2017-01-06 15:07, Alan Bateman wrote: On 06/01/2017 13:18, Claes Redestad wrote: : Updated jdk webrev in-place: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/ I looked through the latest webrev and it looks quite good. Part of me regrets introducing JNI code of course but this is

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

On 06/01/2017 13:18, Claes Redestad wrote: : Updated jdk webrev in-place: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/ I looked through the latest webrev and it looks quite good. Part of me regrets introducing JNI code of course but this is startup motivated. In Module.c then I

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi Peter, On 2017-01-06 09:46, Peter Levart wrote: Hi Claes, On 01/06/2017 03:36 AM, Claes Redestad wrote: New webrevs: http://cr.openjdk.java.net/~redestad/8171855/hotspot.04/ http://cr.openjdk.java.net/~redestad/8171855/jdk.04/ In Module.c, it seems you applied the "techinique" of

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi Claes, On 01/06/2017 03:36 AM, Claes Redestad wrote: New webrevs: http://cr.openjdk.java.net/~redestad/8171855/hotspot.04/ http://cr.openjdk.java.net/~redestad/8171855/jdk.04/ In Module.c, it seems you applied the "techinique" of conditional allocation (lines 49...57), but forgot to

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Lois, Mandy, On 2017-01-05 22:19, Lois Foltan wrote: > > On 1/5/2017 11:47 AM, Claes Redestad wrote: >> Hi, >> >> after a round of review comments I've now reworked this to do the >> transformations in the JNI layer rather than inside the VM, with >> similar - if not better - results. >> >>

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

> On Jan 5, 2017, at 8:47 AM, Claes Redestad wrote: > > Hi, > > after a round of review comments I've now reworked this to do the > transformations in the JNI layer rather than inside the VM, with > similar - if not better - results. > > Webrevs: >

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

On 1/5/2017 11:47 AM, Claes Redestad wrote: Hi, after a round of review comments I've now reworked this to do the transformations in the JNI layer rather than inside the VM, with similar - if not better - results. Webrevs: http://cr.openjdk.java.net/~redestad/8171855/hotspot.03/

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi, after a round of review comments I've now reworked this to do the transformations in the JNI layer rather than inside the VM, with similar - if not better - results. Webrevs: http://cr.openjdk.java.net/~redestad/8171855/hotspot.03/ http://cr.openjdk.java.net/~redestad/8171855/jdk.03/