Re: RFR: 8209003: Consolidate use of empty collections in java.lang.module

2018-08-07 Thread Claes Redestad
Alan, Mandy, thanks for reviewing. Pushed. /Claes On 2018-08-07 21:05, mandy chung wrote: This cleanup looks fine. Mandy

Re: RFR: 8209003: Consolidate use of empty collections in java.lang.module

2018-08-07 Thread mandy chung
This cleanup looks fine. Mandy On 8/7/18 9:16 AM, Claes Redestad wrote: Hi, feel free to review this cleanup to consolidate some uses of Collections.empty/unmodifiableXx.. to Set/Map/List.of()/copyOf(), as appropriate. This aligns better with code already generated by jlink, so avoids obser

Re: RFR: 8209003: Consolidate use of empty collections in java.lang.module

2018-08-07 Thread Alan Bateman
On 07/08/2018 17:16, Claes Redestad wrote: Hi, feel free to review this cleanup to consolidate some uses of Collections.empty/unmodifiableXx.. to Set/Map/List.of()/copyOf(), as appropriate. This aligns better with code already generated by jlink, so avoids observing a mix of many implementati

RFR: 8209003: Consolidate use of empty collections in java.lang.module

2018-08-07 Thread Claes Redestad
Hi, feel free to review this cleanup to consolidate some uses of Collections.empty/unmodifiableXx.. to Set/Map/List.of()/copyOf(), as appropriate. This aligns better with code already generated by jlink, so avoids observing a mix of many implementation classes in some places.. Webrev: http:/