Re: RFR: JDK-8194141: Remove JDK9Wrappers

2018-01-04 Thread Erik Joelsson
Looks good to me. /Erik On 2018-01-03 23:42, Jonathan Gibbons wrote: Updated webrev, reverting unnecessary change to generated-configure.sh http://cr.openjdk.java.net/~jjg/8194141/webrev.01/ -- Jon On 01/03/2018 01:44 PM, Jonathan Gibbons wrote: Please review this code to remove a "temporar

Re: RFR: JDK-8194141: Remove JDK9Wrappers

2018-01-04 Thread Alan Bateman
On 03/01/2018 22:42, Jonathan Gibbons wrote: Updated webrev, reverting unnecessary change to generated-configure.sh http://cr.openjdk.java.net/~jjg/8194141/webrev.01/ This cleanup looks good to me. -Alan

Re: RFR: JDK-8194141: Remove JDK9Wrappers

2018-01-03 Thread Jonathan Gibbons
Updated webrev, reverting unnecessary change to generated-configure.sh http://cr.openjdk.java.net/~jjg/8194141/webrev.01/ -- Jon On 01/03/2018 01:44 PM, Jonathan Gibbons wrote: Please review this code to remove a "temporary" class from javac, to provide reflective access to JDK 9 API, so that

RFR: JDK-8194141: Remove JDK9Wrappers

2018-01-03 Thread Jonathan Gibbons
Please review this code to remove a "temporary" class from javac, to provide reflective access to JDK 9 API, so that javac itself could be built with JDK 8. This temporary class is no longer required, now that the boot JDK for JDK 10 onwards is JDK 9. This is primarily about replacing the use