On 08/06/2016 08:43, Aleksey Shipilev wrote:
:
Where do you want this to go? jdk9/dev or somewhere in jake?
This one is jdk9/dev.
-Alan
On 06/08/2016 09:28 AM, Alan Bateman wrote:
> On 07/06/2016 18:25, Aleksey Shipilev wrote:
>
>> All right, I will fix the issue that *actually* bites me in the bottom
>> all the time: MH.publicLookup() init circularity. Here's a webrev
>> without an inline blob:
>>http://cr.openjdk.java.net/~s
On 07/06/2016 18:25, Aleksey Shipilev wrote:
All right, I will fix the issue that *actually* bites me in the bottom
all the time: MH.publicLookup() init circularity. Here's a webrev
without an inline blob:
http://cr.openjdk.java.net/~shade/8158851/webrev.03/
If you want to improve startup ti
Looks OK to me.
I didn't mean to derail from the core issue solved by this change.
Dealing with the eager load of ASM (if needed) in a follow-up seems
appropriate.
/Claes
On 2016-06-07 19:25, Aleksey Shipilev wrote:
All right, I will fix the issue that *actually* bites me in the bottom
all
All right, I will fix the issue that *actually* bites me in the bottom
all the time: MH.publicLookup() init circularity. Here's a webrev
without an inline blob:
http://cr.openjdk.java.net/~shade/8158851/webrev.03/
If you want to improve startup time along the way, file a separate issue.
(I stil
If it’s in the jimage, I/O should not be an issue (defineClass from a direct
memory mapped buffer) vs assembling and assigning a byte array. Measure first?
> On Jun 7, 2016, at 12:44 PM, Aleksey Shipilev
> wrote:
>
> On 06/07/2016 06:09 PM, Jim Laskey (Oracle) wrote:
>> Generally I disagree
On 06/07/2016 06:09 PM, Jim Laskey (Oracle) wrote:
> Generally I disagree with this kind of hack. It will bite you in the
> @$$ at some point. Why not just have a class file containing the bytes?
What's the difference between a small binary blob in a
filesystem/resource vs a small binary blob inli
Generally I disagree with this kind of hack. It will bite you in the @$$ at
some point. Why not just have a class file containing the bytes?
Otherwise, you should probably embed some of the ASM constants in the array to
handle things like class version? 52 => CLASS_VERSION, et cetera. These wo
On 06/07/2016 04:51 PM, Alan Bateman wrote:
> On 07/06/2016 14:38, Aleksey Shipilev wrote:
>> Please review a fix for a MH.publicLookup() circularity, which is
>> triggered if you run existing String concat tests with -limitmods
>> java.base:
>>https://bugs.openjdk.java.net/browse/JDK-8158851
>
On 2016-06-07 15:51, Alan Bateman wrote:
On 07/06/2016 14:38, Aleksey Shipilev wrote:
Hi,
Please review a fix for a MH.publicLookup() circularity, which is
triggered if you run existing String concat tests with -limitmods
java.base:
https://bugs.openjdk.java.net/browse/JDK-8158851
Webre
On 07/06/2016 14:38, Aleksey Shipilev wrote:
Hi,
Please review a fix for a MH.publicLookup() circularity, which is
triggered if you run existing String concat tests with -limitmods java.base:
https://bugs.openjdk.java.net/browse/JDK-8158851
Webrev:
http://cr.openjdk.java.net/~shade/81588
Hi,
Please review a fix for a MH.publicLookup() circularity, which is
triggered if you run existing String concat tests with -limitmods java.base:
https://bugs.openjdk.java.net/browse/JDK-8158851
Webrev:
http://cr.openjdk.java.net/~shade/8158851/webrev.01/
Testing: java/lang/ jtreg tests.
A
12 matches
Mail list logo
