+1
> On Dec 7, 2017, at 11:27 PM, Sundararajan Athijegannathan
> wrote:
>
> Hi,
>
> * On stricter check for missing module-info.class in a directory: There is a
> similar check for non-modular jars.
>
> jlink --add-modules java.base --module-path t.jar --output foo
> Error: Unable to deriv
On 2017-12-08 04:27, Sundararajan Athijegannathan wrote:
* Fixed to avoid second resolve for "module-info.class" in JlinkTask.java
Please review updated webrev:
http://cr.openjdk.java.net/~sundar/8192986/webrev.02/
+1
/Claes
Hi,
* On stricter check for missing module-info.class in a directory: There
is a similar check for non-modular jars.
jlink --add-modules java.base --module-path t.jar --output foo
Error: Unable to derive module descriptor for t.jar
t.jar in the above command is a non-modular jar. I think it
Hi,
Comments below...
On 07/12/17, 8:54 PM, Claes Redestad wrote:
Hi Sundar,
thanks for picking this up so quick!
On 2017-12-07 16:21, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8192986/webrev.01/
Looks ok, butunless my understanding is flawed it seems
Hi Sundar,
thanks for picking this up so quick!
On 2017-12-07 16:21, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8192986/webrev.01/
Looks ok, butunless my understanding is flawed it seems the logic is now
getting more strict about a directory on the module
Updated: http://cr.openjdk.java.net/~sundar/8192986/webrev.01/
PS. Bug description line was wrong in the test .java file.
-Sundar
On 07/12/17, 8:40 PM, Sundararajan Athijegannathan wrote:
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8192986
Webrev: http://cr.openjdk.java.net/~
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8192986
Webrev: http://cr.openjdk.java.net/~sundar/8192986/webrev.00/
Thanks,
-Sundar
