Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-17 Thread Mandy Chung
> On Feb 17, 2017, at 6:08 AM, Claes Redestad wrote: > > > http://cr.openjdk.java.net/~redestad/8175026/jdk.03/ > Looks good. 82 pre-generate, otherwise the list used to build the host JDK image wil\n\ typo: s/wil/will Minor suggestion to the wording to "generate-jli-classes.description

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-17 Thread Claes Redestad
On 02/16/2017 10:24 PM, Mandy Chung wrote: One more thing: the warning message should be in plugin.properties to be localized. Done: http://cr.openjdk.java.net/~redestad/8175026/jdk.03/ /Claes Mandy On Feb 16, 2017, at 12:04 PM, Mandy Chung wrote: On Feb 16, 2017, at 5:20 AM, Claes

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-16 Thread Mandy Chung
One more thing: the warning message should be in plugin.properties to be localized. Mandy > On Feb 16, 2017, at 12:04 PM, Mandy Chung wrote: > > >> On Feb 16, 2017, at 5:20 AM, Claes Redestad >> wrote: >> >>> >>> In addition, if the main argument is specified but the version does not >>>

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-16 Thread Mandy Chung
> On Feb 16, 2017, at 5:20 AM, Claes Redestad wrote: > >> >> In addition, if the main argument is specified but the version does not >> match, it will ignore the given argument. Should it be an error instead? >> We are the one who will generate a trace file and specify it in the jlink >> p

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-16 Thread Claes Redestad
Hi Mandy, On 02/15/2017 08:09 PM, Mandy Chung wrote: On Feb 15, 2017, at 9:12 AM, Claes Redestad wrote: Hi, currently the file we generate at build time as input to --generate-jli-classes is lost when linking custom images, which means user generate images may perform worse in certain ways, m

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-16 Thread Magnus Ihse Bursie
On 2017-02-15 18:12, Claes Redestad wrote: Hi, currently the file we generate at build time as input to --generate-jli-classes is lost when linking custom images, which means user generate images may perform worse in certain ways, mostly generating more classes during startup. Additionally, the

Re: RFR: 8175026: Capture build-time parameters to --generate-jli-classes

2017-02-15 Thread Mandy Chung
> On Feb 15, 2017, at 9:12 AM, Claes Redestad wrote: > > Hi, > > currently the file we generate at build time as input to > --generate-jli-classes is lost when linking custom images, which means > user generate images may perform worse in certain ways, mostly > generating more classes during st