Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-03 Thread Mandy Chung
Shura, > On Mar 3, 2016, at 12:11 PM, Alexandre (Shura) Iline > wrote: > > Hi. > > Could you please have another look on the webrev. > > http://cr.openjdk.java.net/~shurailine/8150998/webrev.jake.03/ > http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.03/ I have pushed the patch in

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-03 Thread Alexandre (Shura) Iline
Hi. Could you please have another look on the webrev. http://cr.openjdk.java.net/~shurailine/8150998/webrev.jake.03/ http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.03/ I have reverted changes to java/lang/management tests for now, until resolution of https://bugs.openjdk.java.net/br

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Mandy Chung
> On Mar 2, 2016, at 2:48 PM, Alexandre (Shura) Iline > wrote: > > >> On Mar 2, 2016, at 2:03 PM, Mandy Chung wrote: >> >> >>> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline >>> wrote: >>> >>> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/ >> >> >> test/java/lang/

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Alexandre (Shura) Iline
> On Mar 2, 2016, at 2:56 PM, Mandy Chung wrote: > > >> On Mar 2, 2016, at 2:13 PM, Alexandre (Shura) Iline >> wrote: >> >> >>> On Mar 2, 2016, at 2:03 PM, Mandy Chung wrote: >>> >>> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline wrote: http://cr.openjdk.java

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Mandy Chung
> On Mar 2, 2016, at 2:13 PM, Alexandre (Shura) Iline > wrote: > > >> On Mar 2, 2016, at 2:03 PM, Mandy Chung wrote: >> >> >>> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline >>> wrote: >>> >>> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/ >> >> >> test/java/lang/

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Alexandre (Shura) Iline
> On Mar 2, 2016, at 2:03 PM, Mandy Chung wrote: > > >> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline >> wrote: >> >> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/ > > > test/java/lang/instrument/MakeJAR2.sh > -XaddExports should not be brought to jdk9. Oh, that’s

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Jonathan Gibbons
On 03/02/2016 12:38 PM, Alexandre (Shura) Iline wrote: So, the dependency declaration needed to be changed anyway. Instead of fixing every test, I have declared the dependency in a newly added TEST.properties file, and removed @modules from tests altogether. Stylistically, I think it is bette

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Alexandre (Shura) Iline
> On Mar 2, 2016, at 2:03 PM, Mandy Chung wrote: > > >> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline >> wrote: >> >> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/ > > > test/java/lang/instrument/MakeJAR2.sh > -XaddExports should not be brought to jdk9. > > test/j

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Mandy Chung
> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline > wrote: > > http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/ test/java/lang/instrument/MakeJAR2.sh -XaddExports should not be brought to jdk9. test/java/lang/management/ManagementFactory/TEST.properties Should it be mov

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Alexandre (Shura) Iline
> On Mar 2, 2016, at 10:06 AM, Daniel Fuchs wrote: > > On 02/03/16 18:48, Alexandre (Shura) Iline wrote: >> Hi. >> >> Could you please take a look on a fix to add missing module dependencies for >> tests in java/lang. >> >> JDK9 changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev.j

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Roger Riggs
Hi Daniel, fyi, there is a new TEST.properties file for the java/lang/management tests that includes the needed @modules = jdk.management. Roger On 3/2/2016 1:06 PM, Daniel Fuchs wrote: On 02/03/16 18:48, Alexandre (Shura) Iline wrote: Hi. Could you please take a look on a fix to add miss

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

2016-03-02 Thread Daniel Fuchs
On 02/03/16 18:48, Alexandre (Shura) Iline wrote: Hi. Could you please take a look on a fix to add missing module dependencies for tests in java/lang. JDK9 changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.01 Jake changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev