Thanks. I'll file another bug to fix these issues.
-Sundar
On 19/12/16, 4:56 PM, Alan Bateman wrote:
On 19/12/2016 04:08, Sundararajan Athijegannathan wrote:
Fixed. Updated webrev for the record:
http://cr.openjdk.java.net/~sundar/8170289/webrev.03
I'm pushing this as you suggested..
cr.ope
On 19/12/2016 04:08, Sundararajan Athijegannathan wrote:
Fixed. Updated webrev for the record:
http://cr.openjdk.java.net/~sundar/8170289/webrev.03
I'm pushing this as you suggested..
cr.openjdk.java.net is currently down so I'm looking at the changes that
were pushed to jdk9/dev/jdk. A few c
Fixed. Updated webrev for the record:
http://cr.openjdk.java.net/~sundar/8170289/webrev.03
I'm pushing this as you suggested..
Thanks,
-Sundar
On 19/12/16, 6:55 AM, Mandy Chung wrote:
282 throw new RuntimeException(module + " does not have main
class: " + mainClassName)
282 throw new RuntimeException(module + " does not have
main class: " + mainClassName);
- Throwing IllegalArgumentException would probably be better.
101 err.launcher.value.format:launcher value should be of form
=: {0}
- should this message include optional main class; s
Updated it: http://cr.openjdk.java.net/~sundar/8170289/webrev.02
Thanks,
-Sundar
On 17/12/16, 12:33 AM, Mandy Chung wrote:
On Dec 16, 2016, at 8:36 AM, Sundararajan
Athijegannathan wrote:
Hi,
Please review http://cr.openjdk.java.net/~sundar/8170289/webrev.01/ for
https://bugs.openjdk.java.
> On Dec 16, 2016, at 8:36 AM, Sundararajan Athijegannathan
> wrote:
>
> Hi,
>
> Please review http://cr.openjdk.java.net/~sundar/8170289/webrev.01/ for
> https://bugs.openjdk.java.net/browse/JDK-8170289
273 Optional mainClass =
ModuleDescriptor.read(stream).mainClass();
274
