Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

2017-11-13 Thread mandy chung
Looks good.  Thanks for fixing this. Mandy On 11/13/17 2:02 AM, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8177471 Webrev: http://cr.openjdk.java.net/~sundar/8177471/webrev.00/index.html Thanks to Mandy for initial (internal) round of rev

Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

2017-11-13 Thread Alan Bateman
On 13/11/2017 16:36, Sundararajan Athijegannathan wrote: Thanks for the review. Updated as per suggestions: http://cr.openjdk.java.net/~sundar/8177471/webrev.01/index.html I think this looks fine. -Alan

Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

2017-11-13 Thread Sundararajan Athijegannathan
Thanks for the review. Updated as per suggestions: http://cr.openjdk.java.net/~sundar/8177471/webrev.01/index.html -Sundar On 13/11/17, 8:39 PM, Alan Bateman wrote: On 13/11/2017 08:02, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8177471

Re: RFR 8177471: jlink should use the version from java.base.jmod to find modules

2017-11-13 Thread Alan Bateman
On 13/11/2017 08:02, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8177471 Webrev: http://cr.openjdk.java.net/~sundar/8177471/webrev.00/index.html Thanks to Mandy for initial (internal) round of review and suggesting me simplifications on my