Re: jdeps -check: add section on exports

2016-04-04 Thread Alan Bateman
On 04/04/2016 11:55, Anthony Vanelverdinghe wrote: For the record: I've filed this as JI-9034435 I've moved it to the JDK project: https://bugs.openjdk.java.net/browse/JDK-8153362

Re: jdeps -check: add section on exports

2016-04-04 Thread Anthony Vanelverdinghe
For the record: I've filed this as JI-9034435 Anthony On 25/03/2016 21:08, Anthony Vanelverdinghe wrote: What's the next step? Will someone with JIRA access file a javac enhancement for this, or shall I do so myself through bugs.java.com? (I'm not sure what the preferred option is for issues th

Re: jdeps -check: add section on exports

2016-03-25 Thread Anthony Vanelverdinghe
What's the next step? Will someone with JIRA access file a javac enhancement for this, or shall I do so myself through bugs.java.com? (I'm not sure what the preferred option is for issues that have already been discussed on the mailing list) Thanks, Anthony On 24/03/2016 20:56, Alex Buckley w

Re: jdeps -check: add section on exports

2016-03-24 Thread Anthony Vanelverdinghe
ume it's a List implementation). Kind regards, Anthony On 24/03/2016 20:53, fo...@univ-mlv.fr wrote: Hi Anthony, - Mail original - De: "Anthony Vanelverdinghe" À: "Remi Forax" Cc: jigsaw-dev@openjdk.java.net Envoyé: Jeudi 24 Mars 2016 20:37:23 Objet: Re: jdep

Re: jdeps -check: add section on exports

2016-03-24 Thread Alex Buckley
On 3/24/2016 12:53 PM, fo...@univ-mlv.fr wrote: Moreover, I don't think an issue like this should fail the compilation: even if the example above would make it into a module: at worst a client could treat the result as an accessible super-type & use it (analog, for the case where an inaccessible

Re: jdeps -check: add section on exports

2016-03-24 Thread Alex Buckley
I think this is very well argued. Alex On 3/24/2016 12:37 PM, Anthony Vanelverdinghe wrote: I believe an error would be too harsh. Suppose I have a method: public CustomList getFoos() { ... } with problematic type CustomList. Then there are multiple options to resolve this, e.g.: - replace Cu

Re: jdeps -check: add section on exports

2016-03-24 Thread forax
Hi Anthony, - Mail original - > De: "Anthony Vanelverdinghe" > À: "Remi Forax" > Cc: jigsaw-dev@openjdk.java.net > Envoyé: Jeudi 24 Mars 2016 20:37:23 > Objet: Re: jdeps -check: add section on exports > > I believe an error would be too ha

Re: jdeps -check: add section on exports

2016-03-24 Thread Anthony Vanelverdinghe
I believe an error would be too harsh. Suppose I have a method: public CustomList getFoos() { ... } with problematic type CustomList. Then there are multiple options to resolve this, e.g.: - replace CustomList with a super type, likely List/Collection - make the method (package-)private - move

Re: jdeps -check: add section on exports

2016-03-23 Thread Remi Forax
- Mail original - > De: "Jonathan Gibbons" > À: jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 23 Mars 2016 20:58:20 > Objet: Re: jdeps -check: add section on exports > > At a minimum, it would be a candidate for a -Xlint check. > > -- Jon I think i

Re: jdeps -check: add section on exports

2016-03-23 Thread Jonathan Gibbons
At a minimum, it would be a candidate for a -Xlint check. -- Jon On 03/23/2016 11:31 AM, Remi Forax wrote: In my opinion, it should be a warning (or even an error) in javac, you should not create a bad module in the first place. Rémi - Mail original - De: "Anthony Vanelverdinghe" À:

Re: jdeps -check: add section on exports

2016-03-23 Thread Remi Forax
In my opinion, it should be a warning (or even an error) in javac, you should not create a bad module in the first place. Rémi - Mail original - > De: "Anthony Vanelverdinghe" > À: jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 23 Mars 2016 19:26:24 > Objet: jdeps -check: add section on