Re: Review Request: JDK-8160851: Remove old module-related options

2016-08-29 Thread Kevin Rushforth
After further discussion off line we are aiming to get the fix for JDK-8163316 into this week's build of jdk-9+134. -- Kevin Mandy Chung wrote: On Aug 26, 2016, at 4:17 PM, Kevin Rushforth wrote: Hi Mandy, How soon were you thinking to push this to 9-dev? Until we change JavaFX to use

Re: Review Request: JDK-8160851: Remove old module-related options

2016-08-27 Thread Alan Bateman
On 27/08/2016 00:06, Mandy Chung wrote: This patch removes the old module options from java, javac, javadoc, etc. The new options are in jdk-9+132 [1]. I did a scan on the jdk9/dev forest to replace any remaining reference to the old options. I find some tests in jdk9/hs/hotspot using the

Re: Review Request: JDK-8160851: Remove old module-related options

2016-08-26 Thread Mandy Chung
On Aug 26, 2016, at 4:17 PM, Kevin Rushforth wrote: > > Hi Mandy, > > How soon were you thinking to push this to 9-dev? Until we change JavaFX to > use the new options, which is planned to go into our dev repo on Monday for > the following week's promoted build (b135) So JDK-8163316 does not

Re: Review Request: JDK-8160851: Remove old module-related options

2016-08-26 Thread Jonathan Gibbons
Looks good to me. -- Jon On 08/26/2016 04:06 PM, Mandy Chung wrote: This patch removes the old module options from java, javac, javadoc, etc. The new options are in jdk-9+132 [1]. I did a scan on the jdk9/dev forest to replace any remaining reference to the old options. I find some tests i

Re: Review Request: JDK-8160851: Remove old module-related options

2016-08-26 Thread Kevin Rushforth
Hi Mandy, How soon were you thinking to push this to 9-dev? Until we change JavaFX to use the new options, which is planned to go into our dev repo on Monday for the following week's promoted build (b135) so if you push the changes to jdk9/dev before build 135 is promoted, it will break JavaFX

Review Request: JDK-8160851: Remove old module-related options

2016-08-26 Thread Mandy Chung
This patch removes the old module options from java, javac, javadoc, etc. The new options are in jdk-9+132 [1]. I did a scan on the jdk9/dev forest to replace any remaining reference to the old options. I find some tests in jdk9/hs/hotspot using the old options that I will file a separate iss