Re: Review Request: JDK-8166860 Add magic number to jmod file

2016-10-04 Thread Jonathan Gibbons
Langtools change looks good, -- Jon On 09/30/2016 09:29 PM, Mandy Chung wrote: Jon points out that javac should also be updated. javac currently opens the JMOD file with JarFileSystem. Jon and I discussed this and we agree to keep the current workaround for now and add the validation to det

Re: Review Request: JDK-8166860 Add magic number to jmod file

2016-09-30 Thread Mandy Chung
Jon points out that javac should also be updated. javac currently opens the JMOD file with JarFileSystem. Jon and I discussed this and we agree to keep the current workaround for now and add the validation to detect if the JMOD file is valid. Updated webrev: http://cr.openjdk.java.net/~mch

Re: Review Request: JDK-8166860 Add magic number to jmod file

2016-09-29 Thread Alan Bateman
On 29/09/2016 16:26, Mandy Chung wrote: On Sep 29, 2016, at 7:07 AM, Alan Bateman wrote: I think I agree on keep out of the ZipFile internals. As you noted, this is just packaging and link time so it's not a magic issue if the file is opened twice (assuming the file system isn't changing un

Re: Review Request: JDK-8166860 Add magic number to jmod file

2016-09-29 Thread Mandy Chung
> On Sep 29, 2016, at 7:07 AM, Alan Bateman wrote: > > I think I agree on keep out of the ZipFile internals. As you noted, this is > just packaging and link time so it's not a magic issue if the file is opened > twice (assuming the file system isn't changing under your feet of course). > > A

Re: Review Request: JDK-8166860 Add magic number to jmod file

2016-09-29 Thread Alan Bateman
On 29/09/2016 05:56, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8166860/webrev.00/index.html The change adds a magic number in jmod file to enable future revision of the JMOD format. It's currently a zip file and may change in a future release. JmodFile ope

Review Request: JDK-8166860 Add magic number to jmod file

2016-09-28 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8166860/webrev.00/index.html The change adds a magic number in jmod file to enable future revision of the JMOD format. It's currently a zip file and may change in a future release. JmodFile opens the file to validate the magic header and