Hello Mandy,
Looks good to me.
/Erik
On 2017-06-13 07:35, Mandy Chung wrote:
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182032/webrev.00/
java.compiler is a standalone technology that allows to be running on older
JDK, in particular for IDE to support new language featu
The langtools modules are not intended nor required to be upgradeable. JDK 9
javap will only work with JDK 9 java.compiler. When IDE upgrades java.compiler
to JDK 10 and runs on JDK 9, it would have to deliver a Java compiler
implementing JDK 10 JavaCompiler API and could also implement the ne
My concern is that by example javac and javap need to be aligned and by making
a module upgradeable you can not make only some packages upgradeable.
So it seems logical that if java.compiler is upgradeable the other modules of
langtools are upgradable too.
Rémi
On June 13, 2017 10:26:18 AM GM
On 13/06/2017 08:42, Remi Forax wrote:
Hi Mandy,
why only java.compiler is upgradable and not all modules defined in langtools ?
java.compiler needs to be upgradeable because JSR 199 and JSR 269 are
standalone technologies.
The other modules in the langtools repository are JDK-specific. They
Hi Mandy,
why only java.compiler is upgradable and not all modules defined in langtools ?
cheers,
Rémi
- Mail original -
> De: "Mandy Chung"
> À: "jigsaw-dev"
> Envoyé: Mardi 13 Juin 2017 07:35:04
> Objet: Review Request JDK-8182032: Make java.c
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182032/webrev.00/
java.compiler is a standalone technology that allows to be running on older
JDK, in particular for IDE to support new language features.
This patch takes out the make logic to find the modules that directly and
ind
