We plan to change these plugins to use regex instead of “*" notation.  This 
requires some coordination with users.

https://bugs.openjdk.java.net/browse/JDK-8158402

Speak up.

— Jim


> On Jun 1, 2016, at 12:56 PM, Jim Laskey (Oracle) <james.las...@oracle.com> 
> wrote:
> 
> I’ll change both jlink and jimage for consistency and optimize jlink if it 
> becomes an issue.  Will file separate bugs.
> 
> — Jim
> 
> 
>> On Jun 1, 2016, at 12:45 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
>> 
>> 
>> 
>> On 01/06/2016 16:35, Jim Laskey (Oracle) wrote:
>>> We tried using regex in jlink for various filters and found that it made 
>>> jlink > 10x slower.  Granted jlink is time critical and jimage is not.  I 
>>> made the assumption that filter expressions would be very basic, most of 
>>> the time, and tried to be consistent with filters for both tools.  I could 
>>> easily change it to use regex if not a basic pattern.
>>> 
>>> Note we also chose not to use java.lang.regex in Nashorn for similar 
>>> reasons (plus the fact it didn’t meet JS spec. .)  Might be worth 
>>> revisiting regex performance.
>>> 
>> I understand that this was an issue in Nashorn. I wasn't aware of this being 
>> a problem with jlink as the regex usage should be very simple with the 
>> order-resources or exclude-resources plugins. Note that jar and jmod both 
>> have options that are patterns so we are a bit inconsistent on this point.
>> 
>> -Alan.
> 

Reply via email to