Re: RFR: JDK-8080511 - Refresh of jimage support

2015-06-18 Thread Karen Kinnear
Code review for the hotspot component: Thank you for the cleanups to jvm.cpp to make them JVM_ENTRY and fix thread_state. If you pass the testing and Lois ok's the hotspot code, then I am ok with checking in the hotspot code as is. Comments for next round of changes: 1. mutexLocker.cpp - new

Re: RFR: JDK-8080511 - Refresh of jimage support

2015-06-18 Thread Lois Foltan
On 6/18/2015 10:59 AM, Karen Kinnear wrote: Code review for the hotspot component: Thank you for the cleanups to jvm.cpp to make them JVM_ENTRY and fix thread_state. If you pass the testing and Lois ok's the hotspot code, then I am ok with checking in the hotspot code as is. I have reviewe

Re: RFR: JDK-8080511 - Refresh of jimage support

2015-06-18 Thread Mandy Chung
http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-top modules.xml looks fine. test/lib/sun/hotspot/WhiteBox.java This adds the native entry points. Where are they implemented? It’s not obvious to me. http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-langtools