Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-06-12 Thread Wang Weijun
I was about to send out a new webrev (CCC just approved) but noticed a behavior change. Although "-addprovider SUN" is useless it still worked when I posted webrev.03, but now it failed, because ServiceLoader.load(Provider.class) does not contain "SUN" anymore. Maybe it is inside java.base and

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-06-12 Thread Alan Bateman
On 12/06/2016 13:44, Wang Weijun wrote: I was about to send out a new webrev (CCC just approved) but noticed a behavior change. Although "-addprovider SUN" is useless it still worked when I posted webrev.03, but now it failed, because ServiceLoader.load(Provider.class) does not contain "SUN"

Re: RFR JDK-8151913: Fix module dependencies in java/net tests

2016-06-12 Thread Alan Bateman
On 11/06/2016 08:59, John Jiang wrote: Hi, Just restarted this job. On 2016/4/29 15:34, Alan Bateman wrote: On 28/04/2016 05:50, John Jiang wrote: Hi, Please review another webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.02 The java.httpclient module declaration is removed from a

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

2016-06-12 Thread Mandy Chung
> On Jun 12, 2016, at 11:33 AM, Alan Bateman wrote: > > > > On 12/06/2016 13:44, Wang Weijun wrote: >> I was about to send out a new webrev (CCC just approved) but noticed a >> behavior change. >> >> Although "-addprovider SUN" is useless it still worked when I posted >> webrev.03, but now

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

2016-06-12 Thread Masayoshi Okutsu
On 6/11/2016 5:53 AM, Mandy Chung wrote: On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu wrote: (re-sending to include jigsaw-dev) Hi, Please review fixes for 8158272 and 8158468. The test had several problems. : Webrev: http://cr.openjdk.java.net/~okutsu/9/8158272.8158468/webrev.00 It’s go