Re: JPMS Access Checks, Verification and the Security Manager

2017-05-24 Thread Volker Simonis
On Tue, May 23, 2017 at 10:01 PM, Alex Buckley wrote: > On 5/23/2017 7:44 AM, Volker Simonis wrote: >> >> So maybe I rephrase my question a little more generally: >> >> Is it required for the verifier to do security and/or access checks >> during the verification phase or could/should these checks

hg: jigsaw/jake/jdk: Add ModuleLayer.Controler.addExports

2017-05-24 Thread alan . bateman
Changeset: af9b58592f6b Author:alanb Date: 2017-05-24 13:32 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/af9b58592f6b Add ModuleLayer.Controler.addExports ! src/java.base/share/classes/java/lang/ModuleLayer.java ! test/java/lang/ModuleLayer/LayerControllerTest.java

Review Request: JDK-8181033: Confusing message: A JNI error has occurred, please check your installation and try again

2017-05-24 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181033/webrev.00/ This fixes the launcher to print the exception being thrown rather than the confusing message "Error: A JNI error has occurred, please check your installation and try again”. A few attempts to improve this to catch ClassNotFoundE

Re: Review Request: JDK-8181033: Confusing message: A JNI error has occurred, please check your installation and try again

2017-05-24 Thread Kumar Srinivasan
Looks ok to me. Kumar http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181033/webrev.00/ This fixes the launcher to print the exception being thrown rather than the confusing message "Error: A JNI error has occurred, please check your installation and try again”. A few attempts to improve th

Re: Review Request: JDK-8181033: Confusing message: A JNI error has occurred, please check your installation and try again

2017-05-24 Thread Kumar Srinivasan
Oh! the test needs the BugId. Kumar Looks ok to me. Kumar http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181033/webrev.00/ This fixes the launcher to print the exception being thrown rather than the confusing message "Error: A JNI error has occurred, please check your installation and t

Re: Review Request: JDK-8181033: Confusing message: A JNI error has occurred, please check your installation and try again

2017-05-24 Thread Alan Bateman
On 24/05/2017 23:10, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181033/webrev.00/ This fixes the launcher to print the exception being thrown rather than the confusing message "Error: A JNI error has occurred, please check your installation and try again”. A few attemp