Re: 8186738: (sl) ServiceLoader::stream doesn't update cache

2017-10-13 Thread Alan Bateman
On 12/10/2017 23:54, mandy chung wrote: : test/jdk/java/util/ServiceLoader/security/test/p/Tests.java 184 assertTrue(e.getCause() instanceof Error); I think it's more precise to check e.getCause().getClass() == Error.class. You are right, that test should be improved, more so if each of cases

Re: 8186738: (sl) ServiceLoader::stream doesn't update cache

2017-10-13 Thread mandy chung
On 10/13/17 6:51 AM, Alan Bateman wrote: On 12/10/2017 23:54, mandy chung wrote: : test/jdk/java/util/ServiceLoader/security/test/p/Tests.java 184 assertTrue(e.getCause() instanceof Error); I think it's more precise to check e.getCause().getClass() == Error.class. You are right, that test

JDK-8189251

2017-10-13 Thread cowwoc
Hi, I'm trying to understand the reasoning behind https://bugs.openjdk.java.net/browse/JDK-8189251 being closed as Won't Fix. Can someone please clarify the downside of named automatic-modules vs normal modules? I assume that there is some sort of downside; otherwise, we wouldn't be warning about