Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-05-06 Thread Alan Bateman
On 09/04/2019 10:06, Severin Gehwolf wrote: : Hi Severin, This is my initial set of comments. Thanks for the review! Latest webrev with the updates: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/09/webrev/ I went through 09/webrev and just have a few comments, mostly on StripNati

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-05-06 Thread Alex Buckley
On 4/12/2019 12:03 PM, Alex Buckley wrote: On 4/12/2019 5:34 AM, Jan Lahoda wrote: I've started with the CSR here: https://bugs.openjdk.java.net/browse/JDK-8222396 Looks pretty good. I made some edits to record both of your single-module and multi-module invocations of javac. The use case of