Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-20 Thread Ao Qi
On 2020/4/20 下午9:27, Alan Bateman wrote: On 20/04/2020 11:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now. Likely a mistake. The changeset http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42 has that file. Perhaps it may be useful to restore &

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-20 Thread sundararajan . athijegannathan
Hi Alan, I don't remember it now. Likely a mistake. The changeset http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42 has that file. Perhaps it may be useful to restore & check if the test passes. Thanks, -Sundar On 18/04/20 3:32 pm, Alan Bateman wrote: Sundar - do you recognize

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-20 Thread Alan Bateman
On 20/04/2020 11:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now. Likely a mistake. The changeset http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42 has that file. Perhaps it may be useful to restore & check if the test passes. Yes. I think it was

Re: RFR (T): 8243117: Cleanups in Java code of module jdk.jlink

2020-04-20 Thread Alan Bateman
On 19/04/2020 20:08, Langer, Christoph wrote: Hi Alan, Looks okay to me too, except @SuppressWarnings("unused") looks strange, is that an Eclipse compiler warning name? Yes, it comes from Eclipse, probably only used by its compiler. The private field EXIT_SYSERR doesn't seem to be used.

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

2020-04-20 Thread Ao Qi
Hi Alan and Sundar, Thanks for the advice. I will take a look at if the test should be brought back. Cheers, Ao Qi On 2020/4/20 下午6:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now. Likely a mistake. The changeset