Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

On 01/12/2015 23:18, Roger Riggs wrote: Please review a fix for jimage native code to correctly maintain the list of ImageFileReaders. This looks okay to me too. I assume we'll need to get this into jake too. -Alan

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

On 02/12/2015 15:17, Roger Riggs wrote: Hi Alan, I just pushed it to jdk9, it should merge easily; can you or Jim take care of getting it into Jake. Ideally it would come in when we sync up jake but there are conflicts to sort and I think we might have manually update the native jimage

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 12/02/2015 08:46 AM, Remi Forax wrote: - Mail original - De: "Alan Bateman" À: "Stephane Epardaud" , jigsaw-dev@openjdk.java.net Envoyé: Mercredi 2 Décembre 2015 14:56:00 Objet: Re: is ClassLoader.loadClass() supposed to work on module-info

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

I had it in my pending changes, but I’ll isolate and add. > On Dec 2, 2015, at 11:17 AM, Roger Riggs wrote: > > Hi Alan, > > I just pushed it to jdk9, it should merge easily; can you or Jim take care > of getting it into Jake. > > Thanks, Roger > > > On

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

Being a meta-data container, I don't understand why it's not under META-INF ? Jeff On Wed, Dec 2, 2015 at 4:15 PM, David M. Lloyd wrote: > On 12/02/2015 09:05 AM, Remi Forax wrote: > >> >> >> - Mail original - >> >>> De: "David M. Lloyd"

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

This is probably a good time to (once again) bring up the objection that the Module Descriptor shouldn't be a class file to begin with. I know I am not the only one who has stated this on the mailing list. I doubt this email will gain any traction, but it's something the EG should seriously

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

Hi Alan, I just pushed it to jdk9, it should merge easily; can you or Jim take care of getting it into Jake. Thanks, Roger On 12/02/2015 10:15 AM, Alan Bateman wrote: On 01/12/2015 23:18, Roger Riggs wrote: Please review a fix for jimage native code to correctly maintain the list of

Re: Running module jar programatically

A bit off-topic, but I wanted to clarify something, in case my many questions sound negative: I think you guys have done a tremendous job with Jigsaw, and IMO the hardest is behind you, I can see there was a huge amount of work (well, you started it in Java 7…) to get to his point, and I feel

Re: Running module jar programatically

On 02/12/2015 15:24, Stephane Epardaud wrote: Hi, I have a modular jar produced by Java 9 EA + Jigsaw, I can run it with "java -mp mlib -m my.module", but how can I run it programmatically in Java? ATM I'm using URLClassLoader to load it and run it, but I _think_ it does not make it "modular"

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 02/12/15 14:56, Alan Bateman wrote: > The this_class should be /module-info but in any case, The funny thing is that this module-info.class was created by the Java 9+Jigsaw EA "stock" javac. How it got the ".Test" class mixed up in there is not clear to me. Perhaps as a result of me

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 12/02/2015 09:05 AM, Remi Forax wrote: - Mail original - De: "David M. Lloyd" À: jigsaw-dev@openjdk.java.net Envoyé: Mercredi 2 Décembre 2015 15:52:56 Objet: Re: is ClassLoader.loadClass() supposed to work on module-info classes? On 12/02/2015 08:46 AM,

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 02/12/2015 14:35, Stephane Epardaud wrote: On 02/12/15 14:56, Alan Bateman wrote: The this_class should be /module-info but in any case, The funny thing is that this module-info.class was created by the Java 9+Jigsaw EA "stock" javac. How it got the ".Test" class mixed up in there is not

hg: jigsaw/jake/hotspot: Improve module related IAE error messages, add unnamed module identity hash to messages.

Changeset: ec9ad3190695 Author:hseigel Date: 2015-12-02 10:23 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ec9ad3190695 Improve module related IAE error messages, add unnamed module identity hash to messages. ! src/share/vm/classfile/modules.cpp !

Re: no error when module exports non-existing package

Adding Victor back into the recipients. -- Jon On 12/02/2015 10:08 AM, Jonathan Gibbons wrote: On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error,

no error when module exports non-existing package

Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error, or at least a warning. Today was the third time I saw the code with a typo or just incorrect package name in module-info's exports statement.

Re: no error when module exports non-existing package

On 12/02/2015 09:41 AM, Victor Rudometov wrote: Hi, Javac does not complain if user exports a package that does not exist. If it was not done intentionally, it would be good to report an error, or at least a warning. Today was the third time I saw the code with a typo or just incorrect

Re: using modules for caching

On 12/02/2015 01:40 PM, Jochen Theodorou wrote: Hi, I was wondering if it will be possible to reuse module information between runs.. Currently I am collecting a lot of reflective information and use it to build a meta class system, which I then need to do method invocations, what fields

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

Thank you for repeating my concerns I raised in September. Stephen Felts wrote: I agree. I would much rather be able to see the information using unzip -p and update it using a text editor or any tool that can write text. -Original Message- From: Paul Benedict

Re: Question about jdk.internal.HotSpotIntrinsicCandidate

On 12/2/2015 2:16 AM, Stephane Epardaud wrote: On 01/12/15 22:04, Alex Buckley wrote: There shouldn't be any surprise here. In Java SE 8, you can declare a package-private annotation type and use it to write annotations on public classes of that package. Going up a level in Java SE 9, you can

CFV: New Jigsaw Committer: Jan Lahoda

|I hereby nominate Jan Lahoda to Jigsaw Committer. Jan is already a Reviewer for the JDK 9 project, and has made the following contributions to the jigsaw/jake forest: | http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ad2566ebc2a6dabb7f2bcbd920c23a9b3b4c4d2c

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: Yes. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co.

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: yes

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: YES -Chris > On 2 Dec 2015, at 7:43 p.m., Jonathan Gibbons > wrote: > > |I hereby nominate Jan Lahoda to Jigsaw Committer. > > Jan is already a Reviewer for the JDK 9 project, and has made the following > contributions to the jigsaw/jake forest: > | > >

Re: using modules for caching

- Mail original - > De: "Peter Levart" > À: "Jochen Theodorou" , jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 2 Décembre 2015 17:45:59 > Objet: Re: using modules for caching > > > > On 12/02/2015 01:40 PM, Jochen Theodorou wrote: > > Hi, >

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: yes Mandy

Re: Running module jar programatically

On 12/2/15 5:26 PM, Stephane Epardaud wrote: > Of course it does not help that I have to do this all outside of my IDE > as Eclipse doesn't know about Java 9 yet :( See https://marketplace.eclipse.org/content/java-9-support-beta-neon cheers, dalibor topic -- Oracle

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 12/2/2015 8:31 AM, Paul Benedict wrote: All that information is locked in binary format but it should be human readable. I should be able to go in myself and do this with a text editor. I shouldn't have to compile a file anymore than I have to compile my MANIFEST.MF or web.xml or

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

Alex, the primary benefit of annotations (vs. XML) is delivering code and configuration in one bundle. It's unnecessary to deliver configuration separately (i.e., XML) if you have a component that primarily has one way of being configured. That's exactly why annotations are very valuable in EE

Re: Running module jar programatically

The Java 9 support in Eclipse Neon is fairly limited right now. It understands the new layout of the JRE and puts the platform modules on your build classpath. It does not however understand the syntax of module-info.java, so you will get red error markers in these files, and you will need to

is ClassLoader.loadClass() supposed to work on module-info classes?

Just tried it and got: Exception in thread "main" java.lang.ClassFormatError: Illegal class name "com.ceylon.java9.Test" in class file module-info at java.lang.ClassLoader.defineClass1(java.base@9.0/Native Method) at java.lang.ClassLoader.defineClass(java.base@9.0/ClassLoader.java:854)

Re: JVMTI and instrumentation

On 2 December 2015 at 11:45, Alan Bateman wrote: > Just to get more context, are you trying to avoid the -Xpatch option and > have everything done by the agent so it's just a -agentlib option? If there > really is a need for this then it might be something for a JVM TI

using modules for caching

Hi, I was wondering if it will be possible to reuse module information between runs.. Currently I am collecting a lot of reflective information and use it to build a meta class system, which I then need to do method invocations, what fields are available and other things like that. Since that

Re: RFR: JDK 9: 8143879 jdk/internal/jimage/JImageReadTest.java crashes jvm in msvcr120.dll

+1 > On Dec 1, 2015, at 7:18 PM, Roger Riggs wrote: > > Please review a fix for jimage native code to correctly maintain the list of > ImageFileReaders. > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8143879 > > Webrev: >

Re: is ClassLoader.loadClass() supposed to work on module-info classes?

On 02/12/2015 11:01, Stephane Epardaud wrote: Just tried it and got: Exception in thread "main" java.lang.ClassFormatError: Illegal class name "com.ceylon.java9.Test" in class file module-info at java.lang.ClassLoader.defineClass1(java.base@9.0/Native Method) at