Re: Java Platform Module System

2017-04-28 Thread Alex Buckley
On 4/27/2017 12:38 PM, Stephan Herrmann wrote: On 25.04.2017 19:02, Alex Buckley wrote: JPMS semantics (notably, dependency resolution) are defined by the API specification (not the implementation) of java.lang.module.Configuration and friends. JLS references to JPMS are references to this Java

Re: Issue with JavaFX and Jigsaw

2017-04-28 Thread Kevin Rushforth
Following up on this thread... While writing the unit tests and documentation for this it became clear to me that it requiring applications to export as public API all packages used by FXML, Java Beans, and JavaScript callbacks from WebView is not a reasonable requirement. The fact that we

Re: SecurityManager environments

2017-04-28 Thread Alan Bateman
On 28/04/2017 19:33, Russell Gold wrote: : This only works for executable jars? Not libraries? That is correct. If the executable JAR has Class-Path attributes then whoever is creating the application needs to have a global understanding so that the Add-Exports or Add-Opens has the complete

Re: RFR: 8179434: test/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails due to JDK-8177845

2017-04-28 Thread Doug Simon
> On 28 Apr 2017, at 21:11, Mandy Chung wrote: > > Looks good. Thanks for the review. -Doug >> On Apr 28, 2017, at 12:05 PM, Doug Simon wrote: >> >> Please review this small fix for a regression introduced by the change for >>

Re: RFR: 8179434: test/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails due to JDK-8177845

2017-04-28 Thread Mandy Chung
Looks good. Mandy > On Apr 28, 2017, at 12:05 PM, Doug Simon wrote: > > Please review this small fix for a regression introduced by the change for > https://bugs.openjdk.java.net/browse/JDK-8177845. > > http://cr.openjdk.java.net/~dnsimon/8179434/ >

RFR: 8179434: test/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java fails due to JDK-8177845

2017-04-28 Thread Doug Simon
Please review this small fix for a regression introduced by the change for https://bugs.openjdk.java.net/browse/JDK-8177845. http://cr.openjdk.java.net/~dnsimon/8179434/ https://bugs.openjdk.java.net/browse/JDK-8179434 -Doug

Re: SecurityManager environments

2017-04-28 Thread Russell Gold
> On Apr 6, 2017, at 3:50 AM, Alan Bateman wrote: > The Add-Exports and Add-Opens attributes are the executable JAR equivalent of > the --add-exports and --add-opens command line options. So if an application > is hacking into say sun.awt then the maintainer of the

hg: jigsaw/jake/jdk: Missing "_" from list not allowed in identifier

2017-04-28 Thread alan . bateman
Changeset: 67cc686edb03 Author:alanb Date: 2017-04-28 18:56 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/67cc686edb03 Missing "_" from list not allowed in identifier ! src/java.base/share/classes/jdk/internal/module/Checks.java !

hg: jigsaw/jake/hotspot: runtime/modules/JVM* tests failing

2017-04-28 Thread alan . bateman
Changeset: cb4db673f846 Author:alanb Date: 2017-04-28 16:36 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/cb4db673f846 runtime/modules/JVM* tests failing ! test/runtime/modules/JVMAddModuleExports.java ! test/runtime/modules/JVMAddModulePackage.java !

hg: jigsaw/jake/jdk: 3 new changesets

2017-04-28 Thread alan . bateman
Changeset: 9313f1d89ca3 Author:alanb Date: 2017-04-28 14:05 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9313f1d89ca3 Java identifier validation incomplete ! src/java.base/share/classes/jdk/internal/module/Checks.java ! test/java/lang/module/ModuleDescriptorTest.java

Re: Can automatic modules be made to work?

2017-04-28 Thread Stephen Colebourne
On 27 April 2017 at 19:50, Robert Scholte wrote: > The returning question is: how can I as a *library builder* participate in > adopting Jigsaw? Indeed, the community really wants to help JPMS adoption and add module metadata. Since bottom up won't work, a mechanism needs