Hi, I noticed that the method ModuleLayer#layers() uses the following code
to get the module layers in resolution order:
/**
* Returns an ordered stream of layers. The first element is this layer,
* the remaining elements are the parent layers in DFS order.
*
* @implNote
On 6/14/18 9:35 AM, Doug Simon wrote:
I changed the test (thanks Mandy for pointing out exactly which one),
fixed the alphabetic ordering of the list and am running tests now.
I reviewed http://cr.openjdk.java.net/~dnsimon/8205025/. Looks good.
Mandy
Good.
Thanks,
Vladimir
On 6/14/18 9:35 AM, Doug Simon wrote:
On 14 Jun 2018, at 12:03, Alan Bateman wrote:
On 14/06/2018 09:09, Doug Simon wrote:
In the context of JDK-8202762, we to need to make the jdk.aot module
upgradeable. Otherwise, it is impossible to run or test the version of
On 14/06/2018 17:35, Doug Simon wrote:
:
This looks okay except that there has been an attempt to keep the list of
modules in alphabetic order in these make files.
Do all tests pass with this change? There is at least one test in
test/jdk/jdk/modules/etc that is sensitive to the list of
Test change and the update to the name ordering looks good
> On Jun 14, 2018, at 12:35 PM, Doug Simon wrote:
>
>
>
>> On 14 Jun 2018, at 12:03, Alan Bateman wrote:
>>
>>
>>
>> On 14/06/2018 09:09, Doug Simon wrote:
>>> In the context of JDK-8202762, we to need to make the jdk.aot module
> On 14 Jun 2018, at 12:03, Alan Bateman wrote:
>
>
>
> On 14/06/2018 09:09, Doug Simon wrote:
>> In the context of JDK-8202762, we to need to make the jdk.aot module
>> upgradeable. Otherwise, it is impossible to run or test the version of
>> jdk.aot under development in a Graal repo:
>>
test/jdk/jdk/modules/etc/UpgradeableModules.java needs to be updated as
it keeps the list of upgradeable modules as well to verify the hashes in
java.base.
Mandy
On 6/14/18 1:09 AM, Doug Simon wrote:
In the context of JDK-8202762, we to need to make the jdk.aot module
upgradeable.
On 14/06/2018 09:09, Doug Simon wrote:
In the context of JDK-8202762, we to need to make the jdk.aot module
upgradeable. Otherwise, it is impossible to run or test the version of jdk.aot
under development in a Graal repo:
java
In the context of JDK-8202762, we to need to make the jdk.aot module
upgradeable. Otherwise, it is impossible to run or test the version of jdk.aot
under development in a Graal repo:
java
