Re: Review Request 8240910: jmod rejects duplicate entries in --class-path jars

2020-05-07 Thread Lance Andersen
Hi Mandy, The extra updates look good. Thank you for adding the additional clean up! Best Lance > On May 7, 2020, at 2:39 PM, Mandy Chung wrote: > > I have taken a further step to clean this up by recording the written entries > such that it can filter out duplicated entries properly: > >

Re: Review Request 8240910: jmod rejects duplicate entries in --class-path jars

2020-05-07 Thread Alan Bateman
On 07/05/2020 19:39, Mandy Chung wrote: I have taken a further step to clean this up by recording the written entries such that it can filter out duplicated entries properly: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.01/ This version looks okay to me as it cleans up the

Re: Review Request 8240910: jmod rejects duplicate entries in --class-path jars

2020-05-07 Thread Mandy Chung
I have taken a further step to clean this up by recording the written entries such that it can filter out duplicated entries properly: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8240910/webrev.01/ thanks Mandy On 5/7/20 10:12 AM, Mandy Chung wrote: jmod tool should ignore duplicated

Re: Review Request 8240910: jmod rejects duplicate entries in --class-path jars

2020-05-07 Thread Lance Andersen
+1 > On May 7, 2020, at 1:12 PM, Mandy Chung wrote: > > jmod tool should ignore duplicated resources from class path and emit a > warning. It currently ignores duplicated resources when read from a > directory but not from JAR entries. It's an oversight from the fix for > JDK-8134779 [1] >

Review Request 8240910: jmod rejects duplicate entries in --class-path jars

2020-05-07 Thread Mandy Chung
jmod tool should ignore duplicated resources from class path and emit a warning.  It currently ignores duplicated resources when read from a directory but not from JAR entries.  It's an oversight from the fix for JDK-8134779 [1]