Re: RFR: 8207263: Store the Configuration for system modules into CDS archive

2018-08-09 Thread Calvin Cheung
into archiving the immutable singletons in java.util.ImmutableCollections. Thanks! Jiangli On 8/3/18 2:58 PM, Ioi Lam wrote: On 8/3/18 11:37 AM, Calvin Cheung wrote: Hi Jiangli, The changes look good to me. I have couple of minor comments: 1) vmSymbols.hpp 653 template(url_void_sig

Re: RFR(S): 8138600: eliminate the need of ModuleLoaderMap.dat for CDS

2017-09-13 Thread Calvin Cheung
Thanks for your review Mandy. Calvin On 9/12/17, 3:33 PM, mandy chung wrote: (I move this thread from jdk10-dev to jigsaw-dev which can review the jdk change). The JDK change looks good to me. Mandy On 9/12/17 3:14 PM, Calvin Cheung wrote: With the fix for JDK-8186842 <ht