Changeset: c67fef98eaff
Author:jjg
Date: 2016-02-24 14:49 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/c67fef98eaff
fix javac support of new -XaddExports -XaddReads
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
!
Changeset: f8e4851cc07b
Author:jjg
Date: 2016-02-12 15:26 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f8e4851cc07b
Another test fixed
! test/ProblemList.jake.txt
! test/tools/javac/diags/Example.java
!
Changeset: 3d8e36ed9704
Author:jjg
Date: 2016-02-12 18:40 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/3d8e36ed9704
more test fixes
!
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties
! test/ProblemList.jake.txt
Changeset: b28560322ba6
Author:jjg
Date: 2016-02-12 18:27 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b28560322ba6
more test fixes
! test/ProblemList.jake.txt
! test/com/sun/javadoc/testLinkOption/TestLinkOption.java
+
Changeset: 240144ea7a0c
Author:jjg
Date: 2016-02-12 19:52 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/240144ea7a0c
fixed test
! test/ProblemList.jake.txt
! test/com/sun/javadoc/testHtmlVersion/TestHtmlVersion.java
Changeset: c6037af08f9a
Author:jjg
Date: 2016-02-14 10:14 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/c6037af08f9a
Initial javac support for new-style -Xpatch option
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java
!
Changeset: dcf1cb246b76
Author:jjg
Date: 2016-02-15 13:41 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/dcf1cb246b76
allow multiple values for a module in -Xpatch option
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java
Changeset: f3d413211d69
Author:jjg
Date: 2016-02-16 15:21 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f3d413211d69
8149033: ClassCastException in case of service implementation is nested static
class
!
Changeset: ebf7cc8f20c7
Author:ksrini
Date: 2016-02-12 10:28 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ebf7cc8f20c7
8149597: javadoc should use new doclet by default
! make/launcher/Launcher-jdk.javadoc.gmk
Changeset: 7ee81202a226
Author:jjg
Date: 2016-02-16 17:17 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7ee81202a226
fill in missing implementations
! src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java
!
Changeset: e73cc88f52e6
Author:jjg
Date: 2016-02-19 16:39 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e73cc88f52e6
update problem list
! test/ProblemList.jake.txt
Changeset: 03020ca5f4ce
Author:jjg
Date: 2016-02-19 16:47 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/03020ca5f4ce
update problem list
! test/ProblemList.jake.txt
Changeset: a2035933e3a2
Author:jjg
Date: 2016-02-19 17:41 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/a2035933e3a2
fix test and update problem list
! test/ProblemList.jake.txt
! test/tools/javac/Paths/Diagnostics.sh
Changeset: 2cd6834696ec
Author:jjg
Date: 2016-02-19 18:07 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2cd6834696ec
fix test and update problem list
! src/java.compiler/share/classes/javax/tools/StandardLocation.java
! test/ProblemList.jake.txt
!
Changeset: f2d3110f3fe7
Author:jjg
Date: 2016-02-19 18:39 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f2d3110f3fe7
fix test and update problem list
! test/ProblemList.jake.txt
! test/tools/javac/api/TestSearchPaths.java
Changeset: 6f0f4866caa3
Author:jjg
Date: 2016-02-19 18:56 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/6f0f4866caa3
fix test and update problem list
! test/ProblemList.jake.txt
! test/tools/javac/options/xprefer/XPreferTest.java
Changeset: 18a98f8f09a4
Author:vromero
Date: 2016-02-10 17:30 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/18a98f8f09a4
8149033: ClassCastException in case of service implementation is nested static
class
!
Changeset: ea916dd6ad45
Author:jjg
Date: 2016-03-10 16:09 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ea916dd6ad45
fix CSS issues and merge issues
!
src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java
!
Changeset: d34fb849c377
Author:jjg
Date: 2016-03-10 17:10 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d34fb849c377
prohibit -sourcepath and -modulesourcepath together
! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java
!
Changeset: 28556ee3299f
Author:jjg
Date: 2016-03-10 17:26 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/28556ee3299f
suppress -sourcepath in internal Ant build
! make/build.xml
Changeset: ea2696da9140
Author:jjg
Date: 2016-03-16 15:17 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ea2696da9140
Simplify module test organization
- test/tools/javac/main/MOptionTest.java
+ test/tools/javac/modules/MOptionTest.java
+
Changeset: 34fbc157727e
Author:jjg
Date: 2016-03-15 16:17 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/34fbc157727e
move problem tests to main ProblemList.txt
- test/ProblemList.jake.txt
! test/ProblemList.txt
! test/tools/javac/diags/examples.not-yet.txt
Changeset: e743f91c2e24
Author:jjg
Date: 2016-03-15 18:42 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e743f91c2e24
cleanup diags examples
! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java
! test/ProblemList.txt
!
Changeset: ed65135d4cd4
Author:jjg
Date: 2016-03-14 14:42 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ed65135d4cd4
improve javac -X output
! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties
Changeset: 46bf8a56f516
Author:jjg
Date: 2016-03-14 14:56 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/46bf8a56f516
remove obsolete dependence on java.lagging
! src/java.compiler/share/classes/module-info.java
Changeset: 8c6b165360cb
Author:jjg
Date: 2016-03-08 17:46 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8c6b165360cb
start converting new code to new diags system
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
!
Changeset: 653b36207ab2
Author:jjg
Date: 2016-03-08 18:40 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/653b36207ab2
minor source cleanup
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
Changeset: 4592ca08edb5
Author:jjg
Date:
Changeset: 806170c571fc
Author:jjg
Date: 2016-03-08 14:35 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/806170c571fc
Add missing comments
! src/jdk.compiler/share/classes/com/sun/source/tree/ExportsTree.java
!
Changeset: afbcbbe35fe7
Author:jjg
Date: 2016-03-14 15:12 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/afbcbbe35fe7
remove temporary copy of old option
! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java
On 03/30/2016 02:45 PM, fo...@univ-mlv.fr wrote:
*De: *"Ali Ebrahimi" <ali.ebrahimi1...@gmail.com>
*À: *"Remi Forax" <fo...@univ-mlv.fr>
*Cc: *"Alan Bateman" &l
Changeset: 2894246c04e2
Author:jjg
Date: 2016-04-08 16:54 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2894246c04e2
fix long broken test
! make/tools/crules/CodingRulesAnalyzerPlugin.java
! make/tools/crules/MutableFieldsAnalyzer.java
!
Changeset: f896cf730e26
Author:jjg
Date: 2016-04-08 13:56 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f896cf730e26
fix broken test (bad -addmods)
! test/tools/javac/processing/model/testgetallmembers/Main.java
Changeset: f32fdd9422b5
Author:jjg
Date:
Konstantin,
The compiler checks that the service implementation implements the
service type.
I have confidence that when the final specification is published, there
will be suitable assertions (either explicit or implicit) to back up
that check.
-- Jon
On 03/17/2016 06:02 AM, Konstantin
Changeset: f6d069e0b7e3
Author:jjg
Date: 2016-03-16 11:30 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f6d069e0b7e3
Address review feedback
!
src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java
!
At a minimum, it would be a candidate for a -Xlint check.
-- Jon
On 03/23/2016 11:31 AM, Remi Forax wrote:
In my opinion, it should be a warning (or even an error) in javac,
you should not create a bad module in the first place.
Rémi
- Mail original -
De: "Anthony Vanelverdinghe"
Martin,
Can you provide details on how to reproduce this (e.g. including repo paths)
-- Jon
On 03/24/2016 04:10 PM, Martin Buchholz wrote:
Hi jigsaw/javadoc folk,
I'm trying to update jsr166 CVS to latest jdks and failing.
If I run "ant docs" with a -Djdk9.home pointing at jdk-9+110
Changeset: e6b63f4a002a
Author:jjg
Date: 2016-03-04 16:49 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/e6b63f4a002a
fix missing package label in new doclet
!
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java
!
Georgiy,
Please file this as an issue against javac, and we'll take it from
there. The case of the final class has previously been considered and
considered "silly but not wrong", but the other two have not been
explicitly considered.
Alex has previously said in this forum that 'uses' and
- Mail original -
De: "Jonathan Gibbons" <jonathan.gibb...@oracle.com>
À: "Remi Forax" <fo...@univ-mlv.fr>, "Alan Bateman" <alan.bate...@oracle.com>
Cc: "Russell Gold" <russell.g...@oracle.com>, "jigsaw-dev"
&
Wow, someone uses that; thanks for the update.
-- Jon
On 04/29/2016 04:27 PM, mark.reinh...@oracle.com wrote:
If this looks okay to you then I'll push it.
(It also enables -ea for jdk.javadoc code, which I suspect was always
the intent.)
Thanks,
- Mark
# HG changeset patch
# Parent
On 05/23/2016 10:33 AM, Uwe Schindler wrote:
Maybe change to something like:
warning: [options] bootstrap class path not set in conjunction with -source
1.8; consider using -target 1.8
Uwe
I presume you meant -release, not -target:
warning: [options] bootstrap class path not set in
On 05/23/2016 02:31 PM, Stuart Marks wrote:
On 5/20/16 4:59 PM, Jonathan Gibbons wrote:
While I would agree on the use of one type, not two, for file paths,
I would
question the choice to use String instead of Path. If something is a
file path,
use the type system to say so, and use a Path
Stuart,
While I would agree on the use of one type, not two, for file paths, I
would question the choice to use String instead of Path. If something
is a file path, use the type system to say so, and use a Path.
-- Jon
On 05/20/2016 04:52 PM, Stuart Marks wrote:
On 5/16/16 1:18 AM, Felix
It would be good if (eventually) there were test cases involving the use
of MRM jars, both via the JarFile API and jar-fs file system, perhaps
extending to the use of MRM jars in javac as well.
-- Jon
On 05/20/2016 08:55 AM, Chris Hegarty wrote:
What do you get if you mix JEP 261 [1] with JEP
On 05/16/2016 12:36 PM, Mandy Chung wrote:
>For tests then Jon will be pushing the updated MineField to jdk9/dev soon. We
need to go over the new options and get javac and the runtime consistent. I think
we want it so that empty elements in the new options are ignored, leaving class
path
On 05/11/2016 11:53 AM, fo...@univ-mlv.fr wrote:
I also want to gather experience on the bytecode representation,
BTW, the current format has a bug, encoding the name of a module as a part of
the class name fell like a hack. It is a bad idea because the JVM Spec doesn't
allow some characters
There is potentially a separate discussion here, as to whether javac
should "force" the provision of a jar-fs provider.
Strictly speaking, javac does not inherently require it. You can use
javac just fine, with files in the system image, and source and class
files in the default file system.
Changeset: 03c7fca7d128
Author:jjg
Date: 2016-04-19 15:11 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/03c7fca7d128
fix inappropriate use of javadoc-style comments
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java
SOURCE_PATH is normally a package-oriented (JDK-8 style) path. It's not
a module-oriented path, so generally, you won't find modules on it.
You probably want to use MODULE_SOURCE_PATH.
-- Jon
On 07/26/2016 06:59 AM, Konstantin Barzilovich wrote:
Hello,
I try to use method
Changeset: f5581208bbd2
Author:jjg
Date: 2016-07-12 13:51 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f5581208bbd2
update options for javac, javadoc
! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java
!
Changeset: b7ce08828bfc
Author:jjg
Date: 2016-07-14 15:28 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b7ce08828bfc
update javadoc usage messages for --release
!
src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties
!
Changeset: 4b0b87edac75
Author:jjg
Date: 2016-07-22 14:14 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4b0b87edac75
update and standardize javap output for Module attribute
! src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java
If your module is in source form, then you have two choices:
1. put the contents of the module directly on the SOURCE_PATH, as a
hierarchy of packages and types, with module-info.java in the root of
that hierarchy. by contrast with using MODULE_SOURCE_PATH, (described
next), there should not
Changeset: 078fb7cea81c
Author:anazarov
Date: 2016-07-29 19:53 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/078fb7cea81c
8162713: Develop new tests for "export dynamic" feature
! test/tools/javac/classfiles/attributes/Module/ModuleTest.java
!
Changeset: eff836b97514
Author:anazarov
Date: 2016-07-27 15:14 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/eff836b97514
8161906: Develop tests for "requires static" feature
! test/tools/javac/classfiles/attributes/Module/ModuleTest.java
!
Changeset: 8150eeaf8c24
Author:vromero
Date: 2016-07-27 07:07 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8150eeaf8c24
8161277: javax.lang.model.util.Types.isSameType(...) returns true on wildcards
Reviewed-by: mcimadamore
!
Noted. Thanks for the report.
-- Jon
On 07/11/2016 12:24 PM, Paul Benedict wrote:
Error from the command line:
src\com.domain2\module-info.java:2: error: module not found: com.domain1
requires com.domain1;
^
If you can't see this message in fixed-width font, please note
On 08/08/2016 03:02 PM, Mandy Chung wrote:
>In javap.properties then there is a typo in "instead whitespace" (missing "of"). Also probably
best to say a "file URL" instead of "URL" as I don't think it accepts an arbitrary URL.
>
Fixed.
Please unfix.
For a couple of releases, javap has
On 08/09/2016 06:12 AM, Jan Lahoda wrote:
I took a pass through langtools changes. Overall seems OK to me. Some
minor comments:
-src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java:
commented-out code in hasArg(). (Some more in Option.ArgKind, but that
seems mostly OK.)
Changeset: 9f8da995da88
Author:vromero
Date: 2016-07-19 11:27 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9f8da995da88
8161383: javac is looking for operator symbols at the wrong place
Reviewed-by: mcimadamore
!
The test can also report which providers it is testing and/or skipping,
so that anyone checking the .jtr file can verify the behavior.
Maybe it fails if expected modules or providers are not found.
-- Jon
On 06/29/2016 10:50 AM, Mandy Chung wrote:
Valerie’s suggestion is a good one. The
FWIW, I think javac also deserves some amount of similar work.
-- Jon
On 02/01/2017 01:49 PM, Nicolai Parlog wrote:
Hi Alan,
`-Xdiag:resolver` is awesome! :) I think these messages are great
candidates for info-level messages with the "modules" tag via unified
logging.
Something else I
On 01/31/2017 01:45 AM, Andrew Dinn wrote:
Hi Jonathan,
On 31/01/17 00:05, Jonathan Gibbons wrote:
From the command-line help, the relevant new options are the following:
. . .
The good news is that you can use the existing simple options, which are
now
internally defined in terms of those
Stephan, Rémi, et al,
Yes, we need to better document the @SuppressWarnings and lint options
accepted by javac.
At least part of the problem is that we don't have a good place to write
such documentation/specification. We are working on that too.
-- Jon
On 1/22/17 8:21 AM, Stephan
ke for Java 9?
best,
Stephan
On 01/22/2017 07:00 PM, Jonathan Gibbons wrote:
Stephan, Rémi, et al,
Yes, we need to better document the @SuppressWarnings and lint
options accepted by javac.
At least part of the problem is that we don't have a good place to
write such documentation/specifica
Hi Rémi,
On 1/21/17 1:22 AM, Remi Forax wrote:
For the JDK, there are several kind of modules from a doc perspective,
we have root modules that are available by default, like java.base,
we have implementation modules, those that starts with jdk like jdk.jshell,
and we have modules that are not
Nicolai,
I don't think this proposal is a good way to go. If nothing else, it would
require all the module-specific output directories to be created ahead
of time, so that javac can determine which ones to use, which would
require additional setup commands to be executed after a "make clean"
or
e desirable.
-- Jon
On 25.01.2017 23:50, Jonathan Gibbons wrote:
Stephan,
There will be many cases where one project contains one module and
for those cases, the single module mode compilation will be
sufficient and bears the most similarity to the way people
organize their project today.
At the ot
Previously, in JDK 8 and before, javac would use the runtime
bootclasspath if there was explicit setting for the compilation
bootclasspath.
Now, in 9, there is no sense of a bootclasspath, since it has been
superseded by modules and the module graph. But even so, it is
reasonable to ask the
Nicolai,
The simple answer is "Yes, there will be an easy way to generate
documentation based on accessibility",
and "yes, the javadoc tool is module aware".
We've added new options that generalize the existing simple options, so
that you can have detailed
control if you really need it, but
I see the command line help text has not been updated for the existing
simple options. That is a bug.
-- Jon
On 01/30/2017 04:05 PM, Jonathan Gibbons wrote:
Nicolai,
The simple answer is "Yes, there will be an easy way to generate
documentation based on accessibility",
en to a common tree
specified by -d.
This is just a thought.
Regards, Peter
On 26.01.2017 19:15, Jonathan Gibbons wrote:
On 1/26/17 6:30 AM, Nicolai Parlog wrote:
Hi,
I see that this feature is unlikely to be in Java 9 ;) , but I
want to give it one last push before conceding:
Comparing the
omplementary to -d option. When a module it
not listed in the --module-output, its classes are written to a common
tree specified by -d.
This is just a thought.
Regards, Peter
On 26.01.2017 19:15, Jonathan Gibbons wrote:
On 1/26/17 6:30 AM, Nicolai Parlog wrote:
Hi,
I see that this featur
o consider multi-module builds after all?
thanks,
Stephan
On 01/25/2017 07:38 PM, Jonathan Gibbons wrote:
On 1/25/17 12:20 AM, Nicolai Parlog wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi Jonathan,
thanks for considering this.
If nothing else, it would require all the modu
- Jon
so long ... Nicolai
On 23.01.2017 20:51, Jonathan Gibbons wrote:
Nicolai,
I don't think this proposal is a good way to go. If nothing else,
it would require all the module-specific output directories to be
created ahead of time, so that javac can determine which ones to
use, which
On 2/9/17 3:07 PM, Alex Buckley wrote:
All the JLS wants is for the class to be 'public'.
Alex:
Does that just apply locally to the declaration of the class itself, or
does it also indirectly apply to any enclosing classes, in the case of a
nested class?
-- Jon
Peter,
The circumstances of the analysis of service providers are very
different to the normal JLS rules regarding visibility and accessibility
of named items.
I know that we have some cleanup to do, for javac to "catch up" with the
latest updates to JLS, especially with regards to the
Changeset: 0f8b6aba6279
Author:ksrini
Date: 2016-08-09 07:31 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0f8b6aba6279
8075529: Documentation in DocumentationTool.getTask(...) should mention about
"null" parameter for doclet.
Reviewed-by: jjg
!
If the annotation processor is trying to execute code in that module,
you may want -J--add-modules=java.xml.bind to add the module to the
javac runtime environment, as compared to the compilation environment
-- Jon
On 10/4/16 11:48 AM, Stephen Felts wrote:
In JDK9, the java.xml.bind module
Langtools change looks good,
-- Jon
On 09/30/2016 09:29 PM, Mandy Chung wrote:
Jon points out that javac should also be updated. javac currently opens the
JMOD file with JarFileSystem. Jon and I discussed this and we agree to keep
the current workaround for now and add the validation to
On 09/20/2016 07:49 AM, Alan Bateman wrote:
On 20/09/2016 06:43, Stephen Colebourne wrote:
Just to note that the report below is mostly about the confusing error
message, something which users will get if they write "wek" instead of
"weak".
Understood, I'm sure Jon or Jan will comment on
On 08/18/2016 05:17 AM, Alan Bateman wrote:
On 11/08/2016 05:50, Jayaprakash Arthanareeswaran wrote:
Hi Alan,
I also need a clarification on the following passage in JEP 261:
/"In large systems the source code for a particular module may be
spread across several different directories. In the
Looks good to me.
-- Jon
On 08/26/2016 04:06 PM, Mandy Chung wrote:
This patch removes the old module options from java, javac, javadoc, etc. The
new options are in jdk-9+132 [1]. I did a scan on the jdk9/dev forest to
replace any remaining reference to the old options. I find some tests
Changeset: d3dde3f775b8
Author:jlahoda
Date: 2016-11-02 16:48 +0100
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d3dde3f775b8
8166538: Improve error reporting for compiling against unexported package
Summary: When a type cannot be found, look into other modules, search
Changeset: 9d791b717b5c
Author:jjg
Date: 2016-10-19 13:58 -0700
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9d791b717b5c
fix 'requires public' in diagnostic to 'requires transitive'
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java
!
Currently, the compiler expects sources on a source path (i.e.
--source-path) to be organized in a specific hierarchy corresponding to
packages and classes. For the module source path, this is extended to
include the enclosing module. Although we experimented with requiring
the module
Changeset: ea87091ceefc
Author:jjg
Date: 2016-11-22 18:18 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ea87091ceefc
remove support for old-style Module attribute
! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
!
Changeset: 51f0bf95d616
Author:jjg
Date: 2016-11-22 18:42 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/51f0bf95d616
Add classfile Module_attribute.OPensEntry
! src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java
!
Changeset: 98a2842ec26a
Author:bpatel
Date: 2016-11-23 14:01 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/98a2842ec26a
8168766: javadoc should support deprecation on modules.
Reviewed-by: jjg
!
Changeset: 7678462efbc3
Author:bpatel
Date: 2016-11-23 15:29 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7678462efbc3
8159607: Update javadoc to support annotations on module-info.java
Reviewed-by: jjg
! test/jdk/javadoc/doclet/testModules/TestModules.java
!
Stéphan,
You say you are using com.sun.tools.javac.api.JavacTrees. Although that
class is not exported from jdk.compiler, it is an implementation of the
interface com.sun.source.util.Trees, which is exported. Is the
interface sufficient to your needs? If not, what methods are you calling?
On 11/28/16 3:28 AM, Maurizio Cimadamore wrote:
Hi,
the langtools code looks generally ok. Few questions:
* Why doesn't 'open' get its own directive in Directive.java - instead
of relying on a 'mode' set on an export directive?
I agree that "opens" leveraging a type named "Exports..." is
Changeset: ecda27ca1011
Author:jjg
Date: 2016-11-22 17:49 -0800
URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ecda27ca1011
fix 2 failing tests after Module attribute changes
! test/tools/javac/classfiles/attributes/Module/ModuleTestBase.java
!
On 11/16/2016 01:41 PM, Stephan Herrmann wrote:
At the end of the day we need full pattern matching right?
Not really, at least, not in javac.
Words like 'module', 'requires', etc are lexed as identifiers. When we
get to the point where the grammar would accept one of these words as a
On 11/16/2016 03:28 PM, Stephan Herrmann wrote:
On 11/17/2016 12:10 AM, Alex Buckley wrote:
On 11/16/2016 3:03 PM, Stephan Herrmann wrote:
On 11/16/2016 11:57 PM, Alex Buckley wrote:
On 11/16/2016 2:26 PM, Stephan Herrmann wrote:
And we may safely assume regularity of the grammar, i.e.,
On 11/16/2016 02:08 PM, Stephan Herrmann wrote:
On 11/16/2016 10:02 PM, Alex Buckley wrote:
- If you lex 'package', then the sequence must parse as the first
alternative.
- If you don't lex 'package', but rather lex 'import', then parsing
is ambiguous until you've looked ahead to lex either
On 11/16/2016 02:34 PM, Stephan Herrmann wrote:
On 11/16/2016 11:19 PM, Jonathan Gibbons wrote:
On 11/16/2016 02:08 PM, Stephan Herrmann wrote:
On 11/16/2016 10:02 PM, Alex Buckley wrote:
- If you lex 'package', then the sequence must parse as the first
alternative.
- If you don't lex
On 11/16/2016 02:26 PM, Stephan Herrmann wrote:
On 11/16/2016 11:01 PM, Jonathan Gibbons wrote:
On 11/16/2016 01:41 PM, Stephan Herrmann wrote:
At the end of the day we need full pattern matching right?
Not really, at least, not in javac.
Words like 'module', 'requires', etc are lexed
On 11/16/2016 02:55 PM, Stephan Herrmann wrote:
On 11/16/2016 11:35 PM, Jonathan Gibbons wrote:
On 11/16/2016 02:26 PM, Stephan Herrmann wrote:
Still no good news for tools wishing to process just a fragment of
the text.
Just how small a fragment, and in how unknown a context are you
On 11/20/16 3:39 PM, Eirik Bjørsnøs wrote:
Turns out that:
a) Maven treats -J arguments in a special way which hides them from the
debug log, but they're still passed on to javac
b) Maven parses the javac output for error messages, but drops any output
not following the javac output format.
101 - 200 of 260 matches
Mail list logo
