Review request 8152508: tools/jlink/SecurityTest.java failed intermittently

This test deserves some cleanup and I suspect the intermittent failure may be related to running in agent mode. Mandy diff --git a/test/tools/jlink/SecurityTest.java b/test/tools/jlink/SecurityTest.java --- a/test/tools/jlink/SecurityTest.java +++ b/test/tools/jlink/SecurityTest.java @@ -25,7

Review Request 8152197: Single place to specify module-specific information for images build

Erik, This cleans up several makefiles and now have one single file (make/common/Modules.gmk) to specify the module-specific information for the build: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152197/webrev.00/index.html Mandy

Re: Review Request 8152197: Single place to specify module-specific information for images build

can see if I can modify this to have the calculation done lazily or at > least only on demand. > > /Erik > > On 2016-03-22 01:42, Mandy Chung wrote: >>> On Mar 21, 2016, at 5:36 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >>> >>>> On Mar 21, 2016, at

hg: jigsaw/m3/nashorn: 8142968: Module System implementation

Changeset: 133ea8746b37 Author:alanb Date: 2016-03-17 19:04 + URL: http://hg.openjdk.java.net/jigsaw/m3/nashorn/rev/133ea8746b37 8142968: Module System implementation Summary: Initial integration of JEP 200, JEP 260, JEP 261, and JEP 282 Reviewed-by: mhaupt, hannesw

hg: jigsaw/jake/jdk: Rename classes with "Installed" prefix to "System" consistent with ModuleFinder::ofSystem

Changeset: 0d7ba0a49fe3 Author:mchung Date: 2016-03-16 13:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0d7ba0a49fe3 Rename classes with "Installed" prefix to "System" consistent with ModuleFinder::ofSystem -

hg: jigsaw/jake/jdk: ProblemList JImageTest.java on 32-bit build only

Changeset: d2d136698413 Author:mchung Date: 2016-03-16 10:22 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d2d136698413 ProblemList JImageTest.java on 32-bit build only ! test/ProblemList.txt

hg: jigsaw/jake/jdk: Minor clean up on test module dependences

Changeset: be591147fb87 Author:shurailine Date: 2016-03-03 16:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/be591147fb87 Minor clean up on test module dependences ! test/java/lang/Class/GetModuleTest.java ! test/java/lang/management/MemoryMXBean/PendingAllGC.sh

Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module

jdk9-dev is not the right mailing list. I bcc’ed it and add jigsaw-dev instead. > On Mar 3, 2016, at 3:57 PM, Kevin Rushforth > wrote: > > Looks OK to me. I did a quick test build and I can see the new package in the > exploded JDK, but not in the images. Maybe I

Re: -XaddExports: not recognized in JavaVMInitArgs on Windows

> On Mar 3, 2016, at 2:49 PM, Keimpe Bronkhorst > wrote: > > I'm using build 9-ea+107-jigsaw-nightly-h4560-20160301 on Windows. > > I'm executing my program through jvm.dll using JavaVMInitArgs and JNI. I set > JavaVMInitArgs.ignoreUnrecognized = JNI_FALSE and

hg: jigsaw/jake/langtools: Test cleanup to add @modules

Changeset: c1a5259e9c75 Author:mchung Date: 2016-03-03 17:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/c1a5259e9c75 Test cleanup to add @modules ! test/jdk/jshell/InferTypeTest.java

hg: jigsaw/jake/jdk: Minor cleanup to ResourceBundle::getBundle security permission

Changeset: 9f33d93c2a13 Author:mchung Date: 2016-03-06 21:30 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9f33d93c2a13 Minor cleanup to ResourceBundle::getBundle security permission ! src/java.base/share/classes/java/util/ResourceBundle.java !

hg: jigsaw/jake/jdk: clean up stale requires and qualified exports

Changeset: 4fae0f1cf1eb Author:mchung Date: 2016-03-01 18:04 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4fae0f1cf1eb clean up stale requires and qualified exports ! src/java.base/share/classes/module-info.java ! src/java.desktop/share/classes/module-info.java !

hg: jigsaw/jake/jdk: Revert uses of addReads in java.management module

Changeset: b3204d802108 Author:mchung Date: 2016-03-02 11:39 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b3204d802108 Revert uses of addReads in java.management module ! src/java.management/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java !

hg: jigsaw/jake/jaxws: Revert uses of addReads in jaxws/jaxb/jaf modules

Changeset: 1bb1addef965 Author:mchung Date: 2016-03-02 13:06 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/1bb1addef965 Revert uses of addReads in jaxws/jaxb/jaf modules ! src/java.activation/share/classes/javax/activation/MailcapCommandMap.java !

hg: jigsaw/jake/nashorn: Remove legacy service config file

Changeset: e172426fb366 Author:mchung Date: 2016-03-02 15:45 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/e172426fb366 Remove legacy service config file - src/jdk.scripting.nashorn/share/classes/META-INF/MANIFEST.MF -

hg: jigsaw/jake/jdk: new tests to verify permission check for Class::forName

Changeset: c919c57d5640 Author:mchung Date: 2016-03-02 15:32 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c919c57d5640 new tests to verify permission check for Class::forName ! src/java.base/share/classes/java/lang/Class.java !

hg: jigsaw/jake/jdk: Remove legacy service config file

Changeset: 8b5e89db9f26 Author:mchung Date: 2016-03-02 15:45 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/8b5e89db9f26 Remove legacy service config file - src/java.base/share/classes/META-INF/services/java.nio.file.spi.FileSystemProvider

hg: jigsaw/jake/jdk: Restore service config file for jrtfs.jar

Changeset: c47be843032b Author:mchung Date: 2016-03-02 16:50 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c47be843032b Restore service config file for jrtfs.jar + src/java.base/share/classes/META-INF/services/java.nio.file.spi.FileSystemProvider

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

> On Mar 2, 2016, at 2:48 PM, Alexandre (Shura) Iline > <alexandre.il...@oracle.com> wrote: > > >> On Mar 2, 2016, at 2:03 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> >>> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline &g

hg: jigsaw/jake/jaxws: Minor cleanup

Changeset: c5206a2a4c9f Author:mchung Date: 2016-03-02 13:54 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/c5206a2a4c9f Minor cleanup ! src/java.xml.bind/share/classes/com/sun/xml/internal/bind/v2/runtime/ElementBeanInfoImpl.java !

Re: RFR: JDK-8150998: Fix module dependences in java/lang tests

> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline > wrote: > > http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/ test/java/lang/instrument/MakeJAR2.sh -XaddExports should not be brought to jdk9.

hg: jigsaw/jake/langtools: 16 new changesets

Changeset: 3cdfbbdb6f61 Author:vromero Date: 2016-02-22 16:17 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/3cdfbbdb6f61 8149600: javac, remove unused options, step 2 Reviewed-by: jjg, mcimadamore !

hg: jigsaw/jake/nashorn: 6 new changesets

Changeset: 93854b0b5e5e Author:sundar Date: 2016-02-25 13:56 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/93854b0b5e5e 8148379: jdk.nashorn.api.scripting spec. adjustments, clarifications Reviewed-by: hannesw, mhaupt ! make/build.xml ! make/project.properties !

hg: jigsaw/jake/corba: 2 new changesets

Changeset: b75afa17aefe Author:lana Date: 2016-03-03 12:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/b75afa17aefe Added tag jdk-9+108 for changeset 84f2862a25eb ! .hgtags Changeset: 9ba71f9ac61d Author:mchung Date: 2016-03-03 12:37 -0800 URL:

hg: jigsaw/jake/jaxp: 6 new changesets

Changeset: 95c223e6eaf0 Author:joehw Date: 2016-02-22 11:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/95c223e6eaf0 8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE Reviewed-by: joehw Contributed-by: christoph.lan...@sap.com

hg: jigsaw/jake/jaxws: 2 new changesets

Changeset: a4c1ffe5fdec Author:lana Date: 2016-03-03 12:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/a4c1ffe5fdec Added tag jdk-9+108 for changeset 513eb2e432f6 ! .hgtags Changeset: 364f3dc30f72 Author:mchung Date: 2016-03-03 12:37 -0800 URL:

hg: jigsaw/jake/hotspot: Fix merge issue for JDK-8144996 and JDK-8067194

Changeset: c7d5a9549f3b Author:mchung Date: 2016-03-07 13:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c7d5a9549f3b Fix merge issue for JDK-8144996 and JDK-8067194 - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegionSetCount.java

hg: jigsaw/jake: Add --disable-keep-packaged-modules configure option

Changeset: 6fa251220992 Author:mchung Date: 2016-03-04 14:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/6fa251220992 Add --disable-keep-packaged-modules configure option ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh !

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: be44e8eac21b Author:mchung Date: 2016-03-08 14:38 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/be44e8eac21b java.management review comment ! src/java.management/share/classes/sun/management/ThreadInfoCompositeData.java Changeset: 21b6a9c4195c Author:

Re: RFR: 8152641: Plugin to generate BMH$Species classes ahead-of-time

> On Apr 1, 2016, at 5:32 AM, Claes Redestad wrote: > > http://cr.openjdk.java.net/~redestad/8152641/webrev.06/ > Looks good except the new test with 2015 copyright start year. > > [1] Mandy filed https://bugs.openjdk.java.net/browse/JDK-8153238 to improve > this

Re: RFR: 8152704: jlink command line output/help message improvement

> On Mar 29, 2016, at 2:25 PM, Naoto Sato wrote: > > Hello, > > Please review the changes for the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8152704 > > The suggested change is located at: > > http://cr.openjdk.java.net/~naoto/8152704/webrev.01/

Re: RFR: 8152641: Plugin to generate BMH$Species classes ahead-of-time

> On Mar 29, 2016, at 4:03 PM, Claes Redestad wrote: > > Mandy: I've not found any test (under jdk/test/tools/jlink or elsewhere) which > has to be updated when adding a plugin like this. jdk/test/tools/jlink/JLinkTest.java This is the one I recalled. This is in

Review request 8153211: Convert build tool to use the new -XaddExports syntax in bootcycle build

A few build tools are using the old -XaddExports syntax that should switch to the new syntax: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153211/webrev.00/ Mandy

Re: Review request 8153211: Convert build tool to use the new -XaddExports syntax in bootcycle build

> On Mar 31, 2016, at 10:06 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > On 31/03/2016 17:56, Mandy Chung wrote: >> A few build tools are using the old -XaddExports syntax that should switch >> to the new syntax: >> http://cr.openjdk.java.net/~m

hg: jigsaw/jake/jdk: 3 new changesets

Changeset: 20ec0c69d3e2 Author:mchung Date: 2016-03-31 11:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/20ec0c69d3e2 8153125: rmic from bootcycle build should launch with -m jdk.rmic/sun.rmi.rmic.Main Reviewed-by: alanb, erikj ! make/rmic/RmicCommon.gmk Changeset:

hg: jigsaw/jake/nashorn: 8153211: Convert build tool to use the new -XaddExports syntax in bootcycle build

Changeset: 38fb8799f2c1 Author:mchung Date: 2016-03-31 11:50 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/38fb8799f2c1 8153211: Convert build tool to use the new -XaddExports syntax in bootcycle build Reviewed-by: alanb ! make/BuildNashorn.gmk

Re: RFR: 8152641: Plugin to generate BMH$Species classes ahead-of-time

> On Mar 30, 2016, at 9:17 AM, Claes Redestad wrote: > > Hi Peter, > > something like this, then: > > http://cr.openjdk.java.net/~redestad/8152641/webrev.05/ > BoundMethodHandle::generateConcreteBMHClassBytes It only allows “LIJFD” characters. But the default

Re: RFR: 8152641: Plugin to generate BMH$Species classes ahead-of-time

> On Mar 31, 2016, at 4:10 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Mar 30, 2016, at 9:17 AM, Claes Redestad <claes.redes...@oracle.com> >> wrote: >> >> Hi Peter, >> >> something like this, then: >

Re: RFR 8152742: jlink --include-locales th fails with ArrayIndexOutOfBoundsException

> On Apr 1, 2016, at 2:20 PM, Naoto Sato wrote: > > Hello, > > Please review the fix for the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8152742 > > The fix is located at: > > http://cr.openjdk.java.net/~naoto/8152742/webrev.00/ Looks okay to me.

Re: 8153370: Drop use of old style -XaddExports from tests

> On Apr 4, 2016, at 6:38 AM, Alan Bateman wrote: > > > We still have support in both javac and in the runtime for the old form of > -XaddExports and -XaddReads. > > A first step to removing support for the old form is to update the tests that > are still using the

Re: RFR 8136645: jlink tool should create windows os compatible launcher

> On Mar 31, 2016, at 9:20 PM, Sundararajan Athijegannathan > wrote: > > Please review the updated webrev @ > http://cr.openjdk.java.net/~sundar/8136645/webrev.02/ This version still generates .bat for all platforms as opposed to generate it for

Re: RFR 8136645: jlink tool should create windows os compatible launcher

oo. i.e., existing code generates shell > scripts on Windows too (although those shell scripts seem to run fine > under Cygwin). > > Do you think we should filter out? Cross-platform image generation scenario? > > -Sundar > > On 4/1/2016 10:54 AM, Mandy Chung wrote: >

Re: RFR: JDK-8069079 - jimage extract / list to organize classes by modules

Hi Jim, > On Apr 22, 2016, at 6:12 AM, Jim Laskey (Oracle) > wrote: > > Listing is by module, extract has been by module for some time. > > http://cr.openjdk.java.net/~jlaskey/8069079/webrev/index.html >

Re: JDK-8150990: [packager] Research Refactoring Packager

> On Apr 27, 2016, at 11:51 AM, Chris Bensen wrote: > > http://cr.openjdk.java.net/~cbensen/JDK-8150990/webrev.00/ This looks okay to me. This is an interim solution to greatly simplify FX coordination with jlink API change during jdk9 development. I can sponsor it

hg: jigsaw/jake/jdk: Exclude modules from hashes if their dependences are excluded

Changeset: 930fcc6b74c8 Author:mchung Date: 2016-04-29 18:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/930fcc6b74c8 Exclude modules from hashes if their dependences are excluded ! src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java

Re: 8154956: Module system implementation refresh (4/2016)

> On Apr 29, 2016, at 5:38 AM, Alan Bateman wrote: > > The webrevs, all repos are here: > http://cr.openjdk.java.net/~alanb/8154956/1/ I reviewed all repos except hotspot. Looks good in general. Minor comments: Configuration.java Nit: line 361-364 there is an

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: 46eb23a3b233 Author:mchung Date: 2016-04-30 16:29 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/46eb23a3b233 hash modules should be filtered after the candidate modules are found ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java !

Re: 8157598: ModuleReader find returns incorrect URI when modular JAR is a multi-release JAR

> On May 23, 2016, at 9:49 AM, Alan Bateman wrote: > > > JDK-8151542 changed the URL scheme for resources in the versioned section of > a multi-release JAR. The ModuleReader API can be used to get a URI to a > resource in a modular JAR and it needs a corresponding

Re: Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.01/index.html Mandy

Re: Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

> On May 18, 2016, at 11:27 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 19/05/2016 02:41, Mandy Chung wrote: >> Webrev at: >> >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.00/index.html >> >> This is to allow to p

Re: Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

> On May 19, 2016, at 9:19 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > On 19/05/2016 15:48, Mandy Chung wrote: >> Updated webrev: >> >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.01/index.html >> >> Mandy &g

Review request: 8157068 ExceptionInInitializerError if images build patched to use exploded version of java.lang.module.SystemModules

Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157068/webrev.00/index.html This is to allow to patch java.base with an exploded image for JDK development purpose like this: $ images/jdk/bin/java -Xpatch:java.base=jdk/modules/java.base -version jdk.internal.module.SystemModules

Re: RFR 8156497: Add jar tool support for Multi-release modular JARs

> On May 23, 2016, at 8:05 AM, Chris Hegarty wrote: > > Updated webrev: > http://cr.openjdk.java.net/~chegar/8156497.01/ Looks fine to me. Minor comment on the test, “9” is hardcoded in a few places. It might be good to prepare for the future release e.g. use

Re: 8152650: ModuleFinder.compose should accept varargs

> On May 20, 2016, at 1:57 PM, Alan Bateman wrote: > > > There are several patches that didn't go in with the last update, the change > to ModuleFinder.compose to use varargs was one of them. The other part to > this is removing the empty() method as it is redundant.

Re: RFR: 8155993: Some tests in java/lang/management fail with NCDFE: com/sun/management/internal/GarbageCollectorExtImpl

> On May 10, 2016, at 12:00 PM, Alexandre (Shura) Iline > wrote: > > Hi. > > Please review the fix: > http://cr.openjdk.java.net/~shurailine/8155993/webrev.00/ > > In the failing tests I have replaced java.management with jdk.management in > @modules. > >

Re: RFR: 8155993: Some tests in java/lang/management fail with NCDFE: com/sun/management/internal/GarbageCollectorExtImpl

> On May 10, 2016, at 1:03 PM, Alexandre (Shura) Iline > wrote: > > OK, I will do that, Mandy. > > Should I create a separate bug (subtask) for this test fixes? Create a new bug is good. Send me a committed changeset and I can push it for you. Mandy

Re: RFR: JDK-8155237 - jlink plugin to order resources should take a class list as input

> On May 9, 2016, at 10:41 AM, Jim Laskey (Oracle) > wrote: > > Modifies the jlink sort-plugin to accept a classlist to order files in the > jimage. > > http://cr.openjdk.java.net/~jlaskey/8155237/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8155237

Re: RFR: 8155993: Some tests in java/lang/management fail with NCDFE: com/sun/management/internal/GarbageCollectorExtImpl

> On May 10, 2016, at 12:49 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On May 10, 2016, at 12:00 PM, Alexandre (Shura) Iline >> <alexandre.il...@oracle.com> wrote: >> >> Hi. >> >> Please review the fix: >> http:/

Re: 8156989: Trailing empty element in classpath ignored

> On May 16, 2016, at 11:53 AM, Alan Bateman wrote: > > > Martin's MineField test has been excluded for some time, one reason is that > it exercised -Xbootclasspath/p and so doesn't work with JDK 9. Jon is > cleaning up this test via JDK-8156989 and lo behold, it

Re: RFR 8156914: jlink API minor cleanups

> On May 13, 2016, at 1:20 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8156914/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8156914 > This patch looks okay. The renamed

Re: RFR: JDK-8156781 - change to jlink has result in test failure

> On May 11, 2016, at 11:00 AM, Jim Laskey (Oracle) > wrote: > > http://cr.openjdk.java.net/~jlaskey/8156781/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8156781 Looks okay. Since the plugin is renamed to OrderResourcesPlugin, maybe good to rename it

hg: jigsaw/jake: Fix typos

Changeset: b3c829a18448 Author:mchung Date: 2016-04-29 13:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/b3c829a18448 Fix typos ! make/common/Modules.gmk

Re: RFR 8154182: Fix java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java to only use available modules

e”. It did not make it more effective, you are right about that. > > Thanks for the tip on “/modules”. > > Please take a look. > > Shura > >> On May 4, 2016, at 1:07 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> >>> On Apr 13, 2

Re: RFR 8154182: Fix java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java to only use available modules

> On May 5, 2016, at 1:09 PM, Alexandre (Shura) Iline > wrote: > > http://cr.openjdk.java.net/~shurailine/8154182/webrev.01/ Pushed. I took the liberty to take out the extra-whitespace and rename the variable from x to p. Mandy

Re: RFR 8154182: Fix java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java to only use available modules

> On Apr 13, 2016, at 10:29 AM, Alexandre (Shura) Iline > wrote: > > Hi, > > Could you be so kind to take a look on this fix: > http://cr.openjdk.java.net/~shurailine/8154182/webrev.00/ Looks okay. Some suggestion: You only need to walk one root: root =

Re: RFR: JDK-8151914 java/util/jar/JarFile/MultiReleaseJar* tests do not declare module dependences

> On May 2, 2016, at 1:03 PM, Alexandre (Shura) Iline > wrote: > > Hi, > > Can you please take a look on: > http://cr.openjdk.java.net/~shurailine/8151914/webrev.01/ > ? Looks okay to me. Mandy

Re: [9] Review request: 8153872: Nashorn no longer needs access to com.sun.javafx.application

> On Apr 19, 2016, at 8:25 AM, Kevin Rushforth > wrote: > > Jim, > > Please review the following fix: > > https://bugs.openjdk.java.net/browse/JDK-8153872 > http://cr.openjdk.java.net/~kcr/8153872/webrev.00/ > > This is a simple backout of the earlier fix for

Re: Review request 8136930: Simplify use of module-system options by custom launchers

ine > <alexandre.il...@oracle.com> wrote: > > Hi, Mandy. > > Could you help to identify what tests in the JTreg suite(s) require more work > to switch to the new options? > > Or the other way around: which tests have been fixed with this commit? > > Thank you. > >

Re: Review request 8136930: Simplify use of module-system options by custom launchers

e of those testing cycle. This will ensure that the tests are correctly updated. We have verified the pit and hotspot tests. Note that the old options continue to work. Testing won’t find any tests needed to be converted to use new options, if that’s what you intend to find. >>

hg: jigsaw/jake/jdk: 176 new changesets

Changeset: cfa705d1f4e2 Author:naoto Date: 2016-07-26 10:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cfa705d1f4e2 8162343: non-ASCII characters in source code comments (.hpp) Reviewed-by: rriggs ! src/java.base/share/native/libjimage/imageDecompressor.hpp !

hg: jigsaw/jake/nashorn: 9 new changesets

Changeset: 9d87093a1a97 Author:sdama Date: 2016-07-27 15:53 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/9d87093a1a97 8160801: add documentation for NativeString Reviewed-by: mhaupt !

hg: jigsaw/jake/jaxp: 11 new changesets

Changeset: 794a2f7c2bb6 Author:snikandrova Date: 2016-07-27 18:23 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/794a2f7c2bb6 8021787: javax.xml.datatype.XMLGregorianCalendar.getMonth() return is documented wrong Reviewed-by: joehw, rriggs !

hg: jigsaw/jake: 40 new changesets

Changeset: 03e2c69ce64a Author:valeriep Date: 2016-07-27 01:26 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/03e2c69ce64a 8159488: Deprivilege java.xml.crypto Summary: Moved java.xml.crypto module from boot modules to platform modules Reviewed-by: mullan !

hg: jigsaw/jake/corba: 3 new changesets

Changeset: f7e1d5337c2e Author:amurillo Date: 2016-08-04 17:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/f7e1d5337c2e Added tag jdk-9+130 for changeset 77f9692d5976 ! .hgtags Changeset: 1ab4b9399c4c Author:lana Date: 2016-08-11 15:47 + URL:

hg: jigsaw/jake/jaxws: 4 new changesets

Changeset: 9df85348a932 Author:amurillo Date: 2016-08-04 17:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/9df85348a932 Added tag jdk-9+130 for changeset 39c6293131d9 ! .hgtags Changeset: 783e7e2c587f Author:rriggs Date: 2016-08-08 10:15 -0400 URL:

Re: Review request: JDK-8159596 Add java --dry-run

e the "else" block for a real run > only? I think if the dry run also throws an exception, you should set the > exit code to 1. If I read the diff wrong, my apologies :-) > > Cheers, > Paul > > On Mon, Jun 27, 2016 at 12:36 PM, Mandy Chung <mandy.ch...@oracle.com>

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

> On Jul 5, 2016, at 12:42 PM, Alexandre (Shura) Iline > wrote: > > This made sense, than you, Mandy. > > Please review new version: > http://cr.openjdk.java.net/~shurailine/8158670/webrev.02/ You can use Layer::findModule instead of Configuration::findModule.

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

> On Jul 5, 2016, at 1:53 PM, Alexandre (Shura) Iline > <alexandre.il...@oracle.com> wrote: > > >> On Jul 5, 2016, at 1:36 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> >>> On Jul 5, 2016, at 12:42 PM, Alexandre (S

Re: RFR 8161055: Remove plugin ordering by isAfter, isBefore.

> On Jul 8, 2016, at 4:19 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8161055/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8161055 +1 It’s good to see the plugin API being cleaned up.

Re: Questions on deprivileging a module

> On Jul 5, 2016, at 12:15 AM, Wang Weijun wrote: > >>> 1. How does updating /make/common/Modules.gmk affect an exploded build? >> The mappings are used for both exploded and images build so the >> configuration in this make file is for both. > > I see. BTW, which file

Re: Strange test failure when referencing a class in a deprivileged module

> On Jul 5, 2016, at 8:11 AM, Alan Bateman wrote: > > On 05/07/2016 09:22, Wang Weijun wrote: > >>> On Jul 5, 2016, at 11:53 AM, Wang Weijun wrote: >>> >>> The exception is at the end of this mail. The test passes if I change >>> X.go() to

Re: Review request: JDK-8159596 Add java --dry-run

> On Jul 3, 2016, at 9:30 AM, Peter Levart wrote: > > > ...OTOH the quasi-graphical tree display (the idea is stolen from "mvn > dependency:tree" command) has some additional useful info such as "uses of a > service that was not satisfied" and in my opinion better

Re: RFR 8163116: jlink exclude VM plugin does not fully support cross platform image creation

> On Aug 4, 2016, at 6:36 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8163116/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8163116 Looks fine and it’s right to use the os.name from

Review request 8136930: Simplify use of module-system options by custom launchers

This patch renames the module-system options to GNU-style as specified in JEP 293 [1] (see below for the new proposed option names). This addresses the problems discussed in [2] that the launcher will pass the module-system options down to the VM in the form of =. This provides a consistent way

Re: RFR 8159487: Add JAVA_VERSION, OS_NAME, OS_ARCH properties in release file

Hi Sundar, > On Aug 2, 2016, at 5:12 AM, Alan Bateman wrote: > > On 02/08/2016 04:39, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8159487/webrev.00/ for >> https://bugs.openjdk.java.net/browse/JDK-8159487 >> >> OS_NAME,

Re: Review request 8136930: Simplify use of module-system options by custom launchers

> On Aug 8, 2016, at 3:51 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 05/08/2016 21:11, Mandy Chung wrote: > >> This patch renames the module-system options to GNU-style as specified >> in JEP 293 [1] (see below for the new proposed option names).

Re: Review request 8136930: Simplify use of module-system options by custom launchers

Kumar, Thanks for the review. > On Aug 8, 2016, at 2:46 PM, Kumar Srinivasan > wrote: > > > I looked at the launcher specified changes, some minor > nits... > > jdk/src/java.base/share/native/libjli/java.c > > +def_len =

Re: ResourceBundleProvider(s) design

Hi Peter, Sorry for the delay in reply. Still catching up on mails from vacation. > On Aug 4, 2016, at 3:26 AM, Peter Levart wrote: > > > On 08/04/2016 11:21 AM, Peter Levart wrote: >> If the providing module declares the service type, then the consuming module >>

Re: Review request 8136930: Simplify use of module-system options by custom launchers

On Aug 8, 2016, at 3:57 AM, Sundararajan Athijegannathan wrote: > > Nashorn portion of the changes look fine - except for minor comment: > > $jdk9-dev/nashorn/buildtools/nasgen/build.properties > > needs to be fixed as well [uses -XaddExports] Fixed.

Re: Review request: JDK-8159596 Add java --dry-run

> On Jun 30, 2016, at 9:44 PM, David Holmes wrote: > > I had assumed that initialization was desirable as part of checking that > everything was specified correctly. If not then --dry-run would seem to do > very little compared to just running -version, and so doesn't

Re: Review request: JDK-8159596 Add java --dry-run

> On Jun 30, 2016, at 10:15 PM, David Holmes <david.hol...@oracle.com> wrote: > > On 1/07/2016 3:00 PM, Mandy Chung wrote: >> >>> On Jun 30, 2016, at 9:44 PM, David Holmes <david.hol...@oracle.com> wrote: >>> >>> I had assumed

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

hen we can leave out the platform-specific providers from the >>> @modules line and skip the providers if either the OS does not match or the >>> module is not present. >>> >>> If we can't query what modules are available, then we may have to think of >&g

Re: Review request: JDK-8159596 Add java --dry-run

> On Jul 1, 2016, at 12:48 AM, David Holmes wrote: > > Okay so back to my original statement - if all this does is ensure the main > class is found does it really carry its weight as a new argument? > Are you suggesting for java —-dry-run to run or not to load main

Re: Review request: JDK-8159596 Add java --dry-run

> On Jul 2, 2016, at 1:01 AM, David Holmes <david.hol...@oracle.com> wrote: > > On 2/07/2016 1:17 AM, Mandy Chung wrote: >> >>> On Jul 1, 2016, at 12:48 AM, David Holmes <david.hol...@oracle.com> wrote: >>> >>> Okay so back to my or

hg: jigsaw/jake/jaxws: 3 new changesets

Changeset: 5b0570e3db29 Author:dfuchs Date: 2016-06-24 16:00 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/5b0570e3db29 8150173: JAXBContext.newInstance causes PrivilegedActionException when createContext's declared in abstract class extended by discovered JAXB

hg: jigsaw/jake/jdk: 39 new changesets

Changeset: 59c4daf11af4 Author:bpb Date: 2016-06-20 14:08 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/59c4daf11af4 8136738: InputStream documentation for IOException in skip() is unclear or incorrect Summary: Clarify javadoc of skip(). Reviewed-by: rriggs, prappo !

hg: jigsaw/jake/corba: 4 new changesets

Changeset: 7514ad67e185 Author:msheppar Date: 2016-06-21 00:40 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/7514ad67e185 8146975: NullPointerException in IIOPInputStream.inputClassFields Reviewed-by: chegar, rriggs, coffeys !

hg: jigsaw/jake: 8 new changesets

Changeset: a420707436c6 Author:erikj Date: 2016-06-08 15:13 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/a420707436c6 8136771: Implement the license-swap logic as a make target Reviewed-by: tbell + make/CreateHgtipFiles.gmk ! make/GensrcModuleInfo.gmk ! make/Main.gmk !

hg: jigsaw/jake/jaxp: 2 new changesets

Changeset: 011b11d2aae2 Author:amurillo Date: 2016-06-30 22:10 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/011b11d2aae2 Added tag jdk-9+125 for changeset 493eb91ec32a ! .hgtags Changeset: bde9e53f9a92 Author:mchung Date: 2016-07-02 14:42 -0700 URL:

Re: Review request: JDK-8159596 Add java --dry-run

> On Jul 2, 2016, at 2:02 PM, Peter Levart wrote: > > What about extending the behavior of -version option so that when it is > specified together with other startup options like -mp, -m, -cp, MainClass, > ... it would behave just like --dry-run has been designed to

<    1   2   3   4   5   6   7   8   9   10   >