Re: RFR: 8201794: [Graal] fix regressions from JDK-8187490

2018-04-18 Thread Alan Bateman
On 18/04/2018 12:00, Doug Simon wrote: I've updated the webrev with a fix for another regression caused by JDK-8187490: --- old/test/jdk/jdk/modules/etc/UpgradeableModules.java2018-04-18 12:57:32.0 +0200 +++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java2018-04-18

Re: RFR: 8201794: [Graal] fix regressions from JDK-8187490

2018-04-18 Thread Doug Simon
> On 18 Apr 2018, at 13:23, mandy chung wrote: > > Looks okay. Have you run all jdk_core tests in addition to other hotspot > tests. I ran all open/test/jdk/jdk tests - is that what you mean? -Doug > On 4/18/18 7:00 PM, Doug Simon wrote: >> I've updated the webrev

Re: RFR: 8201794: [Graal] fix regressions from JDK-8187490

2018-04-18 Thread mandy chung
Looks okay.  Have you run all jdk_core tests in addition to other hotspot tests. Mandy On 4/18/18 7:00 PM, Doug Simon wrote: I've updated the webrev with a fix for another regression caused by JDK-8187490: --- old/test/jdk/jdk/modules/etc/UpgradeableModules.java2018-04-18

Re: RFR: 8201794: [Graal] fix regressions from JDK-8187490

2018-04-18 Thread Doug Simon
I've updated the webrev with a fix for another regression caused by JDK-8187490: --- old/test/jdk/jdk/modules/etc/UpgradeableModules.java2018-04-18 12:57:32.0 +0200 +++ new/test/jdk/jdk/modules/etc/UpgradeableModules.java2018-04-18 12:57:32.0 +0200 @@ -46,6 +46,7