Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

On 2017-02-15 22:08, Mandy Chung wrote: On Feb 15, 2017, at 12:27 PM, Daniel Fuchs wrote: Hi Mandy, Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.01/ Looks good. I haven't reviewed the build changes. I assume they're OK if you

Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

> On Feb 15, 2017, at 1:08 PM, Mandy Chung wrote: >> >>> Updated webrev: >>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.01/ You may be interested in the module graphs generated from this change.

Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

> On Feb 15, 2017, at 12:27 PM, Daniel Fuchs wrote: > > Hi Mandy, > > > Updated webrev: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.01/ > > Looks good. I haven't reviewed the build changes. > I assume they're OK if you managed to build ;-)

Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

Hi Mandy, > Updated webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.01/ Looks good. I haven't reviewed the build changes. I assume they're OK if you managed to build ;-) best regards, -- daniel On 15/02/17 19:32, Mandy Chung wrote: On Feb 15, 2017, at 10:29 AM,

Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

> On Feb 15, 2017, at 10:29 AM, Daniel Fuchs wrote: > > Hi Mandy, > > Some early comments: > > GenGraphs.java > -- > > 58 dir = Paths.get(args[++i]); > > may produced ArrayOutOfBoundsException - should we have better > error reporting? >

Re: Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

Hi Mandy, Some early comments: GenGraphs.java -- 58 dir = Paths.get(args[++i]); may produced ArrayOutOfBoundsException - should we have better error reporting? Or should it check && i < args.length - 1 so that it falls back to having dir == null below? 93

Review Request: JDK-8173374: Update GenGraphs tool to generate dot graph with requires transitive edges

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173374/webrev.00/ This is the first step to enable generating dot graph to be included in module summary javadoc, if desired. jdeps already supports generating the dot graph for modules. This patch converts GenGraphs build tool to use jdeps