Re: RFR: 8175891, 8192892: JrtPath improvements

+1 -Sundar On 01/12/17, 7:04 PM, Claes Redestad wrote: Hi, please review this patch that resolves two small but sometimes significant inefficiencies in jdk.internal.jrtfs.JrtPath: Improve JrtPath::getResolved fast-path test: https://bugs.openjdk.java.net/browse/JDK-8192892 Testing for '.'

RFR 8185130: jlink should throw error if target image and current JDK versions don't match

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8185130 Webrev: http://cr.openjdk.java.net/~sundar/8185130/webrev.00/index.html Thanks, -Sundar

Re: RFR 8185130: jlink should throw error if target image and current JDK versions don't match

Updated to check minor version as well -> http://cr.openjdk.java.net/~sundar/8185130/webrev.01/index.html Thanks -Sundar On 05/12/17, 7:07 PM, Alan Bateman wrote: On 05/12/2017 13:34, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8185

Re: RFR 8185130: jlink should throw error if target image and current JDK versions don't match

Yes, that is right. Thanks for the review. -Sundar On 05/12/17, 8:53 PM, Alan Bateman wrote: On 05/12/2017 14:42, Sundararajan Athijegannathan wrote: Updated to check minor version as well -> http://cr.openjdk.java.net/~sundar/8185130/webrev.01/index.html I think this looks okay. I ass

Re: RFR 8185130: jlink should throw error if target image and current JDK versions don't match

Updated: http://cr.openjdk.java.net/~sundar/8185130/webrev.02/ -Sundar On 05/12/17, 9:55 PM, mandy chung wrote: On 12/5/17 6:42 AM, Sundararajan Athijegannathan wrote: Updated to check minor version as well -> http://cr.openjdk.java.net/~sundar/8185130/webrev.01/index.html

RFR 8192986: Inconsistent handling of exploded modules in jlink

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8192986 Webrev: http://cr.openjdk.java.net/~sundar/8192986/webrev.00/ Thanks, -Sundar

Re: RFR 8192986: Inconsistent handling of exploded modules in jlink

Updated: http://cr.openjdk.java.net/~sundar/8192986/webrev.01/ PS. Bug description line was wrong in the test .java file. -Sundar On 07/12/17, 8:40 PM, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8192986 Webrev: http://cr.openjdk.java.net

Re: RFR 8192986: Inconsistent handling of exploded modules in jlink

Hi, Comments below... On 07/12/17, 8:54 PM, Claes Redestad wrote: Hi Sundar, thanks for picking this up so quick! On 2017-12-07 16:21, Sundararajan Athijegannathan wrote: Updated: http://cr.openjdk.java.net/~sundar/8192986/webrev.01/ Looks ok, butunless my understanding is flawed it seems

Re: RFR 8192986: Inconsistent handling of exploded modules in jlink

is better to detect and report non-modular exploded dirs as well. * Fixed to avoid second resolve for "module-info.class" in JlinkTask.java Please review updated webrev: http://cr.openjdk.java.net/~sundar/8192986/webrev.02/ Thanks -Sundar On 07/12/17, 9:15 PM, Sundararajan Athij

Re: [11] RFR JDK-8196310: jlink --suggest-providers fails with missing resource if --output specified

+1 -Sundar On 31/01/18, 6:01 AM, mandy chung wrote: (resend with fixed formatting) Webrev: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8196310/webrev.00/ Improve the error message when invalid argument is specified to --suggest-providers option. $ jlink --add-modules java.base --su

RFR 8194922: jlink --exclude-resources should never exclude module-info.class

Please review. Webrev: http://cr.openjdk.java.net/~sundar/8194922/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8194922 Thanks -Sundar

Re: RFR 8194922: jlink --exclude-resources should never exclude module-info.class

/18, 9:52 PM, Alan Bateman wrote: On 19/02/2018 16:12, Sundararajan Athijegannathan wrote: Please review. Webrev: http://cr.openjdk.java.net/~sundar/8194922/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8194922 I assume it should be testing the resource name with equals rather than

Re: RFR 8194922: jlink --exclude-resources should never exclude module-info.class

Throwing exception now -> http://cr.openjdk.java.net/~sundar/8194922/webrev.02/ Thanks -Sundar On 20/02/18, 2:54 PM, Alan Bateman wrote: On 20/02/2018 08:08, Sundararajan Athijegannathan wrote: Updated: http://cr.openjdk.java.net/~sundar/8194922/webrev.01/ * replaced endsWith with equ

RFR 8206962: jlink --release-info=del throws NPE if no keys are specified

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8206962 Webrev: https://cr.openjdk.java.net/~sundar/8206962/webrev.00/ Thanks, -Sundar

RFR 8212137: Remove JrtFileSystem finalize method

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8212137 Webrev: https://cr.openjdk.java.net/~sundar/8212137/webrev.00/ Thanks, -Sundar

Re: Script generated using jlink --launcher doesn't espace arguments

Thanks for reporting this issue. Filed a bug -> https://bugs.openjdk.java.net/browse/JDK-8220699 Thanks, -Sundar On 14/03/19, 8:19 PM, li...@bendem.be wrote: Hi, Not quite sure where to report this, but it's a pretty annoying bug making scripts generated using the --launcher parameter unusab

RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8216553 Webrev: https://cr.openjdk.java.net/~sundar/8216553/webrev.00/ Thanks, -Sundar

Re: Nashorn on the module-path

How can this be reproduced at out end? Thanks -Sundar On 26/05/19, 2:47 PM, Christian Stein wrote: Have you brought this up on nashorn-dev... No, but cc-ed that list now. ...as this might require digging into the dynalink linker and how method handles are used. Do you think it's still worth

Re: Nashorn on the module-path

Thanks. I'll check it out. -Sundar On 27/05/19, 3:10 PM, Christian Stein wrote: On Mon, May 27, 2019 at 11:37 AM Sundararajan Athijegannathan <mailto:sundararajan.athijegannat...@oracle.com>> wrote: How can this be reproduced at out end? I compiled a small example proje

Re: RFR 8216553: JrtFIleSystemProvider getPath(URI) omits /modules element from file path

Updated for java test failures: https://cr.openjdk.java.net/~sundar/8216553/webrev.01/ PS. Test framework used wrong jrt: URI pattern. Fixed it. -Sundar On 27/05/19, 5:37 PM, Alan Bateman wrote: On 27/05/2019 10:18, Sundararajan Athijegannathan wrote: Please review. Bug: https

RFR 8224946: jrtfs URI to Path and Path to URI conversions are wrong

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8224946 Webrev: https://cr.openjdk.java.net/~sundar/8224946/webrev.00/ Earlier attempt for the fix of the same bug resulted in test failures and so the fix was reverted. The current webrev has the same fix - but fixes 2 jlink tests t

RFR 8216535: tools/jimage/JImageExtractTest.java timed out

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8216535 Webrev: https://cr.openjdk.java.net/~sundar/8216535/webrev.00/ I'm creating a small jre image with just java.base and jdk.zipfs modules it. The lib/modules of that small jre is extracted for the test purpose. This reduces tim

Re: RFR 8216535: tools/jimage/JImageExtractTest.java timed out

Hi Mandy, Sorry I pushed the change. I'll take care of these suggestions in future change in this area. Thanks, -Sundar On 31/05/19, 8:13 AM, Mandy Chung wrote: Hi Sundar, On 5/30/19 10:12 AM, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/b

RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8182555 Webrev: http://cr.openjdk.java.net/~sundar/8220700/webrev.00/ Thanks, -Sundar

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Oops. Wrong bug link. Correct one: https://bugs.openjdk.java.net/browse/JDK-8220700 -Sundar On 20/08/19 5:17 pm, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8182555 Webrev: http://cr.openjdk.java.net/~sundar/8220700/webrev.00/

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Updated to add a test: http://cr.openjdk.java.net/~sundar/8220700/webrev.01 PS. There are launcher tests in BasicTest.java and arguments are passed even - but args are only printed. The new test passes args and checks the return value that is computed using the args. Thanks, -Sundar On 20/

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Thanks Severin for your test improvement suggestion! Updated: http://cr.openjdk.java.net/~sundar/8220700/webrev.02/index.html PS. This email is in response to https://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-August/014273.html For some reason, I didn't get Severin's email. Checked it by

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Hi Alan, Thanks for your review. I'll add a comment in Adder and push. Thanks, -Sundar On 21/08/19 5:28 pm, Alan Bateman wrote: On 21/08/2019 12:33, sundararajan.athijegannat...@oracle.com wrote: Thanks Severin for your test improvement suggestion! Updated: http://cr.openjdk.java.net/~sunda

RFR 8225562: jlink --module-path behavior inconsistent with help/errors

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8225562 Webrev: http://cr.openjdk.java.net/~sundar/8225562/webrev.00/ Thanks -Sundar

Re: RFR 8225562: jlink --module-path behavior inconsistent with help/errors

Thanks the review. I'll fix that and push. -Sundar On 09/12/19 9:57 pm, Alan Bateman wrote: On 09/12/2019 07:50, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8225562 Webrev: http://cr.openjdk.java.net/~sundar/8225562/webrev.00/ T

RFR 8225561: jlink --help doesn't state that ALL-MODULE-PATH is accepted for --add-modules

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8225561 Webrev: http://cr.openjdk.java.net/~sundar/8225561/webrev.00/ Thanks -Sundar

RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

Please review. Not really a fix - but increasing the default timeout for the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8222098 Webrev: http://cr.openjdk.java.net/~sundar/8222098/webrev.00/ Thanks, -Sundar

Re: RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

Adding core-libs-dev. -Sundar On 10/01/20 11:33 am, sundararajan.athijegannat...@oracle.com wrote: Please review. Not really a fix - but increasing the default timeout for the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8222098 Webrev: http://cr.openjdk.java.net/~sundar/8222098/webre

Re: RFR 8222098: tools/jlink/plugins/IncludeLocalesPluginTest.java time out

Hi Naoto, Thanks. I'll make those changes and push. -Sundar On 10/01/20 7:20 pm, naoto.s...@oracle.com wrote: Hi Sundar, You might want to add the bug id in the regression test, and change the copyright year to 2020. Otherwise, looks good. Naoto On 1/10/20 5:07 AM, sundararajan.athijegan

RFR 8222100: tools/jimage/JImageTest.java time out

Bumping the default timeout (other tests in the same dir have similar timeout settings). Bug: https://bugs.openjdk.java.net/browse/JDK-8222100 Webrev: http://cr.openjdk.java.net/~sundar/8222100/webrev.00/ Thanks, -Sundar

RFR 8242860: test/jdk/tools/jlink/ModuleNamesOrderTest.java uses nashorn module

Hi, nashorn modules were used only as an example in this test. Using jdk.jshell module instead to test known module dependencies in jlink produced images. Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242860 Webrev: http://cr.openjdk.java.net/~sundar/8242860/webrev.00/ Thanks

RFR 8242859: test/jdk/tools/jlink/JLinkTest.java uses nashorn module

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8242859 Webrev: http://cr.openjdk.java.net/~sundar/8242859/webrev.00/ Relevant JLinkTest.java section deleted as part of nashorn removal is as follows: http://cr.openjdk.java.net/~sundar/8241749/webrev.00/test/jdk/tools/jlink/JLink

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

Hi Alan, I don't remember it now. Likely a mistake. The changeset http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/a066fe7b1b42 has that file. Perhaps it may be useful to restore & check if the test passes. Thanks, -Sundar On 18/04/20 3:32 pm, Alan Bateman wrote: Sundar - do you recognize th

Re: RFR (T): 8242846: Bring back test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java (was: Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

Looks good -Sundar On 27/04/20 12:24 pm, Ao Qi wrote: On Sun, Apr 26, 2020 at 12:00 AM Alan Bateman wrote: On 21/04/2020 04:58, Ao Qi wrote: On 2020/4/20 下午9:27, Alan Bateman wrote: On 20/04/2020 11:32, sundararajan.athijegannat...@oracle.com wrote: Hi Alan, I don't remember it now. Likel

Re: RFR (T): 8242846: Bring back test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java

Hi, Looks good. I'll sponsor this fix. Thanks -Sundar On 27/04/20 4:15 pm, Ao Qi wrote: Thanks, Sundar! I updated a new webrev (patch is the same, only hg commit info was added): http://cr.openjdk.java.net/~aoqi/8242846/webrev.02/ Could someone help to sponsor this? Thanks, Ao Qi On Mon,

RFR 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8246034 Webrev: http://cr.openjdk.java.net/~sundar/8246034/webrev.00/ Thanks -Sundar

Re: RFR 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js

Yes, checked. No config file refers to these .js files. -Sundar On 28/05/20 12:28 pm, Alan Bateman wrote: On 28/05/2020 07:14, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8246034 Webrev: http://cr.openjdk.java.net/~sundar/824603

Re: How to extract a class from "modules" archive

By tool: jimage extract By API: jrt-fs file system. You can find jrt-fs usage from javac code -Sundar On 25/12/20 4:02 pm, Gunnar Morling wrote: Hi, Is the format of the "modules" archive specified and documented somewhere? Or asked differently, if I wanted to extract the class file for a

RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8159004 Piggybacking couple of cleanups suggested (but missed) in this thread -> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009186.html Thanks, -Sundar

Re: RFR 8164800: Cross targeting Windows

t; regards, > Rémi > > - Mail original - >> De: "Sundararajan Athijegannathan" >> À: "Alan Bateman" , "jigsaw-dev" >> >> Envoyé: Vendredi 26 Août 2016 18:08:12 >> Objet: Re: RFR 8164800: Cross targeting Windows >>

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

Updated: http://cr.openjdk.java.net/~sundar/8159004/webrev.02/ -Sundar On 8/29/2016 5:52 PM, Alan Bateman wrote: > On 29/08/2016 13:00, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ >> for https://bugs.openjdk.j

RFR 8157992: Improve jlink help message on optimization-related options

Please review http://cr.openjdk.java.net/~sundar/8157992/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8157992 Thanks -Sundar

Re: RFR 8157992: Improve jlink help message on optimization-related options

Cleas, Alan: Thanks for the reviews. Uploaded updated webrev for the record: http://cr.openjdk.java.net/~sundar/8157992/webrev.02/ And going ahead with push.. Thanks. -Sundar On 9/2/2016 1:42 PM, Alan Bateman wrote: > On 02/09/2016 07:07, Sundararajan Athijegannathan wrote: > >

RFR 8163952: jlink exclude VM plugin does not support static libraries

Please review http://cr.openjdk.java.net/~sundar/8163952/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8163952 Thanks, -Sundar

Re: RFR 8163952: jlink exclude VM plugin does not support static libraries

gt;> 106 return t.path().endsWith("/" + jvmlib); >> 107 } >> >> Kind regards, >> Anthony >> >> >> On 6/09/2016 12:12, Sundararajan Athijegannathan wrote: >>> Please review http://cr.openjdk.java.net/~sundar/8163952/webrev.01/ for >>> https://bugs.openjdk.java.net/browse/JDK-8163952 >>> >>> Thanks, >>> >>> -Sundar >>>

RFR 8165503: jlink exclude VM plugin's handling of jvmlibs is wrong

Please review http://cr.openjdk.java.net/~sundar/8165503/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8165503 Thanks, -Sundar

RFR 8165697: jlink running on Mac with Windows jmods produces non-runnable image

Please review http://cr.openjdk.java.net/~sundar/8165697/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8165697 Thanks -Sundar

RFR 8163320: JAVA_VERSION in release file should come from java.base module

Please review fix for https://bugs.openjdk.java.net/browse/JDK-8163320 jdk repo: http://cr.openjdk.java.net/~sundar/8163320/jdk/ * JAVA_VERSION is derived from module-info of java.base * adding quotes around all 'release' properties top repo: http://cr.openjdk.java.net/~sundar/8163320/top/web

RFR 8165772: fix for 8165595 results in failure of jdk/test/tools/launcher/VersionCheck.java

Please review http://cr.openjdk.java.net/~sundar/8165772/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8165772 Thanks, -Sundar

Re: RFR 8165772: fix for 8165595 results in failure of jdk/test/tools/launcher/VersionCheck.java

09/2016 14:58, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8165772/webrev.01/ for >> https://bugs.openjdk.java.net/browse/JDK-8165772 >> > Would it better to skip when the module has launchers in the bin > directory? > > -Alan

Re: RFR 8165772: fix for 8165595 results in failure of jdk/test/tools/launcher/VersionCheck.java

Bug: https://bugs.openjdk.java.net/browse/JDK-8165772 This VersionCheck.java test failed after main class was added to nashorn modules. VersionCheck expects all jdk/bin tools to be derived from the standard launcher. But, jlink generates shell scripts and batch files for modules with main class.

Re: RFR 8163320: JAVA_VERSION in release file should come from java.base module

ood. > > Is there an existing test to check the content of `release` file? It would > be good to have a test to sanity test a few properties and its quoted value. > > Mandy > >> On Sep 9, 2016, at 6:02 AM, Sundararajan Athijegannathan >> wrote: >> >> Please

RFR 8160063: Provide a means to disable a plugin via the command line

Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8160063 * Adding --disable- option for any plugin that is auto-enabled. * Removed ad-hoc "none" option of generate-jli-classes plugin. * Simple test to make sure --disable-generate-jl

Re: RFR 8160063: Provide a means to disable a plugin via the command line

Also piggybacking clean-up in unusued code in JLinkTask.java (Section enum) -Sundar On 15/09/16, 8:01 PM, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8160063 * Adding --disable- option

Re: RFR 8160063: Provide a means to disable a plugin via the command line

5/2016 9:57 PM, Paul Sandoz wrote: >> On 15 Sep 2016, at 09:06, Mandy Chung wrote: >> >> >>> On Sep 15, 2016, at 8:26 AM, Alan Bateman wrote: >>> >>> On 15/09/2016 07:31, Sundararajan Athijegannathan wrote: >>> >>>&g

RFR 8165735: jlink incorrectly accepts multiple --module-path and --limit-modules options

Please review http://cr.openjdk.java.net/~sundar/8165735/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8165735 Thanks, -Sundar

Re: Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package

+1 -Sundar On 10/7/2016 3:47 AM, Mandy Chung wrote: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/ > > Currently, `--add-exports` and `--add-reads` options do not accept duplicated > module/package and it is an error to attempt to export the same package more > than once

RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/webrev.00/ nashorn webrev: http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.00/ Thanks, -Sundar

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

dules only and I'll change that. -Sundar On 10/12/2016 8:51 PM, Alan Bateman wrote: > On 12/10/2016 16:11, Sundararajan Athijegannathan wrote: > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8167614 >> >> jdk webrev: http://cr.openjdk.java.net/~sundar/8167614/jdk/w

Re: RFR 8167614: Avoid module dependency from jdk.dynalink to jdk.internal.module of java.base module

Updated nashorn webrev: http://cr.openjdk.java.net/~sundar/8167614/nashorn/webrev.01/ Changed to use Layer.boot().findModule. Thanks -Sundar On 10/12/2016 9:42 PM, Alan Bateman wrote: > On 12/10/2016 16:33, Sundararajan Athijegannathan wrote: > >> : >> >> Dynalink u

Re: JEP-282: JLink two modules exporting the same package name

If you want to enforce that kind of consistency - that no two application modules should export same named package - it should be possible to implement a user defined jlink plugin to enforce the same. -Sundar On 10/13/2016 12:35 AM, Alan Bateman wrote: > On 12/10/2016 19:17, Karl Heinz Marbaise w

RFR 8168091: jlink should check security permission early when programmatic access is used

Please review http://cr.openjdk.java.net/~sundar/8168091/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8168091 Thanks, -Sundar

Re: RFR 8168091: jlink should check security permission early when programmatic access is used

ar On 18/10/16, 3:33 AM, Mandy Chung wrote: On Oct 17, 2016, at 10:23 AM, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8168091/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8168091 The shell test can be removed and use @run main/othervm/secur

Re: RFR 8168091: jlink should check security permission early when programmatic access is used

good. Mandy On Oct 17, 2016, at 10:26 PM, Sundararajan Athijegannathan wrote: Hi, Thanks for your review. I've updated webrev with jdk.tools.jlink -> jdk.tools.jlink.internal refactoring. But, when I attempted to get rid of shell script in the test with your suggestion, I got: Exce

RFR 8166810: jlink should fail on extra arguments

Please review http://cr.openjdk.java.net/~sundar/8166810/webrev.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8166810 Thanks, -Sundar

RFR 8160063: Provide a means to disable a plugin via the command line

Please review http://cr.openjdk.java.net/~sundar/8160063/webrev.02/ for https://bugs.openjdk.java.net/browse/JDK-8160063 PS. Earlier review thread on slightly different fix: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-September/009392.html Thanks, -Sundar

RFR 8166286: jmod fails on symlink to directory

Please review http://cr.openjdk.java.net/~sundar/8166286/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8166286 Thanks, -Sundar

Re: RFR 8166286: jmod fails on symlink to directory

* On module names: This jmod test file uses names like "foo" (unlike jlink tests). Hope the module name is fine. Thanks. -Sundar On 11/4/2016 4:10 PM, Alan Bateman wrote: > > > On 04/11/2016 10:36, Sundararajan Athijegannathan wrote: >> Please review http://cr.openjdk.java.n

Re: RFR: 8159393 - jlink should print a warning that a signed modular JAR will be treated as unsigned

Looks good to me. PS. jmods, jars are not modified by jlink. Only a new image directory is generated. So, strip-signing-info confusion is unlikely. -Sundar On 11/7/2016 9:36 PM, Sean Mullan wrote: > On 11/7/16 9:13 AM, Jim Laskey (Oracle) wrote: >> The bug https://bugs.openjdk.java.net/browse/J

Re: RFR: JDK-8155756 - Better context for some jlink exceptions

+1 -Sundar On 11/7/2016 11:13 PM, Jim Laskey (Oracle) wrote: > Only 2 of 3 examples still present. > > http://cr.openjdk.java.net/~jlaskey/8155756/webrev/index.html > > https://bugs.openjdk.java.net/browse/JDK-8155756 >

RFR 8160359: Improve jlink logging for cases when a plugin throws exception

Please review for http://cr.openjdk.java.net/~sundar/8160359/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8160359 Thanks, -Sundar

Re: RFR 8160359: Improve jlink logging for cases when a plugin throws exception

t; building the JDK (as jlink plugins are now essential to creating the >> standard images), and having to hack the makefiles to add >> -J-Djlink.debug=true(?) to the right place seems a bit awkward. >> >> Should we simply make this added verbosity the default in the build? &g

Re: RFR: JDK-8169720 - jimage help message for --include option should be corrected

+1 On 11/15/2016 8:09 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8169720/webrev/index.html > > https://bugs.openjdk.java.net/browse/JDK-8169720 > >

RFR 8153038: The set of jlink plugins enabled by default should be the same via CLI or jlink API

Please review http://cr.openjdk.java.net/~sundar/8153038/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8153038 PS. Pre-existing IntegrationTest.java test already checks the Jlink API code path [so, no new test added]. Thanks, -Sundar

Re: RFR: JDK-8169505 - Update changes by JDK-8159393 to reflect CCC review

+1 -Sundar On 11/15/2016 11:27 PM, Jim Laskey (Oracle) wrote: > http://cr.openjdk.java.net/~jlaskey/8169505/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8169505 > >

RFR 8170099: Nashorn test failures with stricter reflection access checks in jake forest

Please review http://cr.openjdk.java.net/~sundar/8170099/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8170099 Thanks, -Sundar

Re: RFR 8170099: Nashorn test failures with stricter reflection access checks in jake forest

Thanks for the review. Fixing Reflection with your suggesting and pushing it. Updated webrev for the record: http://cr.openjdk.java.net/~sundar/8170099/webrev.01/ -Sundar On 21/11/16, 7:43 PM, Alan Bateman wrote: On 21/11/2016 14:14, Sundararajan Athijegannathan wrote: Please review http

hg: jigsaw/jake/nashorn: 8170099: Nashorn test failures with stricter reflection access checks in jake forest

Changeset: 3d66147560bb Author:sundar Date: 2016-11-21 20:37 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/3d66147560bb 8170099: Nashorn test failures with stricter reflection access checks in jake forest Reviewed-by: jlaskey, alanb ! make/project.properties ! test

Re: Code review for jigsaw/jake -> jdk9/dev sync up

Reviewed Nashorn changes. All fine. -Sundar On 11/28/2016 8:17 PM, Chris Hegarty wrote: > On 24 Nov 2016, at 15:25, Alan Bateman wrote: >> ... >> To get going, I've put the webrevs with a snapshot of the changes in jake >> here: >>http://cr.openjdk.java.net/~alanb/8169069/0/ > Overall this

RFR 8160359: Improve jlink logging for cases when a plugin throws exception

Please review fix for https://bugs.openjdk.java.net/browse/JDK-8160359 jdk webrev: http://cr.openjdk.java.net/~sundar/8160359/webrev.01/ top webrev: http://cr.openjdk.java.net/~sundar/8160359/top/webrev.01/ This is mainly a debugging aid for jlink invocation - in particular from jdk makefiles. W

Re: Reading bootstrap class bytecode from Java 7

Hi, http://openjdk.java.net/jeps/220 clearly states this: "For tools that support the development of code for JDK 9 but which themselves run on JDK 8, a copy of this filesystem provider suitable for use on JDK 8 will be placed in the root directory of JDK 9 run-time images, in a file named |jrt-f

RFR 8168925: MODULES property should be topologically ordered and space-separated list

Please review http://cr.openjdk.java.net/~sundar/8168925/webrev.01/index.html for https://bugs.openjdk.java.net/browse/JDK-8168925 PS. Mandy Chung wrote ModuleSorter for another fix (yet to be pushed). I'm using it for this fix after discussion with her (private email). Thanks, -Sundar

Re: RFR 8168925: MODULES property should be topologically ordered and space-separated list

Hi, Thanks for your review. Comments below.. On 10/12/16, 2:18 AM, Mandy Chung wrote: On Dec 9, 2016, at 12:49 AM, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8168925/webrev.01/index.html for https://bugs.openjdk.java.net/browse/JDK-8168925 Is the

Re: RFR 8168925: MODULES property should be topologically ordered and space-separated list

ndararajan Athijegannathan wrote: Hi, Thanks for your review. Comments below.. On 10/12/16, 2:18 AM, Mandy Chung wrote: On Dec 9, 2016, at 12:49 AM, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8168925/webrev.01/index.html for https://bugs.openjdk.java.net/

Re: RFR 8168925: MODULES property should be topologically ordered and space-separated list

Hi Mandy, I'll refactor (and revisit) TOP/OTHER types in my next jlink change. Thanks for the review. Thanks, -Sundar On 12/12/16, 11:04 AM, Mandy Chung wrote: On Dec 11, 2016, at 9:30 PM, Sundararajan Athijegannathan wrote: Hi, Please review the updated webrev:

RFR 8171070: Test ModuleNamesOrderTest.java fails

Please review http://cr.openjdk.java.net/~sundar/8171070/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8171070 Thanks, -Sundar

RFR 8171138: Remove FileCopierPlugin

Please review http://cr.openjdk.java.net/~sundar/8171138/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8171138 Piggybacking cleanup: release file generation ("TOP" entry type handling) moved to accept(ResourcePoolEntry) Thanks, -Sundar

Re: RFR 8171138: Remove FileCopierPlugin

Hi Mandy, Thanks for your review. I updated to handle TOP entries in accept callback uniformly: http://cr.openjdk.java.net/~sundar/8171138/webrev.01/index.html Thanks, -Sundar On 14/12/16, 10:51 PM, Mandy Chung wrote: On Dec 14, 2016, at 9:02 AM, Sundararajan Athijegannathan wrote

RFR 8171316: Add IMPLEMENTOR property to the release file

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8171316 top level webrev: http://cr.openjdk.java.net/~sundar/8171316/top/webrev.00/ jdk webrev: http://cr.openjdk.java.net/~sundar/8171316/jdk/webrev.00/ Thanks, -Sundar

RFR 8170289: Re-examine entry point support in jlink

Hi, Please review http://cr.openjdk.java.net/~sundar/8170289/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8170289 Thanks, -Sundar

Re: RFR 8170289: Re-examine entry point support in jlink

Updated it: http://cr.openjdk.java.net/~sundar/8170289/webrev.02 Thanks, -Sundar On 17/12/16, 12:33 AM, Mandy Chung wrote: On Dec 16, 2016, at 8:36 AM, Sundararajan Athijegannathan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8170289/webrev.01/ for https

Re: RFR 8170289: Re-examine entry point support in jlink

18, 2016, at 7:29 AM, Sundararajan Athijegannathan wrote: Updated it: http://cr.openjdk.java.net/~sundar/8170289/webrev.02 Thanks, -Sundar On 17/12/16, 12:33 AM, Mandy Chung wrote: On Dec 16, 2016, at 8:36 AM, Sundararajan Athijegannathan wrote: Hi, Please review http://cr.openjdk.j

Re: RFR 8170289: Re-examine entry point support in jlink

Thanks. I'll file another bug to fix these issues. -Sundar On 19/12/16, 4:56 PM, Alan Bateman wrote: On 19/12/2016 04:08, Sundararajan Athijegannathan wrote: Fixed. Updated webrev for the record: http://cr.openjdk.java.net/~sundar/8170289/webrev.03 I'm pushing this as you

RFR 8170618: jmod should validate if any exported or open package is missing

Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8170618 Thanks, -Sundar

Re: RFR 8171380: Remove exports from jdk.jlink

+1 -Sundar On 16/01/17, 9:16 PM, Chris Hegarty wrote: The Jlink Plugin API is not going to be supported in 9, so should not be exported [1], for use by third parties. Besides the removal of the export, most of the changes are adding @modules tags to existing tests. http://cr.openjdk.java.net/~

  1   2   3   >