[ https://issues.apache.org/jira/browse/ARROW-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Micah Kornfield updated ARROW-9613: ----------------------------------- Description: When originally reviewing the code I suggested a new VectorSchemaRoot on each call to the iterator. After further discussions on the mailing list, it seems that this is an anit-pattern for working with VectorSchemaRoot, we should update the code to update a single VectorSchemaRoot. After this change it should be easier to use Avro converter with other components of the library (i.e. filewriter) which also make use of a single VectorSchemaRoot. was:When originally reviewing the code I suggested a new VectorSchemaRoot on each call to the iterator. After further discussions on the mailing list, it seems that this is an anit-pattern for working with VectorSchemaRoot, we should update the code to own a single vectorschemaroot and return it each time with new records. > [Java] Avro to Arrow converter should reuse the same VectorSchemaRoot > --------------------------------------------------------------------- > > Key: ARROW-9613 > URL: https://issues.apache.org/jira/browse/ARROW-9613 > Project: Apache Arrow > Issue Type: Improvement > Components: Java > Reporter: Micah Kornfield > Priority: Major > > When originally reviewing the code I suggested a new VectorSchemaRoot on each > call to the iterator. After further discussions on the mailing list, it > seems that this is an anit-pattern for working with VectorSchemaRoot, we > should update the code to update a single VectorSchemaRoot. > > After this change it should be easier to use Avro converter with other > components of the library (i.e. filewriter) which also make use of a single > VectorSchemaRoot. -- This message was sent by Atlassian Jira (v8.3.4#803005)