vvcephei merged pull request #8667:
URL: https://github.com/apache/kafka/pull/8667
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-1:
--
Labels: needs-kip (was: )
> Atomic commit of source connector records and offsets
>
[
https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-1:
--
Description:
It'd be nice to be able to configure source connectors such that their offsets
Chris Egerton created KAFKA-1:
-
Summary: Atomic commit of source connector records and offsets
Key: KAFKA-1
URL: https://issues.apache.org/jira/browse/KAFKA-1
Project: Kafka
ableegoldman commented on a change in pull request #8669:
URL: https://github.com/apache/kafka/pull/8669#discussion_r425467074
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java
##
@@ -198,433 +196,51 @@ public
ableegoldman commented on pull request #8669:
URL: https://github.com/apache/kafka/pull/8669#issuecomment-628915649
Call for review @cadonna @guozhangwang @vvcephei
This is an automated message from the Apache Git Service.
ableegoldman opened a new pull request #8669:
URL: https://github.com/apache/kafka/pull/8669
This is a prerequisite for
[KAFKA-9501](https://github.com/apache/kafka/pull/8248/) and will also be
useful for [KAFKA-9603](https://github.com/apache/kafka/pull/8661)
There should be no
[
https://issues.apache.org/jira/browse/KAFKA-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107726#comment-17107726
]
Boyang Chen commented on KAFKA-9993:
Thanks [~vvcephei] An example is from the recent implementation
OneCricketeer commented on pull request #8489:
URL: https://github.com/apache/kafka/pull/8489#issuecomment-628906219
Since Java 8 is EOL, why not upgrade to openjdk 11?
This is an automated message from the Apache Git
mumrah commented on a change in pull request #8569:
URL: https://github.com/apache/kafka/pull/8569#discussion_r425443889
##
File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala
##
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
rhauch commented on pull request #8618:
URL: https://github.com/apache/kafka/pull/8618#issuecomment-628898153
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
d8tltanc removed a comment on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-62030
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3931/
Link for the system tests ⬆️
rhauch commented on pull request #8090:
URL: https://github.com/apache/kafka/pull/8090#issuecomment-628895259
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax merged pull request #8665:
URL: https://github.com/apache/kafka/pull/8665
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #8665:
URL: https://github.com/apache/kafka/pull/8665#issuecomment-628892193
Thanks for the fix @zhaohaidao! Merged to `trunk`.
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-9984.
Fix Version/s: 2.6.0
Resolution: Fixed
> Should fail the subscription when pattern
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-628885132
I've added some integration tests for creating the internal topic, including
verifying some existing functionality w/r/t the replication factor and number
of partitions with
[
https://issues.apache.org/jira/browse/KAFKA-9676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107672#comment-17107672
]
Boyang Chen commented on KAFKA-9676:
The current trunk has logic coverage for StandbyTaskCreator in
vvcephei commented on pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#issuecomment-628881057
Thanks, @ableegoldman !
This is an automated message from the Apache Git Service.
To respond to the message,
vvcephei merged pull request #8662:
URL: https://github.com/apache/kafka/pull/8662
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ableegoldman commented on pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#issuecomment-628879075
Java 14 build passed, Java 8 din't build due to
```
11:29:13 # There is insufficient memory for the Java Runtime Environment to
continue.
11:29:13 # Cannot create
Boyang Chen created KAFKA-:
--
Summary: Topic description should be triggered after each failed
topic creation iteration
Key: KAFKA-
URL: https://issues.apache.org/jira/browse/KAFKA-
Project:
[
https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107623#comment-17107623
]
Boyang Chen commented on KAFKA-9989:
Discussed with [~cadonna] and it seems to be caused by some
[
https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen reassigned KAFKA-9989:
--
Assignee: (was: Boyang Chen)
> StreamsUpgradeTest.test_metadata_upgrade could not
radai rosenblatt created KAFKA-9998:
---
Summary: KafkaProducer.close(timeout) still may block indefinitely
Key: KAFKA-9998
URL: https://issues.apache.org/jira/browse/KAFKA-9998
Project: Kafka
vvcephei commented on a change in pull request #8667:
URL: https://github.com/apache/kafka/pull/8667#discussion_r425386296
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -555,28 +555,35 @@ void runLoop() {
[
https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107584#comment-17107584
]
Hai Lin commented on KAFKA-9987:
Thanks for putting this up. From the above algorithm, looks like we will
[
https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107585#comment-17107585
]
Hai Lin commented on KAFKA-9987:
Saw the PR, I will take a look.
> Improve sticky partition assignor
abbccdda commented on a change in pull request #8667:
URL: https://github.com/apache/kafka/pull/8667#discussion_r425366150
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -555,28 +555,35 @@ void runLoop() {
mimaison merged pull request #8222:
URL: https://github.com/apache/kafka/pull/8222
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ableegoldman opened a new pull request #8668:
URL: https://github.com/apache/kafka/pull/8668
Motivation and pseudo code algorithm in the ticket.
[WIP] still need to finish writing tests and gather rough benchmark results
Emanuele Maccherani created KAFKA-9997:
--
Summary: upgrade log4j lib to address CVE-2020-9488
Key: KAFKA-9997
URL: https://issues.apache.org/jira/browse/KAFKA-9997
Project: Kafka
Issue
vvcephei commented on a change in pull request #8667:
URL: https://github.com/apache/kafka/pull/8667#discussion_r425348145
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -555,28 +555,35 @@ void runLoop() {
Emanuele Maccherani created KAFKA-9996:
--
Summary: upgrade zookeeper to 3.5.8 to address security
vulnerabilities
Key: KAFKA-9996
URL: https://issues.apache.org/jira/browse/KAFKA-9996
Project:
mjsax commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-628812878
Yes, on the voting thread: I proposed to also deprecate `through()` via
KIP-221 and Guozhang replied. But it's your KIP and I don't want to "hijack" it
:) -- I am willing to do the
mjsax commented on pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#issuecomment-62881
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#issuecomment-628810936
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
guozhangwang commented on a change in pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#discussion_r425343094
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1520,38 +1534,6 @@ private
[
https://issues.apache.org/jira/browse/KAFKA-9676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107523#comment-17107523
]
Matthias J. Sax commented on KAFKA-9676:
[~bchen225242] There is still no
vvcephei commented on a change in pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#discussion_r425330736
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -169,6 +173,9 @@ public void
mjsax commented on pull request #8667:
URL: https://github.com/apache/kafka/pull/8667#issuecomment-628795711
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
abbccdda opened a new pull request #8667:
URL: https://github.com/apache/kafka/pull/8667
The TaskMigratedException should always be non-fatal and caught within the
run loop. Adding try-catch for corrupted path as well is necessary.
### Committer Checklist (excluded from commit
ableegoldman commented on a change in pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#discussion_r425314470
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -169,6 +173,9 @@ public void
ableegoldman commented on a change in pull request #8662:
URL: https://github.com/apache/kafka/pull/8662#discussion_r425314263
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -169,6 +173,9 @@ public void
mjsax commented on pull request #8665:
URL: https://github.com/apache/kafka/pull/8665#issuecomment-628779775
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107487#comment-17107487
]
John Roesler commented on KAFKA-9993:
-
Thanks for the idea, Boyang. Can you clarify whether the
James Hay created KAFKA-9995:
Summary: IllegalStateException when offsets not found
Key: KAFKA-9995
URL: https://issues.apache.org/jira/browse/KAFKA-9995
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-9994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-9994:
---
Description:
We have seen a case where the TaskMigrated exception gets thrown from
Boyang Chen created KAFKA-9994:
--
Summary: Catch TaskMigrated exception in task corruption code path
Key: KAFKA-9994
URL: https://issues.apache.org/jira/browse/KAFKA-9994
Project: Kafka
Issue
Boyang Chen created KAFKA-9993:
--
Summary: Think about inheritance in the protocol generation
framework
Key: KAFKA-9993
URL: https://issues.apache.org/jira/browse/KAFKA-9993
Project: Kafka
mimaison commented on pull request #8222:
URL: https://github.com/apache/kafka/pull/8222#issuecomment-628745671
Tests passed locally and the generated docs looked good, merging to trunk
This is an automated message from the
jeffhuang26 commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-628732206
What is timeline for merging this PR?
This is an automated message from the Apache Git Service.
To respond
mimaison commented on pull request #8222:
URL: https://github.com/apache/kafka/pull/8222#issuecomment-628718604
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107394#comment-17107394
]
John Roesler commented on KAFKA-9992:
-
Hello Andras,
Just to make sure I understand, is this just a
[
https://issues.apache.org/jira/browse/KAFKA-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107374#comment-17107374
]
Vince Mu commented on KAFKA-9479:
-
PR created [https://github.com/apache/kafka/pull/8666]
> Describe
VinceMu opened a new pull request #8666:
URL: https://github.com/apache/kafka/pull/8666
Used the [previous PR ](https://github.com/apache/kafka/pull/8096) made by
vetler as a starting point.
Updated the printState() method in ConsumerGroup command to only print the
header once
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-628682601
BTW, I've improved the error message when Connect's `TopicAdmin` fails to
create a topic because of an unknown topic setting:
> Uncaught exception in herder work thread,
bbejeck commented on pull request #6229:
URL: https://github.com/apache/kafka/pull/6229#issuecomment-628670456
@sh-abhi apologies for letting this slip. Can you rebase this PR? Then we
can get this merged.
Thanks.
vvcephei merged pull request #8588:
URL: https://github.com/apache/kafka/pull/8588
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vvcephei commented on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-628635918
The test failure was unrelated:
kafka.api.PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition
This
mmolimar commented on a change in pull request #8663:
URL: https://github.com/apache/kafka/pull/8663#discussion_r425135341
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java
##
@@ -96,6 +101,25 @@ public static void
[
https://issues.apache.org/jira/browse/KAFKA-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Katona updated KAFKA-9992:
-
Summary: EmbeddedKafkaCluster not working with kafka_2.13 (was:
EmbeddedKafka not working with
Andras Katona created KAFKA-9992:
Summary: EmbeddedKafka not working with kafka_2.13
Key: KAFKA-9992
URL: https://issues.apache.org/jira/browse/KAFKA-9992
Project: Kafka
Issue Type: Bug
mmolimar commented on a change in pull request #8663:
URL: https://github.com/apache/kafka/pull/8663#discussion_r425115475
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java
##
@@ -108,6 +132,20 @@ public static boolean
zhaohaidao commented on a change in pull request #8665:
URL: https://github.com/apache/kafka/pull/8665#discussion_r425097747
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##
@@ -1015,8 +1015,8 @@ public void subscribe(Collection
d8tltanc edited a comment on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-628340161
Latest dev branch builds here (REMOVE_SYSTEM_4):
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3944/
showuon edited a comment on pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#issuecomment-628563253
Hi @bbejeck , I appended more fixs for the streams documents. Please review
it when available. Thank you.
showuon edited a comment on pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#issuecomment-628563253
Hi @bbejeck , I appended more fixs for the streams documents when I read
it. Please review it when available. Thank you.
showuon commented on pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#issuecomment-628563253
Hi @bbejeck , I appended more fixs for the streams documents. Please review
it when available. Thank you.
This
showuon commented on a change in pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#discussion_r425055023
##
File path: docs/streams/developer-guide/write-streams.html
##
@@ -208,7 +208,7 @@ Using Kafka Streams within your application code
- Testing a
showuon commented on a change in pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#discussion_r425055442
##
File path: docs/streams/developer-guide/running-app.html
##
@@ -51,7 +51,7 @@
Running
Streams Applications
You can run Java
showuon commented on a change in pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#discussion_r425055023
##
File path: docs/streams/developer-guide/write-streams.html
##
@@ -208,7 +208,7 @@ Using Kafka Streams within your application code
- Testing a
showuon commented on a change in pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#discussion_r425054711
##
File path: docs/streams/developer-guide/write-streams.html
##
@@ -154,7 +154,7 @@ Using Kafka Streams within your application codeStream Partitions and
showuon commented on a change in pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#discussion_r425054297
##
File path: docs/streams/developer-guide/dsl-api.html
##
@@ -3738,7 +3738,7 @@ KTable-KTable
Foreign-Key
-
chia7712 commented on a change in pull request #8665:
URL: https://github.com/apache/kafka/pull/8665#discussion_r425001861
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##
@@ -1015,8 +1015,8 @@ public void subscribe(Collection
[
https://issues.apache.org/jira/browse/KAFKA-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-7965.
Resolution: Fixed
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107107#comment-17107107
]
David Jacot commented on KAFKA-7965:
Closing it. Please re-open it if needed.
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-7965:
---
Fix Version/s: (was: 2.3.0)
2.6.0
> Flaky Test
>
cadonna commented on a change in pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#discussion_r424984599
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -53,4 +56,48 @@ void
cadonna commented on a change in pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#discussion_r424984599
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -53,4 +56,48 @@ void
cadonna commented on a change in pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#discussion_r424971223
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -53,4 +56,48 @@ void
cadonna commented on a change in pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#discussion_r424971223
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -53,4 +56,48 @@ void
rodesai commented on a change in pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#discussion_r424941145
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -53,4 +56,48 @@ void
rodesai commented on a change in pull request #8254:
URL: https://github.com/apache/kafka/pull/8254#discussion_r424941145
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -53,4 +56,48 @@ void
lkokhreidze commented on pull request #8558:
URL: https://github.com/apache/kafka/pull/8558#issuecomment-628419029
Hi @mjsax
I've rebased the branch.
Do you mean comment by Guozhang in the voting thread? If not, I missed it
and can't find anything new in the DISCUSS thread. Can
[
https://issues.apache.org/jira/browse/KAFKA-9676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen resolved KAFKA-9676.
Resolution: Fixed
The current unit test coverage is pretty good now, closing the ticket.
> Add
[
https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106950#comment-17106950
]
Boyang Chen commented on KAFKA-9989:
I didn't find that in the log [~ableegoldman]
>
abbccdda commented on a change in pull request #8395:
URL: https://github.com/apache/kafka/pull/8395#discussion_r404455662
##
File path: docs/upgrade.html
##
@@ -39,7 +39,8 @@ Notable changes in 2
https://github.com/apache/kafka/tree/2.5/examples;>examples folder.
101 - 188 of 188 matches
Mail list logo