[jira] [Updated] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Dima R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dima R updated KAFKA-10030: --- Description: StreamThreadStateStoreProvider#stores throws exception whenever taskId is not found, which is

[GitHub] [kafka] wj1918 edited a comment on pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
wj1918 edited a comment on pull request #8612: URL: https://github.com/apache/kafka/pull/8612#issuecomment-631579687 call for reviewers @kkonstantine @phstudy @ewencp @hachikuji should have separate commit of refactoring and bug fix. Major change block of

[GitHub] [kafka] wj1918 commented on a change in pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
wj1918 commented on a change in pull request #8612: URL: https://github.com/apache/kafka/pull/8612#discussion_r428622562 ## File path: connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceTask.java ## @@ -77,91 +68,34 @@ public void start(Map props) {

[GitHub] [kafka] wj1918 commented on a change in pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
wj1918 commented on a change in pull request #8612: URL: https://github.com/apache/kafka/pull/8612#discussion_r428621073 ## File path: connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceTask.java ## @@ -63,12 +59,7 @@ public String version() {

[GitHub] [kafka] wj1918 commented on a change in pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
wj1918 commented on a change in pull request #8612: URL: https://github.com/apache/kafka/pull/8612#discussion_r428618604 ## File path: connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceTask.java ## @@ -63,12 +59,7 @@ public String version() {

[jira] [Updated] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Dima R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dima R updated KAFKA-10030: --- External issue URL: (was: https://github.com/apache/kafka/pull/8706) > Throw exception while fetching a

[jira] [Updated] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Dima R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dima R updated KAFKA-10030: --- External issue URL: https://github.com/apache/kafka/pull/8706 > Throw exception while fetching a key from a

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-632027791 @abbccdda Updated, call for review, thanks! This is an automated message from the Apache Git Service. To

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428589350 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428588172 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1147,6 +1175,16 @@ class

[GitHub] [kafka] dima5rr opened a new pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
dima5rr opened a new pull request #8706: URL: https://github.com/apache/kafka/pull/8706 StreamThreadStateStoreProvider#stores throws exception whenever taskId is not found, which is not correct behaviour in multi-threaded env where state store partitions are distributed among several

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428587018 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428586730 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428585617 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428585373 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428585120 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -41,7 +41,7 @@ import

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428583883 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3647,7 +3679,7 @@ void handleResponse(AbstractResponse

[GitHub] [kafka] rajinisivaram opened a new pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-21 Thread GitBox
rajinisivaram opened a new pull request #8705: URL: https://github.com/apache/kafka/pull/8705 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428581576 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupOptions.java ## @@ -37,7 +37,16 @@ public

[GitHub] [kafka] dima5rr closed pull request #8704: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
dima5rr closed pull request #8704: URL: https://github.com/apache/kafka/pull/8704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428580805 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,26 @@ private boolean

[GitHub] [kafka] dima5rr opened a new pull request #8704: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
dima5rr opened a new pull request #8704: URL: https://github.com/apache/kafka/pull/8704 StreamThreadStateStoreProvider#stores throws exception whenever taskId is not found, which is not correct behaviour in multi-threaded env where state store partitions are distributed among several

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428579361 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -236,6 +244,8 @@ private void parseArguments(final String[] args) {

[jira] [Created] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Dima R (Jira)
Dima R created KAFKA-10030: -- Summary: Throw exception while fetching a key from a single partition Key: KAFKA-10030 URL: https://issues.apache.org/jira/browse/KAFKA-10030 Project: Kafka Issue

[jira] [Created] (KAFKA-10029) Selector.completedReceives should not be modified when channel is closed

2020-05-21 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-10029: -- Summary: Selector.completedReceives should not be modified when channel is closed Key: KAFKA-10029 URL: https://issues.apache.org/jira/browse/KAFKA-10029

[GitHub] [kafka] jiameixie commented on a change in pull request #8692: KAFKA-10018: Change command line tools from /bin/sh to /bin/bash

2020-05-21 Thread GitBox
jiameixie commented on a change in pull request #8692: URL: https://github.com/apache/kafka/pull/8692#discussion_r428527359 ## File path: bin/zookeeper-server-stop.sh ## @@ -1,4 +1,4 @@ -#!/bin/sh Review comment: @chia7712 Yes, I modified just now.

[GitHub] [kafka] showuon commented on a change in pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-05-21 Thread GitBox
showuon commented on a change in pull request #8646: URL: https://github.com/apache/kafka/pull/8646#discussion_r428519103 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -133,11 +133,6 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-05-21 Thread GitBox
showuon commented on a change in pull request #8646: URL: https://github.com/apache/kafka/pull/8646#discussion_r428519103 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -133,11 +133,6 @@ public void

[GitHub] [kafka] chia7712 commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-21 Thread GitBox
chia7712 commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r428499696 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -835,9 +836,9 @@ * @param topic the topic name *

[GitHub] [kafka] chia7712 commented on a change in pull request #8692: KAFKA-10018: Change command line tools from /bin/sh to /bin/bash

2020-05-21 Thread GitBox
chia7712 commented on a change in pull request #8692: URL: https://github.com/apache/kafka/pull/8692#discussion_r428496868 ## File path: bin/zookeeper-server-stop.sh ## @@ -1,4 +1,4 @@ -#!/bin/sh Review comment: Should we apply this change to ```zookeeper-shell.sh```

[GitHub] [kafka] chia7712 commented on a change in pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-21 Thread GitBox
chia7712 commented on a change in pull request #8701: URL: https://github.com/apache/kafka/pull/8701#discussion_r428495190 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -180,6 +180,17 @@ object RollParams { } } +sealed trait LogStartIncrementCause Review

[jira] [Updated] (KAFKA-10027) Implement read path for versioning scheme for features

2020-05-21 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10027: - Summary: Implement read path for versioning scheme for features (was: KIP-584:

[jira] [Updated] (KAFKA-10027) Implement read path for feature versioning scheme

2020-05-21 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10027: - Summary: Implement read path for feature versioning scheme (was: Implement read path

[jira] [Updated] (KAFKA-10028) Implement write path for feature versioning scheme

2020-05-21 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10028: - Summary: Implement write path for feature versioning scheme (was: Implement write path

[jira] [Updated] (KAFKA-10028) Implement write path for versioning scheme for features

2020-05-21 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10028: - Summary: Implement write path for versioning scheme for features (was: KIP-584:

[jira] [Created] (KAFKA-10028) KIP-584: Implement write path for versioning scheme for features

2020-05-21 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-10028: Summary: KIP-584: Implement write path for versioning scheme for features Key: KAFKA-10028 URL: https://issues.apache.org/jira/browse/KAFKA-10028 Project:

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-21 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631921191 retest this, please This is an automated message from the Apache Git Service. To respond to the message, please

<    1   2